From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E3A3C6FA82 for ; Thu, 22 Sep 2022 12:55:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231871AbiIVMzN (ORCPT ); Thu, 22 Sep 2022 08:55:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231861AbiIVMyt (ORCPT ); Thu, 22 Sep 2022 08:54:49 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7B32E9CC8 for ; Thu, 22 Sep 2022 05:54:10 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id z20so10898305ljq.3 for ; Thu, 22 Sep 2022 05:54:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=6iOm3ykiEYCxC1y7MhUHMQ31n65A3mybmY95lFp43lM=; b=YMrrxM62da8qNRcPcsPM1f6j5pHpWSlnMRt/k9ArblV9TlykNySfRNF69BfT/CUnNS d1IgmIX8cBoGeK/KzeQKLk9snEUd//Z8IiuFzwStqnPErEbT6CVnJFSzxdZtZfr7a1wo ePKqfoJuLDVgA/ZdKIRApfAyd03xKvat/TKZDIeRdF9Lw65leabKONVnWVXEjKvleQ/I nzsPkPsQA427uSydpgtnwZz9JVyC3GUlHDuPIOTWvjvM+7EN7Ag3dwrNpDgwfVWonYqA GuhLJBaNq9DLDxKviqF9tAZ++Ad5NGIcGstVRhyOjY97y4VMRB7Mu0RBqSTLNiwVGcLX Nj/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=6iOm3ykiEYCxC1y7MhUHMQ31n65A3mybmY95lFp43lM=; b=XUgQFtdJtjZi93giq31mhK5mjV0K/q+aYWL4KkIYd02Z0/o67P39ycMVUeq1F3wNcA 2xgPsMt5ax41Gm7MhDL0C+Ee1XxLoKANoHNnbhFvqre6D0YdhHOMMn2LvPL4/aMIqSZB Zpf6zDXNVg/7lyMI690FrCYKpoIHBeNfpBYkF/B8Liemq+SPuAyX61NbWDXyax/MFMrG lHPbxp/2cnb8BfspwZPML6CAZWBqNnDIRCqKzgflmmOAdJdQyK+NCUKKYvH4AWsULEFJ QWKoZQY6VgJJhFsVurlQAwqIMjBy3l6uv3Yp4uYZmvP3MjR0gco7mdy84mb9tXMOrH+/ 8UZg== X-Gm-Message-State: ACrzQf19/LWAFW2ml3hBrtWSXiZw1Fi+aarxIDFaXvgKBqD2Gq0gbHqS 7CQKlZbqOZYFPNRYkkb6sed9ww== X-Google-Smtp-Source: AMsMyM6o08fe7EJUEoL9IZbLm9HzdOug3LCgJEjROkmEOsMLYtujzse2VqJjxZ68Gea+MQekuYjXKQ== X-Received: by 2002:a2e:8496:0:b0:26b:f230:a55d with SMTP id b22-20020a2e8496000000b0026bf230a55dmr985734ljh.466.1663851248171; Thu, 22 Sep 2022 05:54:08 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id u17-20020a05651220d100b0049ad2619becsm929038lfr.131.2022.09.22.05.54.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 05:54:07 -0700 (PDT) Message-ID: <3c0c6932-89fe-5962-d1c3-57ab6ef577df@linaro.org> Date: Thu, 22 Sep 2022 14:54:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] dt-bindings: iommu: arm,smmu-v3: Relax order of interrupt names Content-Language: en-US To: Jean-Philippe Brucker , will@kernel.org, robin.murphy@arm.com Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220916133145.1910549-1-jean-philippe@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20220916133145.1910549-1-jean-philippe@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/09/2022 15:31, Jean-Philippe Brucker wrote: > The QEMU devicetree uses a different order for SMMUv3 interrupt names, > and there isn't a good reason for enforcing a specific order. Since all > interrupt lines are optional, operating systems should not expect a > fixed interrupt array layout; they should instead match each interrupt > to its name individually. Besides, as a result of commit e4783856a2e8 > ("dt-bindings: iommu: arm,smmu-v3: make PRI IRQ optional"), "cmdq-sync" > and "priq" are already permutable. Relax the interrupt-names array > entirely by allowing any permutation, incidentally making the schema > more readable. > > Note that dt-validate won't allow duplicate names here so we don't need > to specify maxItems or add additional checks, it's quite neat. Nice explanation, much appriecated! Acked-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9252EC6FA82 for ; Thu, 22 Sep 2022 12:55:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NOI8Z1UV8ZIWgy8ZjKtuZXBYbnrCnzsrfNnN2bRBdOs=; b=C5/k1ymBQ4CVLv 6J97e/Lhtw7zR8GWsrJ7HWzBm9y831LOiZA5zUJ1LlobWZlVZ795MGrCx3PyxOVM0ipFVEa00NRK0 qQ0imVWWNpQ2QAH+6KUNyPJ4hwD/qtHCElE4fePc8zCQLb0IfiA9YeystJfHQzmUJfFdQDasgFmqB YpI0eV0LELNOLjhi+NPro4P7RizFI7ctzZJ2sA14YmCIkH4AtE4S3xX4/uaugdGQ9a86klehqPurw U7caDbghJpmpsrD/YWWXO12BGvAuibGe5rlGt5aUsSp9jObCIx/0h1NBy9MBS5BIxzHLLuOZNyA3L +zEfO8oa6pDSburENRCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1obLiY-00FV5I-Fe; Thu, 22 Sep 2022 12:54:14 +0000 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1obLiW-00FV2n-0c for linux-arm-kernel@lists.infradead.org; Thu, 22 Sep 2022 12:54:13 +0000 Received: by mail-lj1-x22f.google.com with SMTP id q17so10839597lji.11 for ; Thu, 22 Sep 2022 05:54:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=6iOm3ykiEYCxC1y7MhUHMQ31n65A3mybmY95lFp43lM=; b=YMrrxM62da8qNRcPcsPM1f6j5pHpWSlnMRt/k9ArblV9TlykNySfRNF69BfT/CUnNS d1IgmIX8cBoGeK/KzeQKLk9snEUd//Z8IiuFzwStqnPErEbT6CVnJFSzxdZtZfr7a1wo ePKqfoJuLDVgA/ZdKIRApfAyd03xKvat/TKZDIeRdF9Lw65leabKONVnWVXEjKvleQ/I nzsPkPsQA427uSydpgtnwZz9JVyC3GUlHDuPIOTWvjvM+7EN7Ag3dwrNpDgwfVWonYqA GuhLJBaNq9DLDxKviqF9tAZ++Ad5NGIcGstVRhyOjY97y4VMRB7Mu0RBqSTLNiwVGcLX Nj/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=6iOm3ykiEYCxC1y7MhUHMQ31n65A3mybmY95lFp43lM=; b=lq49KUhRAiRfGqzbey6L9HlZi8ACIbXRxTPbg+a2hlgN1tjJ7Ik+QcKuYsItP1d8FD sIP8UgMtm4m0nuA3/YV1XgXiYs9NdZBv7Sa5NHws4mxwXItpQLE0nBVO6XwcBx08A1zg 4D+BtJ1yd5jadDJF41BohJPvRkD+jHB5ewYJ1l9PgOzyKZVKHT5UW3BlowG0xq7ZUemd WUZgrsEKHrJQjfFb+Z2txnI39Cn7rAniz3xLp3dkzvSIhj4yOgYJQ19G5nkTbwGUP+yX cf048PyRzalQfLP006BdrgiatLojAVGQdia7vlcKj1E8L1QoFB/0NQDD5dXw5iRBf+38 PbvA== X-Gm-Message-State: ACrzQf0U/XL10oB7xzTrVdb3AEtN07618TcbHqEUI2nKDRI9BCcSj81B v5g4QHuadikabnlKYfgHGh9SFA== X-Google-Smtp-Source: AMsMyM6o08fe7EJUEoL9IZbLm9HzdOug3LCgJEjROkmEOsMLYtujzse2VqJjxZ68Gea+MQekuYjXKQ== X-Received: by 2002:a2e:8496:0:b0:26b:f230:a55d with SMTP id b22-20020a2e8496000000b0026bf230a55dmr985734ljh.466.1663851248171; Thu, 22 Sep 2022 05:54:08 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id u17-20020a05651220d100b0049ad2619becsm929038lfr.131.2022.09.22.05.54.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 05:54:07 -0700 (PDT) Message-ID: <3c0c6932-89fe-5962-d1c3-57ab6ef577df@linaro.org> Date: Thu, 22 Sep 2022 14:54:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] dt-bindings: iommu: arm,smmu-v3: Relax order of interrupt names Content-Language: en-US To: Jean-Philippe Brucker , will@kernel.org, robin.murphy@arm.com Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220916133145.1910549-1-jean-philippe@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20220916133145.1910549-1-jean-philippe@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220922_055412_097909_374329ED X-CRM114-Status: GOOD ( 11.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/09/2022 15:31, Jean-Philippe Brucker wrote: > The QEMU devicetree uses a different order for SMMUv3 interrupt names, > and there isn't a good reason for enforcing a specific order. Since all > interrupt lines are optional, operating systems should not expect a > fixed interrupt array layout; they should instead match each interrupt > to its name individually. Besides, as a result of commit e4783856a2e8 > ("dt-bindings: iommu: arm,smmu-v3: make PRI IRQ optional"), "cmdq-sync" > and "priq" are already permutable. Relax the interrupt-names array > entirely by allowing any permutation, incidentally making the schema > more readable. > > Note that dt-validate won't allow duplicate names here so we don't need > to specify maxItems or add additional checks, it's quite neat. Nice explanation, much appriecated! Acked-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel