From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751726AbdKTQSG (ORCPT ); Mon, 20 Nov 2017 11:18:06 -0500 Received: from mga06.intel.com ([134.134.136.31]:28026 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751598AbdKTQSE (ORCPT ); Mon, 20 Nov 2017 11:18:04 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,428,1505804400"; d="scan'208";a="3928455" Subject: Re: [alsa-devel] [RFC PATCH 1/7] ASoC: Intel: Fix Kconfig To: Takashi Iwai Cc: alsa-devel@alsa-project.org, arnd@arndb.de, vinod.koul@intel.com, linux-kernel@vger.kernel.org, liam.r.girdwood@linux.intel.com, broonie@kernel.org, andriy.shevchenko@linux.intel.com, torvalds@linux-foundation.org References: <20171118000202.22302-1-pierre-louis.bossart@linux.intel.com> <20171118000202.22302-2-pierre-louis.bossart@linux.intel.com> From: Pierre-Louis Bossart Message-ID: <3c0db712-ed68-35ce-d50a-0a4557b42ef1@linux.intel.com> Date: Mon, 20 Nov 2017 10:18:01 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/18/2017 10:49 AM, Takashi Iwai wrote: > On Sat, 18 Nov 2017 01:01:56 +0100, > Pierre-Louis Bossart wrote: >> +if SND_SOC_INTEL_BAYTRAIL >> >> config SND_SOC_INTEL_BYT_MAX98090_MACH >> tristate "ASoC Audio driver for Intel Baytrail with MAX98090 codec" >> + default n > default=n is superfluous, can be dropped. > >> depends on X86_INTEL_LPSS && I2C >> - depends on SND_SST_IPC_ACPI = n >> - depends on SND_SOC_INTEL_BAYTRAIL >> select SND_SOC_MAX98090 > So the dependency on ND_SST_IPC_ACPI=n is removed here too, and I > guess this will allow this machine driver built although it shouldn't > be? This dependency doesn't really make sense any longer at the machine driver level. There is now an explicit layer on the platform side (SND_SOC_INTEL_BAYTRAIL) where the exclusion with SND_SOC_INTEL_HIFI2 platforms should be handled. I also removed this dependency because it was 'one way', I couldn't find a way to show explicit mutual exclusions without getting into circular dependencies. > > > thanks, > > Takashi > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre-Louis Bossart Subject: Re: [RFC PATCH 1/7] ASoC: Intel: Fix Kconfig Date: Mon, 20 Nov 2017 10:18:01 -0600 Message-ID: <3c0db712-ed68-35ce-d50a-0a4557b42ef1@linux.intel.com> References: <20171118000202.22302-1-pierre-louis.bossart@linux.intel.com> <20171118000202.22302-2-pierre-louis.bossart@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by alsa0.perex.cz (Postfix) with ESMTP id 1C0E0266F52 for ; Mon, 20 Nov 2017 17:18:05 +0100 (CET) In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org, arnd@arndb.de, vinod.koul@intel.com, linux-kernel@vger.kernel.org, liam.r.girdwood@linux.intel.com, broonie@kernel.org, andriy.shevchenko@linux.intel.com, torvalds@linux-foundation.org List-Id: alsa-devel@alsa-project.org On 11/18/2017 10:49 AM, Takashi Iwai wrote: > On Sat, 18 Nov 2017 01:01:56 +0100, > Pierre-Louis Bossart wrote: >> +if SND_SOC_INTEL_BAYTRAIL >> >> config SND_SOC_INTEL_BYT_MAX98090_MACH >> tristate "ASoC Audio driver for Intel Baytrail with MAX98090 codec" >> + default n > default=n is superfluous, can be dropped. > >> depends on X86_INTEL_LPSS && I2C >> - depends on SND_SST_IPC_ACPI = n >> - depends on SND_SOC_INTEL_BAYTRAIL >> select SND_SOC_MAX98090 > So the dependency on ND_SST_IPC_ACPI=n is removed here too, and I > guess this will allow this machine driver built although it shouldn't > be? This dependency doesn't really make sense any longer at the machine driver level. There is now an explicit layer on the platform side (SND_SOC_INTEL_BAYTRAIL) where the exclusion with SND_SOC_INTEL_HIFI2 platforms should be handled. I also removed this dependency because it was 'one way', I couldn't find a way to show explicit mutual exclusions without getting into circular dependencies. > > > thanks, > > Takashi > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel