From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58C97C433EF for ; Mon, 15 Nov 2021 12:52:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E745661AE3 for ; Mon, 15 Nov 2021 12:52:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E745661AE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:53554 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmbSr-0004Yo-53 for qemu-devel@archiver.kernel.org; Mon, 15 Nov 2021 07:52:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmbPz-0007va-UN for qemu-devel@nongnu.org; Mon, 15 Nov 2021 07:49:04 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:54047) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmbPx-0004Cp-VZ for qemu-devel@nongnu.org; Mon, 15 Nov 2021 07:49:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636980540; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m14S1J2qicA5TmCBCcBBLInqB50gvC/KVeGN4CJDIKU=; b=LZLm63DWXmuHV+ICTK3bTTk2NSn7RrvkoBQlvJpoPjDPdNLSXl9KBXTfHUnX3EGGjEtF+b LCE3s1QT7EnS7HXjNE6rp83esxfNu6tNpZFTSVE6mlz1/H4bIy3Sh7yNo4crTU8nr/TXJA K77PHPSM5D2GkTYjCHQQctynt1H2od0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-545-XDhgru-AMaCV0Z0VpgFl6A-1; Mon, 15 Nov 2021 07:48:57 -0500 X-MC-Unique: XDhgru-AMaCV0Z0VpgFl6A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 779F018D6A25; Mon, 15 Nov 2021 12:48:56 +0000 (UTC) Received: from [10.39.195.133] (unknown [10.39.195.133]) by smtp.corp.redhat.com (Postfix) with ESMTP id D4D915DF21; Mon, 15 Nov 2021 12:48:51 +0000 (UTC) Message-ID: <3c241757-eea9-90ce-4c86-19391efbba7a@redhat.com> Date: Mon, 15 Nov 2021 13:48:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2] hw/rtc/pl031: Send RTC_CHANGE QMP event To: Peter Maydell , Eric Auger References: <20210920122535.269988-1-eric.auger@redhat.com> From: Paolo Bonzini In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -57 X-Spam_score: -5.8 X-Spam_bar: ----- X-Spam_report: (-5.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.278, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jones , qemu-arm , Gavin Shan , QEMU Developers , Eric Auger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/1/21 17:04, Peter Maydell wrote: > On Thu, 23 Sept 2021 at 14:29, Peter Maydell wrote: >> >> On Mon, 20 Sept 2021 at 13:25, Eric Auger wrote: >>> >>> The PL031 currently is not able to report guest RTC change to the QMP >>> monitor as opposed to mc146818 or spapr RTCs. This patch adds the call >>> to qapi_event_send_rtc_change() when the Load Register is written. The >>> value which is reported corresponds to the difference between the guest >>> reference time and the reference time kept in softmmu/rtc.c. >>> >>> For instance adding 20s to the guest RTC value will report 20. Adding >>> an extra 20s to the guest RTC value will report 20 + 20 = 40. >>> >>> The inclusion of qapi/qapi-types-misc-target.h in hw/rtl/pl031.c >>> require to compile the PL031 with specific_ss.add() to avoid >>> ./qapi/qapi-types-misc-target.h:18:13: error: attempt to use poisoned >>> "TARGET_". >>> >>> Signed-off-by: Eric Auger >>> Signed-off-by: Peter Maydell >> >> Thanks. This looks plausible to me (well, it would ;-)) but >> I would appreciate review from Paolo or somebody else who >> understands the rtc_change feature and handling. > > Ping? Review from somebody who understands rtc_change would > still be nice... The change looks good to me (sorry I missed this v2). x86 also has some logic in the migration post-load, that might end up sending the event. However, that's best done separately after understanding and documenting exactly what x86 is doing. Paolo