From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89761C43461 for ; Tue, 8 Sep 2020 12:56:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25FDD221F0 for ; Tue, 8 Sep 2020 12:56:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="N1A37vEc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730176AbgIHM4A (ORCPT ); Tue, 8 Sep 2020 08:56:00 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:45572 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730099AbgIHLjH (ORCPT ); Tue, 8 Sep 2020 07:39:07 -0400 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200908113710euoutp01a29ba7cec5c13b72be46800ddfaea01e~yy_uTJdX30628106281euoutp01O for ; Tue, 8 Sep 2020 11:37:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200908113710euoutp01a29ba7cec5c13b72be46800ddfaea01e~yy_uTJdX30628106281euoutp01O DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599565030; bh=v/ErI8JZiQ4Gu6SQuSCQ0wdF0up8zANm/1N79AxbHY8=; h=From:Subject:To:Cc:Date:In-Reply-To:References:From; b=N1A37vEcFv99D2JOebOwG7EKFsegFvbx0A5vuS2zLlrkIt9EigcWiKff7If/t2YJT 2zftlZ108TdLMfhNiKqiE0UmFDcw4Rr8+lFY5noHvPu7wNOrvwDn+d1S5UUVxvahwb LZcurBhuZ7XWv87drdzVbzpO+cikyerBUNYBJFTQ= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200908113709eucas1p10a1fb40d4cc8b161aab0807005defe50~yy_tsiMSA0482504825eucas1p1s; Tue, 8 Sep 2020 11:37:09 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 0C.45.05997.5EC675F5; Tue, 8 Sep 2020 12:37:09 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200908113709eucas1p1ef92b424313a618c2f015d8c51094207~yy_td29_61732217322eucas1p18; Tue, 8 Sep 2020 11:37:09 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200908113709eusmtrp10eb8c0d0716671845ed9f3f294ce2f95~yy_tcfWoA2002820028eusmtrp1T; Tue, 8 Sep 2020 11:37:09 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-9a-5f576ce5a999 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id DD.A4.06017.5EC675F5; Tue, 8 Sep 2020 12:37:09 +0100 (BST) Received: from [106.120.51.71] (unknown [106.120.51.71]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200908113708eusmtip2dc0ff00bf34ecab347b3dd056cfc893a~yy_s9Xnnk1482414824eusmtip28; Tue, 8 Sep 2020 11:37:08 +0000 (GMT) From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] coccinelle: api: fix device_attr_show.cocci warnings To: kernel test robot Cc: Denis Efremov , kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Julia Lawall , Daniel Vetter , Nathan Chancellor , Sam Ravnborg , Alex Deucher , Qiujun Huang , Peter Rosin , dri-devel@lists.freedesktop.org Message-ID: <3c266a0e-a2b9-ffde-0768-3b4fa89b0bfe@samsung.com> Date: Tue, 8 Sep 2020 13:37:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20200810092100.GA42813@2f5448a72a42> Content-Language: en-US Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SfUhTYRTGe3fv7u7M2du0PC0zGBVW2iojLhViJnULgjBIK8pWXuxjrtrU Pv6SUpOZlEpKU9EsplPJGjZ1JtiEpi2Lakn0gRqLcrL8KI2FzbzeJP97znN+z3vOgZcm5P1i BX1Km87ptGqNkgogrU99L6O+aBKT13/IX8WUfGwTM3cGPhGMa3yYYlzP2hAzeXeMZEz9TsT0 5Pci5o2tnGI8Vz9TzIg3nWm3VyKm1vcIxQayOa//UGxJR5mEbZ+oItlW4ycJe/fxoIh1u0pF bHvTaTa/zE+yffkOEXuv5C3F/rCE75t/KGBbCqc5lcnpVDHHAk6aXG+oc6P4ojV7EmWhIZkB SWnAm2Dq+RRlQAG0HNci+FraRQrFTwRD7a8kPCXHPxBUlyfMJgZ9oyIBqkHgsHwWC4UXQfed ApKnKLwFCq/VIV4H493QZeYTUjoEr4SWAdNMmsA3CHj3vXomIMMxkNPwa7pB0yReAf7h87y9 CCfBWH+nWEAWQvdt9wwuxRuh0GojeE3gUHjvrhQJejk0e8sJ/n3AOTT4CgYIYe14qO+9hwQd DB5Hk0TQYeAsvk4KgfsI/uR9+5duRlBT7KcEait8fPGb4rcj8GpotKkEeztkD0+QvA04CN55 FwpLBEGRtZQQbBnk5coFehU8MD2gZscaWs3ETaQ0zjnNOOcc45xzjP/nViGyDoVyGfq0VE6/ UctdWKdXp+kztKnrTpxNs6Dpf+f0O362INvkcTvCNFIGykb2HEiWi9WZ+ktpdgQ0oQyRxfU4 j8plKepLlznd2WRdhobT29FSmlSGyqKrB4/Icao6nTvDcec43WxXREsVWagwyh2+NzJOW3yo JiK3ua8vvChhrTXPMa+Y2nc4st88krRD0ZCoeKmq/VoEOipyZ1N0b5tlRUtNrNdRn7TnVg8s mxBfoTOfbJYkPDR3NSZW9DZ2hHnIDuuWqSUL4jI1ps6Jhs6W918Sd3XFVVmG94dsGo+If1Fh NixWjRs8qQeVpP6kesMaQqdX/wVcXQZQcwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrEIsWRmVeSWpSXmKPExsVy+t/xe7pPc8LjDXo2i1lMu7Ob1WLhw7vM Fle+vmezuHJqN6PFn8WfWCyWPTjNaHG2+xqjxeVdc9gsXjU/YrP48LbEYu+h+YwWK35uZXTg 8Wi99JfNY9qB2ewee78tYPHYOesuu8fiPS+ZPJ5cmc7ksXdLlkf37H8sHve7jzN5LJl2lc3j 8ya5AO4oPZui/NKSVIWM/OISW6VoQwsjPUNLCz0jE0s9Q2PzWCsjUyV9O5uU1JzMstQifbsE vYxlVy6zFXwUqNjW8oexgfE1bxcjJ4eEgInEy58fmboYuTiEBJYyStz9cYO5i5EDKCEjcXx9 GUSNsMSfa11sEDWvGSXeTNvKApJgE7CSmNi+ihHEFhbwlDixEmQQJ4eIgKrEjofLwIYyC0xk lmh5+gyqey2jxM2+HcwgVbwCdhKta74zgWxjEVCR+Pe+ECQsKhAhcXjHLEaIEkGJkzOfgC3j FDCSmLhtF1grs4C6xJ95l6BscYlbT+YzQdjyEtvfzmGewCg0C0n7LCQts5C0zELSsoCRZRWj SGppcW56brGRXnFibnFpXrpecn7uJkZgfG879nPLDsaud8GHGAU4GJV4eD94hcULsSaWFVfm HmKU4GBWEuF1Ons6Tog3JbGyKrUoP76oNCe1+BCjKdBvE5mlRJPzgaknryTe0NTQ3MLS0NzY 3NjMQkmct0PgYIyQQHpiSWp2ampBahFMHxMHp1QD4xKh064shYnGxxayfDxvJntu8/4D/48s ZXlk298ZUu1R7SL6d8/dsNQNYcy1qY9ctTZkXvsmsP2PXsq5jn9ty4V/TfLcwGN0Lj/WNSil amlEPceaRHOFIyFWy97EPrW02LA1reuLpumKH5+azPjSJuVNSVoXa/HgyIWEhZrftuVHexyS 3NDHpcRSnJFoqMVcVJwIAGNSKjoFAwAA X-CMS-MailID: 20200908113709eucas1p1ef92b424313a618c2f015d8c51094207 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200810092148eucas1p117cc6af85f23fb6e457fddb913d2b41a X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200810092148eucas1p117cc6af85f23fb6e457fddb913d2b41a References: <202008101736.EtK0s7BQ%lkp@intel.com> <20200810092100.GA42813@2f5448a72a42> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 8/10/20 11:21 AM, kernel test robot wrote: > From: kernel test robot > > drivers/video/fbdev/core/fbcon.c:3509:8-16: WARNING: use scnprintf or sprintf > drivers/video/fbdev/core/fbcon.c:3484:8-16: WARNING: use scnprintf or sprintf > > > From Documentation/filesystems/sysfs.txt: > show() must not use snprintf() when formatting the value to be > returned to user space. If you can guarantee that an overflow > will never happen you can use sprintf() otherwise you must use > scnprintf(). > > Generated by: scripts/coccinelle/api/device_attr_show.cocci > > Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script") > CC: Denis Efremov > Signed-off-by: kernel test robot > --- > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: fc80c51fd4b23ec007e88d4c688f2cac1b8648e7 > commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script > > Please take the patch only if it's a positive warning. Thanks! > > fbcon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- a/drivers/video/fbdev/core/fbcon.c > +++ b/drivers/video/fbdev/core/fbcon.c > @@ -3481,7 +3481,7 @@ static ssize_t show_rotate(struct device > rotate = fbcon_get_rotate(info); > err: > console_unlock(); > - return snprintf(buf, PAGE_SIZE, "%d\n", rotate); > + return scnprintf(buf, PAGE_SIZE, "%d\n", rotate); buf length is at least PAGE_SIZE and rotate val is an int so shouldn't this be converted to use sprintf() instead? > } > > static ssize_t show_cursor_blink(struct device *device, > @@ -3506,7 +3506,7 @@ static ssize_t show_cursor_blink(struct > blink = (ops->flags & FBCON_FLAGS_CURSOR_TIMER) ? 1 : 0; > err: > console_unlock(); > - return snprintf(buf, PAGE_SIZE, "%d\n", blink); > + return scnprintf(buf, PAGE_SIZE, "%d\n", blink); ditto for blink val > } > > static ssize_t store_cursor_blink(struct device *device, > Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B48BDC43461 for ; Tue, 8 Sep 2020 11:37:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 700FE206A4 for ; Tue, 8 Sep 2020 11:37:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="N1A37vEc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 700FE206A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D9DF06E5A4; Tue, 8 Sep 2020 11:37:14 +0000 (UTC) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id CD3496E5A4 for ; Tue, 8 Sep 2020 11:37:13 +0000 (UTC) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200908113710euoutp02e5532a80e696e92fad391e7b3a65892e~yy_uSrPXF0099900999euoutp02B for ; Tue, 8 Sep 2020 11:37:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200908113710euoutp02e5532a80e696e92fad391e7b3a65892e~yy_uSrPXF0099900999euoutp02B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599565030; bh=v/ErI8JZiQ4Gu6SQuSCQ0wdF0up8zANm/1N79AxbHY8=; h=From:Subject:To:Cc:Date:In-Reply-To:References:From; b=N1A37vEcFv99D2JOebOwG7EKFsegFvbx0A5vuS2zLlrkIt9EigcWiKff7If/t2YJT 2zftlZ108TdLMfhNiKqiE0UmFDcw4Rr8+lFY5noHvPu7wNOrvwDn+d1S5UUVxvahwb LZcurBhuZ7XWv87drdzVbzpO+cikyerBUNYBJFTQ= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200908113709eucas1p10a1fb40d4cc8b161aab0807005defe50~yy_tsiMSA0482504825eucas1p1s; Tue, 8 Sep 2020 11:37:09 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 0C.45.05997.5EC675F5; Tue, 8 Sep 2020 12:37:09 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200908113709eucas1p1ef92b424313a618c2f015d8c51094207~yy_td29_61732217322eucas1p18; Tue, 8 Sep 2020 11:37:09 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200908113709eusmtrp10eb8c0d0716671845ed9f3f294ce2f95~yy_tcfWoA2002820028eusmtrp1T; Tue, 8 Sep 2020 11:37:09 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-9a-5f576ce5a999 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id DD.A4.06017.5EC675F5; Tue, 8 Sep 2020 12:37:09 +0100 (BST) Received: from [106.120.51.71] (unknown [106.120.51.71]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200908113708eusmtip2dc0ff00bf34ecab347b3dd056cfc893a~yy_s9Xnnk1482414824eusmtip28; Tue, 8 Sep 2020 11:37:08 +0000 (GMT) From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] coccinelle: api: fix device_attr_show.cocci warnings To: kernel test robot Message-ID: <3c266a0e-a2b9-ffde-0768-3b4fa89b0bfe@samsung.com> Date: Tue, 8 Sep 2020 13:37:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20200810092100.GA42813@2f5448a72a42> Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA02SfUhTYRTGe3fv7u7M2du0PC0zGBVW2iojLhViJnULgjBIK8pWXuxjrtrU Pv6SUpOZlEpKU9EsplPJGjZ1JtiEpi2Lakn0gRqLcrL8KI2FzbzeJP97znN+z3vOgZcm5P1i BX1Km87ptGqNkgogrU99L6O+aBKT13/IX8WUfGwTM3cGPhGMa3yYYlzP2hAzeXeMZEz9TsT0 5Pci5o2tnGI8Vz9TzIg3nWm3VyKm1vcIxQayOa//UGxJR5mEbZ+oItlW4ycJe/fxoIh1u0pF bHvTaTa/zE+yffkOEXuv5C3F/rCE75t/KGBbCqc5lcnpVDHHAk6aXG+oc6P4ojV7EmWhIZkB SWnAm2Dq+RRlQAG0HNci+FraRQrFTwRD7a8kPCXHPxBUlyfMJgZ9oyIBqkHgsHwWC4UXQfed ApKnKLwFCq/VIV4H493QZeYTUjoEr4SWAdNMmsA3CHj3vXomIMMxkNPwa7pB0yReAf7h87y9 CCfBWH+nWEAWQvdt9wwuxRuh0GojeE3gUHjvrhQJejk0e8sJ/n3AOTT4CgYIYe14qO+9hwQd DB5Hk0TQYeAsvk4KgfsI/uR9+5duRlBT7KcEait8fPGb4rcj8GpotKkEeztkD0+QvA04CN55 FwpLBEGRtZQQbBnk5coFehU8MD2gZscaWs3ETaQ0zjnNOOcc45xzjP/nViGyDoVyGfq0VE6/ UctdWKdXp+kztKnrTpxNs6Dpf+f0O362INvkcTvCNFIGykb2HEiWi9WZ+ktpdgQ0oQyRxfU4 j8plKepLlznd2WRdhobT29FSmlSGyqKrB4/Icao6nTvDcec43WxXREsVWagwyh2+NzJOW3yo JiK3ua8vvChhrTXPMa+Y2nc4st88krRD0ZCoeKmq/VoEOipyZ1N0b5tlRUtNrNdRn7TnVg8s mxBfoTOfbJYkPDR3NSZW9DZ2hHnIDuuWqSUL4jI1ps6Jhs6W918Sd3XFVVmG94dsGo+If1Fh NixWjRs8qQeVpP6kesMaQqdX/wVcXQZQcwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrEIsWRmVeSWpSXmKPExsVy+t/xe7pPc8LjDXo2i1lMu7Ob1WLhw7vM Fle+vmezuHJqN6PFn8WfWCyWPTjNaHG2+xqjxeVdc9gsXjU/YrP48LbEYu+h+YwWK35uZXTg 8Wi99JfNY9qB2ewee78tYPHYOesuu8fiPS+ZPJ5cmc7ksXdLlkf37H8sHve7jzN5LJl2lc3j 8ya5AO4oPZui/NKSVIWM/OISW6VoQwsjPUNLCz0jE0s9Q2PzWCsjUyV9O5uU1JzMstQifbsE vYxlVy6zFXwUqNjW8oexgfE1bxcjJ4eEgInEy58fmboYuTiEBJYyStz9cYO5i5EDKCEjcXx9 GUSNsMSfa11sEDWvGSXeTNvKApJgE7CSmNi+ihHEFhbwlDixEmQQJ4eIgKrEjofLwIYyC0xk lmh5+gyqey2jxM2+HcwgVbwCdhKta74zgWxjEVCR+Pe+ECQsKhAhcXjHLEaIEkGJkzOfgC3j FDCSmLhtF1grs4C6xJ95l6BscYlbT+YzQdjyEtvfzmGewCg0C0n7LCQts5C0zELSsoCRZRWj SGppcW56brGRXnFibnFpXrpecn7uJkZgfG879nPLDsaud8GHGAU4GJV4eD94hcULsSaWFVfm HmKU4GBWEuF1Ons6Tog3JbGyKrUoP76oNCe1+BCjKdBvE5mlRJPzgaknryTe0NTQ3MLS0NzY 3NjMQkmct0PgYIyQQHpiSWp2ampBahFMHxMHp1QD4xKh064shYnGxxayfDxvJntu8/4D/48s ZXlk298ZUu1R7SL6d8/dsNQNYcy1qY9ctTZkXvsmsP2PXsq5jn9ty4V/TfLcwGN0Lj/WNSil amlEPceaRHOFIyFWy97EPrW02LA1reuLpumKH5+azPjSJuVNSVoXa/HgyIWEhZrftuVHexyS 3NDHpcRSnJFoqMVcVJwIAGNSKjoFAwAA X-CMS-MailID: 20200908113709eucas1p1ef92b424313a618c2f015d8c51094207 X-Msg-Generator: CA X-RootMTR: 20200810092148eucas1p117cc6af85f23fb6e457fddb913d2b41a X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200810092148eucas1p117cc6af85f23fb6e457fddb913d2b41a References: <202008101736.EtK0s7BQ%lkp@intel.com> <20200810092100.GA42813@2f5448a72a42> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kbuild-all@lists.01.org, Daniel Vetter , linux-kernel@vger.kernel.org, Denis Efremov , Julia Lawall , dri-devel@lists.freedesktop.org, Alex Deucher , Nathan Chancellor , Sam Ravnborg , Peter Rosin , Qiujun Huang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On 8/10/20 11:21 AM, kernel test robot wrote: > From: kernel test robot > > drivers/video/fbdev/core/fbcon.c:3509:8-16: WARNING: use scnprintf or sprintf > drivers/video/fbdev/core/fbcon.c:3484:8-16: WARNING: use scnprintf or sprintf > > > From Documentation/filesystems/sysfs.txt: > show() must not use snprintf() when formatting the value to be > returned to user space. If you can guarantee that an overflow > will never happen you can use sprintf() otherwise you must use > scnprintf(). > > Generated by: scripts/coccinelle/api/device_attr_show.cocci > > Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script") > CC: Denis Efremov > Signed-off-by: kernel test robot > --- > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: fc80c51fd4b23ec007e88d4c688f2cac1b8648e7 > commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script > > Please take the patch only if it's a positive warning. Thanks! > > fbcon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- a/drivers/video/fbdev/core/fbcon.c > +++ b/drivers/video/fbdev/core/fbcon.c > @@ -3481,7 +3481,7 @@ static ssize_t show_rotate(struct device > rotate = fbcon_get_rotate(info); > err: > console_unlock(); > - return snprintf(buf, PAGE_SIZE, "%d\n", rotate); > + return scnprintf(buf, PAGE_SIZE, "%d\n", rotate); buf length is at least PAGE_SIZE and rotate val is an int so shouldn't this be converted to use sprintf() instead? > } > > static ssize_t show_cursor_blink(struct device *device, > @@ -3506,7 +3506,7 @@ static ssize_t show_cursor_blink(struct > blink = (ops->flags & FBCON_FLAGS_CURSOR_TIMER) ? 1 : 0; > err: > console_unlock(); > - return snprintf(buf, PAGE_SIZE, "%d\n", blink); > + return scnprintf(buf, PAGE_SIZE, "%d\n", blink); ditto for blink val > } > > static ssize_t store_cursor_blink(struct device *device, > Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5516608687875149264==" MIME-Version: 1.0 From: Bartlomiej Zolnierkiewicz To: kbuild-all@lists.01.org Subject: Re: [PATCH] coccinelle: api: fix device_attr_show.cocci warnings Date: Tue, 08 Sep 2020 13:37:08 +0200 Message-ID: <3c266a0e-a2b9-ffde-0768-3b4fa89b0bfe@samsung.com> In-Reply-To: <20200810092100.GA42813@2f5448a72a42> List-Id: --===============5516608687875149264== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi, On 8/10/20 11:21 AM, kernel test robot wrote: > From: kernel test robot > = > drivers/video/fbdev/core/fbcon.c:3509:8-16: WARNING: use scnprintf or spr= intf > drivers/video/fbdev/core/fbcon.c:3484:8-16: WARNING: use scnprintf or spr= intf > = > = > From Documentation/filesystems/sysfs.txt: > show() must not use snprintf() when formatting the value to be > returned to user space. If you can guarantee that an overflow > will never happen you can use sprintf() otherwise you must use > scnprintf(). > = > Generated by: scripts/coccinelle/api/device_attr_show.cocci > = > Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script") > CC: Denis Efremov > Signed-off-by: kernel test robot > --- > = > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.gi= t master > head: fc80c51fd4b23ec007e88d4c688f2cac1b8648e7 > commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add dev= ice_attr_show script > = > Please take the patch only if it's a positive warning. Thanks! > = > fbcon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > = > --- a/drivers/video/fbdev/core/fbcon.c > +++ b/drivers/video/fbdev/core/fbcon.c > @@ -3481,7 +3481,7 @@ static ssize_t show_rotate(struct device > rotate =3D fbcon_get_rotate(info); > err: > console_unlock(); > - return snprintf(buf, PAGE_SIZE, "%d\n", rotate); > + return scnprintf(buf, PAGE_SIZE, "%d\n", rotate); buf length is at least PAGE_SIZE and rotate val is an int so shouldn't this be converted to use sprintf() instead? > } > = > static ssize_t show_cursor_blink(struct device *device, > @@ -3506,7 +3506,7 @@ static ssize_t show_cursor_blink(struct > blink =3D (ops->flags & FBCON_FLAGS_CURSOR_TIMER) ? 1 : 0; > err: > console_unlock(); > - return snprintf(buf, PAGE_SIZE, "%d\n", blink); > + return scnprintf(buf, PAGE_SIZE, "%d\n", blink); ditto for blink val > } > = > static ssize_t store_cursor_blink(struct device *device, > = = Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics --===============5516608687875149264==--