From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 2/5] drm/amdgpu: Use the dynamic IP based offset for register access for SOC15 Date: Thu, 30 Nov 2017 09:33:16 +0100 Message-ID: <3c38c52e-48aa-b4d6-1f18-79fdb11402c9@gmail.com> References: <1511982570-8702-1-git-send-email-Shaoyun.Liu@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Liu, Shaoyun" , "Koenig, Christian" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" PiBUaGUgcmVhc29uIHRvIHVzZSBkZWZpbmUgaGVyZSBpcyB0aGUgb3JpZ2luYWwgZnVuY3Rpb24g ZGlkbid0IHRha2UgdGhlIGFkZXYgYXMgcGFyYW1ldGVyLgpZZWFoLCBJJ3ZlIHNlZW4gdGhhdCBh bmQgdGhpcyBpcyBleGFjdGx5IHRoZSByZWFzb24gd2h5IEkgd2FudCB0byBhdm9pZCAKdXNpbmcg YSBtYWNybyBoZXJlIDopCgpJZiB5b3UgZG9uJ3Qgd2FudCB0byBjaGFuZ2UgZXZlcnkgY2FsbGVy IHRoZW4gYXQgbGVhc3QgbWFrZSB0aGUgbWFjcm8gCm5hbWUgY2FwaXRhbCwgc28gdGhhdCB3ZSBj YW4gc2VlIGluIHRoZSBjb2RlIHRoYXQgdGhpcyBpc24ndCBhIGZ1bmN0aW9uLgoKUmVnYXJkcywK Q2hyaXN0aWFuLgoKQW0gMjkuMTEuMjAxNyB1bSAyMTozOCBzY2hyaWViIExpdSwgU2hhb3l1bjoK PiBUaGFua3MgZm9yIHRoZSByZXZpZXcgLiAgVGhlIHJlYXNvbiB0byB1c2UgZGVmaW5lIGhlcmUg aXMgdGhlIG9yaWdpbmFsIGZ1bmN0aW9uIGRpZG4ndCB0YWtlIHRoZSBhZGV2IGFzIHBhcmFtZXRl ciAuICBJZiBJIGNoYW5nZSBpdCBoZXJlICwgYWxsIHRoZSBjYWxsZXIgb2YgdGhpcyBmdW5jdGlv biBuZWVkIHRvIGJlIGNoYW5nZWQgLiBJZiB5b3UgdGhpbmsgdGhhdCdzICBwcm9wZXIgd2F5ICBJ IGNhbiBjaGFuZ2UgaXQuICBCdXQgZG8geW91IHRoaW5rIGl0J3MgIGJldHRlciB0byBwdXQgaXQg aW4gYW5vdGhlciBjaGFuZ2Ugc28gdGhpcyBwYXRjaCAgd2lsbCBsb29rcyBtdWNoIG1vcmUgY2xl YW5lciAuCj4KPiBSZWdhcmRzCj4gU2hhb3l1bi5saXUKPgo+IC0tLS0tT3JpZ2luYWwgTWVzc2Fn ZS0tLS0tCj4gRnJvbTogQ2hyaXN0aWFuIEvDtm5pZyBbbWFpbHRvOmNrb2VuaWcubGVpY2h0enVt ZXJrZW5AZ21haWwuY29tXQo+IFNlbnQ6IFdlZG5lc2RheSwgTm92ZW1iZXIgMjksIDIwMTcgMzow NSBQTQo+IFRvOiBMaXUsIFNoYW95dW47IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4g U3ViamVjdDogUmU6IFtQQVRDSCAyLzVdIGRybS9hbWRncHU6IFVzZSB0aGUgZHluYW1pYyBJUCBi YXNlZCBvZmZzZXQgZm9yIHJlZ2lzdGVyIGFjY2VzcyBmb3IgU09DMTUKPgo+IEFtIDI5LjExLjIw MTcgdW0gMjA6MDkgc2NocmllYiBTaGFveXVuIExpdToKPj4gQ2hhbmdlLUlkOiBJMjlmMzNlZTNi NGJiZDY3MzdmMzQyNjM4NWE5ZTg0NTJmYjUyOGE2Nwo+PiBTaWduZWQtb2ZmLWJ5OiBTaGFveXVu IExpdSA8U2hhb3l1bi5MaXVAYW1kLmNvbT4KPj4gLS0tCj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1L3NkbWFfdjRfMC5jICAgIHwgMjEgKysrLS0tLS0tLS0tLS0tLS0tLQo+PiAgICBk cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9zb2MxNV9jb21tb24uaCB8IDM0ICsrKysrKysrLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0KPj4gICAgMiBmaWxlcyBjaGFuZ2VkLCAxMSBpbnNlcnRpb25z KCspLCA0NCBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1L3NkbWFfdjRfMC5jCj4+IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvc2Rt YV92NF8wLmMKPj4gaW5kZXggNGM1NWYyMS4uZTMyNGM2NiAxMDA2NDQKPj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRncHUvc2RtYV92NF8wLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvc2RtYV92NF8wLmMKPj4gQEAgLTEwNywyNCArMTA3LDkgQEAKPj4gICAgCVNP QzE1X1JFR19PRkZTRVQoU0RNQTAsIDAsIG1tU0RNQTBfR0JfQUREUl9DT05GSUdfUkVBRCksIDB4 MDAxODc3M2YsIDB4MDAwMDAwMDIKPj4gICAgfTsKPj4gICAgCj4+IC1zdGF0aWMgdTMyIHNkbWFf djRfMF9nZXRfcmVnX29mZnNldCh1MzIgaW5zdGFuY2UsIHUzMgo+PiBpbnRlcm5hbF9vZmZzZXQp IC17Cj4+IC0JdTMyIGJhc2UgPSAwOwo+PiAtCj4+IC0Jc3dpdGNoIChpbnN0YW5jZSkgewo+PiAt CWNhc2UgMDoKPj4gLQkJYmFzZSA9IFNETUEwX0JBU0UuaW5zdGFuY2VbMF0uc2VnbWVudFswXTsK Pj4gLQkJYnJlYWs7Cj4+IC0JY2FzZSAxOgo+PiAtCQliYXNlID0gU0RNQTFfQkFTRS5pbnN0YW5j ZVswXS5zZWdtZW50WzBdOwo+PiAtCQlicmVhazsKPj4gLQlkZWZhdWx0Ogo+PiAtCQlCVUcoKTsK Pj4gLQkJYnJlYWs7Cj4+IC0JfQo+PiAtCj4+IC0JcmV0dXJuIGJhc2UgKyBpbnRlcm5hbF9vZmZz ZXQ7Cj4+IC19Cj4+ICsjZGVmaW5lIHNkbWFfdjRfMF9nZXRfcmVnX29mZnNldChpbnN0LCBvZmZz ZXQpICggMCA9PSBpbnN0ID8gXAo+PiArCShhZGV2LT5yZWdfb2Zmc2V0W1NETUEwX0hXSVBdWzBd WzBdICsgb2Zmc2V0KSA6IFwKPj4gKwkoYWRldi0+cmVnX29mZnNldFtTRE1BMV9IV0lQXVswXVsw XSArIG9mZnNldCkpCj4gUGxlYXNlIGtlZXAgdGhhdCBhIGZ1bmN0aW9uLCBub3QgYSBkZWZpbmUu Cj4KPiBBcGFydCBmcm9tIHRoYXQgbG9va3MgcmVhbGx5IGdvb2QgdG8gbWUuCj4KPiBDaHJpc3Rp YW4uCj4KPj4gICAgCj4+ICAgIHN0YXRpYyB2b2lkIHNkbWFfdjRfMF9pbml0X2dvbGRlbl9yZWdp c3RlcnMoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4+ICAgIHsKPj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L3NvYzE1X2NvbW1vbi5oCj4+IGIvZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvc29jMTVfY29tbW9uLmgKPj4gaW5kZXggN2E4ZTRlMjguLjYyYTZl MjEgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L3NvYzE1X2NvbW1v bi5oCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L3NvYzE1X2NvbW1vbi5oCj4+ IEBAIC01NCw0MiArNTQsMjQgQEAgc3RydWN0IG5iaW9fcGNpZV9pbmRleF9kYXRhIHsKPj4gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgCj4+IChpcCMjX0JBU0VfX0lOU1QjI2luc3QjI19TRUc0ICsgcmVnKSkpKSkKPj4gICAgCj4+ ICAgICNkZWZpbmUgV1JFRzMyX0ZJRUxEMTUoaXAsIGlkeCwgcmVnLCBmaWVsZCwgdmFsKQlcCj4+ IC0JV1JFRzMyKFNPQzE1X1JFR19PRkZTRVQoaXAsIGlkeCwgbW0jI3JlZyksIChSUkVHMzIoU09D MTVfUkVHX09GRlNFVChpcCwgaWR4LCBtbSMjcmVnKSkgJiB+UkVHX0ZJRUxEX01BU0socmVnLCBm aWVsZCkpIHwgKHZhbCkgPDwgUkVHX0ZJRUxEX1NISUZUKHJlZywgZmllbGQpKQo+PiArCVdSRUcz MihhZGV2LT5yZWdfb2Zmc2V0W2lwIyNfSFdJUF1baWR4XVttbSMjcmVnIyNfQkFTRV9JRFhdICsg bW0jI3JlZywJXAo+PiArCShSUkVHMzIoYWRldi0+cmVnX29mZnNldFtpcCMjX0hXSVBdW2lkeF1b bW0jI3JlZyMjX0JBU0VfSURYXSArIG1tIyNyZWcpCVwKPj4gKwkmIH5SRUdfRklFTERfTUFTSyhy ZWcsIGZpZWxkKSkgfCAodmFsKSA8PCBSRUdfRklFTERfU0hJRlQocmVnLAo+PiArZmllbGQpKQo+ PiAgICAKPj4gICAgI2RlZmluZSBSUkVHMzJfU09DMTUoaXAsIGluc3QsIHJlZykgXAo+PiAtCVJS RUczMiggKDAgPT0gcmVnIyNfQkFTRV9JRFggPyBpcCMjX0JBU0VfX0lOU1QjI2luc3QjI19TRUcw ICsgcmVnIDogXAo+PiAtCQkoMSA9PSByZWcjI19CQVNFX0lEWCA/IGlwIyNfQkFTRV9fSU5TVCMj aW5zdCMjX1NFRzEgKyByZWcgOiBcCj4+IC0JCSgyID09IHJlZyMjX0JBU0VfSURYID8gaXAjI19C QVNFX19JTlNUIyNpbnN0IyNfU0VHMiArIHJlZyA6IFwKPj4gLQkJKDMgPT0gcmVnIyNfQkFTRV9J RFggPyBpcCMjX0JBU0VfX0lOU1QjI2luc3QjI19TRUczICsgcmVnIDogXAo+PiAtCQkoaXAjI19C QVNFX19JTlNUIyNpbnN0IyNfU0VHNCArIHJlZykpKSkpKQo+PiArCVJSRUczMihhZGV2LT5yZWdf b2Zmc2V0W2lwIyNfSFdJUF1baW5zdF1bcmVnIyNfQkFTRV9JRFhdICsgcmVnKQo+PiAgICAKPj4g ICAgI2RlZmluZSBSUkVHMzJfU09DMTVfT0ZGU0VUKGlwLCBpbnN0LCByZWcsIG9mZnNldCkgXAo+ PiAtCVJSRUczMiggKDAgPT0gcmVnIyNfQkFTRV9JRFggPyBpcCMjX0JBU0VfX0lOU1QjI2luc3Qj I19TRUcwICsgcmVnIDogXAo+PiAtCQkoMSA9PSByZWcjI19CQVNFX0lEWCA/IGlwIyNfQkFTRV9f SU5TVCMjaW5zdCMjX1NFRzEgKyByZWcgOiBcCj4+IC0JCSgyID09IHJlZyMjX0JBU0VfSURYID8g aXAjI19CQVNFX19JTlNUIyNpbnN0IyNfU0VHMiArIHJlZyA6IFwKPj4gLQkJKDMgPT0gcmVnIyNf QkFTRV9JRFggPyBpcCMjX0JBU0VfX0lOU1QjI2luc3QjI19TRUczICsgcmVnIDogXAo+PiAtCQko aXAjI19CQVNFX19JTlNUIyNpbnN0IyNfU0VHNCArIHJlZykpKSkpICsgb2Zmc2V0KQo+PiArCVJS RUczMigoYWRldi0+cmVnX29mZnNldFtpcCMjX0hXSVBdW2luc3RdW3JlZyMjX0JBU0VfSURYXSAr IHJlZykgKwo+PiArb2Zmc2V0KQo+PiAgICAKPj4gICAgI2RlZmluZSBXUkVHMzJfU09DMTUoaXAs IGluc3QsIHJlZywgdmFsdWUpIFwKPj4gLQlXUkVHMzIoICgwID09IHJlZyMjX0JBU0VfSURYID8g aXAjI19CQVNFX19JTlNUIyNpbnN0IyNfU0VHMCArIHJlZyA6IFwKPj4gLQkJKDEgPT0gcmVnIyNf QkFTRV9JRFggPyBpcCMjX0JBU0VfX0lOU1QjI2luc3QjI19TRUcxICsgcmVnIDogXAo+PiAtCQko MiA9PSByZWcjI19CQVNFX0lEWCA/IGlwIyNfQkFTRV9fSU5TVCMjaW5zdCMjX1NFRzIgKyByZWcg OiBcCj4+IC0JCSgzID09IHJlZyMjX0JBU0VfSURYID8gaXAjI19CQVNFX19JTlNUIyNpbnN0IyNf U0VHMyArIHJlZyA6IFwKPj4gLQkJKGlwIyNfQkFTRV9fSU5TVCMjaW5zdCMjX1NFRzQgKyByZWcp KSkpKSwgdmFsdWUpCj4+ICsJV1JFRzMyKChhZGV2LT5yZWdfb2Zmc2V0W2lwIyNfSFdJUF1baW5z dF1bcmVnIyNfQkFTRV9JRFhdICsgcmVnKSwKPj4gK3ZhbHVlKQo+PiAgICAKPj4gICAgI2RlZmlu ZSBXUkVHMzJfU09DMTVfTk9fS0lRKGlwLCBpbnN0LCByZWcsIHZhbHVlKSBcCj4+IC0JV1JFRzMy X05PX0tJUSggKDAgPT0gcmVnIyNfQkFTRV9JRFggPyBpcCMjX0JBU0VfX0lOU1QjI2luc3QjI19T RUcwICsgcmVnIDogXAo+PiAtCQkoMSA9PSByZWcjI19CQVNFX0lEWCA/IGlwIyNfQkFTRV9fSU5T VCMjaW5zdCMjX1NFRzEgKyByZWcgOiBcCj4+IC0JCSgyID09IHJlZyMjX0JBU0VfSURYID8gaXAj I19CQVNFX19JTlNUIyNpbnN0IyNfU0VHMiArIHJlZyA6IFwKPj4gLQkJKDMgPT0gcmVnIyNfQkFT RV9JRFggPyBpcCMjX0JBU0VfX0lOU1QjI2luc3QjI19TRUczICsgcmVnIDogXAo+PiAtCQkoaXAj I19CQVNFX19JTlNUIyNpbnN0IyNfU0VHNCArIHJlZykpKSkpLCB2YWx1ZSkKPj4gKwlXUkVHMzJf Tk9fS0lRKChhZGV2LT5yZWdfb2Zmc2V0W2lwIyNfSFdJUF1baW5zdF1bcmVnIyNfQkFTRV9JRFhd ICsKPj4gK3JlZyksIHZhbHVlKQo+PiAgICAKPj4gICAgI2RlZmluZSBXUkVHMzJfU09DMTVfT0ZG U0VUKGlwLCBpbnN0LCByZWcsIG9mZnNldCwgdmFsdWUpIFwKPj4gLQlXUkVHMzIoICgwID09IHJl ZyMjX0JBU0VfSURYID8gaXAjI19CQVNFX19JTlNUIyNpbnN0IyNfU0VHMCArIHJlZyA6IFwKPj4g LQkJKDEgPT0gcmVnIyNfQkFTRV9JRFggPyBpcCMjX0JBU0VfX0lOU1QjI2luc3QjI19TRUcxICsg cmVnIDogXAo+PiAtCQkoMiA9PSByZWcjI19CQVNFX0lEWCA/IGlwIyNfQkFTRV9fSU5TVCMjaW5z dCMjX1NFRzIgKyByZWcgOiBcCj4+IC0JCSgzID09IHJlZyMjX0JBU0VfSURYID8gaXAjI19CQVNF X19JTlNUIyNpbnN0IyNfU0VHMyArIHJlZyA6IFwKPj4gLQkJKGlwIyNfQkFTRV9fSU5TVCMjaW5z dCMjX1NFRzQgKyByZWcpKSkpKSArIG9mZnNldCwgdmFsdWUpCj4+ICsJV1JFRzMyKChhZGV2LT5y ZWdfb2Zmc2V0W2lwIyNfSFdJUF1baW5zdF1bcmVnIyNfQkFTRV9JRFhdICsgcmVnKSArCj4+ICtv ZmZzZXQsIHZhbHVlKQo+PiAgICAKPj4gICAgI2VuZGlmCj4+ICAgIAo+IF9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gYW1kLWdmeCBtYWlsaW5nIGxpc3QK PiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9hbWQtZ2Z4Cg==