From mboxrd@z Thu Jan 1 00:00:00 1970 From: Toshiaki Makita Subject: Re: unexpected GRO/veth behavior Date: Tue, 11 Sep 2018 20:07:20 +0900 Message-ID: <3c396829-61b4-f4ca-6b30-1ac8ff99c7b4@lab.ntt.co.jp> References: <4106d3f7eee7f0186fcfdd0331cdafeecd3240c0.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org Return-path: Received: from tama500.ecl.ntt.co.jp ([129.60.39.148]:45307 "EHLO tama500.ecl.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726713AbeIKQGo (ORCPT ); Tue, 11 Sep 2018 12:06:44 -0400 In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 2018/09/11 19:27, Eric Dumazet wrote: ... > Fix would probably be : > > diff --git a/drivers/net/veth.c b/drivers/net/veth.c > index 8d679c8b7f25c753d77cfb8821d9d2528c9c9048..96bd94480942b469403abf017f9f9d5be1e23ef5 100644 > --- a/drivers/net/veth.c > +++ b/drivers/net/veth.c > @@ -602,9 +602,10 @@ static int veth_xdp_rcv(struct veth_rq *rq, int budget, unsigned int *xdp_xmit) > skb = veth_xdp_rcv_skb(rq, ptr, xdp_xmit); > } > > - if (skb) > + if (skb) { > + skb_orphan(skb); > napi_gro_receive(&rq->xdp_napi, skb); > - > + } > done++; > } Considering commit 9c4c3252 ("skbuff: preserve sock reference when scrubbing the skb.") I'm not sure if we should unconditionally orphan the skb here. I was thinking I should call netif_receive_skb() for such packets instead of napi_gro_receive(). -- Toshiaki Makita