From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C52FDC55ABD for ; Tue, 10 Nov 2020 02:52:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C7D9207D3 for ; Tue, 10 Nov 2020 02:52:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729452AbgKJCwS (ORCPT ); Mon, 9 Nov 2020 21:52:18 -0500 Received: from smtprelay0242.hostedemail.com ([216.40.44.242]:52914 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727311AbgKJCwS (ORCPT ); Mon, 9 Nov 2020 21:52:18 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id F008012CB; Tue, 10 Nov 2020 02:52:13 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: ink22_1714ef1272f1 X-Filterd-Recvd-Size: 2439 Received: from [192.168.0.160] (cpe-72-134-80-165.natsow.res.rr.com [72.134.80.165]) (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA; Tue, 10 Nov 2020 02:52:09 +0000 (UTC) Message-ID: <3c39c363690d0b46069afddc3ad09213011e5cd4.camel@perches.com> Subject: Re: Subject: [RFC] clang tooling cleanups From: Joe Perches To: trix@redhat.com, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, cocci Cc: linux-pm@vger.kernel.org, linux-crypto@vger.kernel.org, qat-linux@intel.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-iio@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-rtc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-samsung-soc@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-nfs@vger.kernel.org, tipc-discussion@lists.sourceforge.net, alsa-devel@alsa-project.org, linux-rpi-kernel@lists.infradead.org, linux-tegra@vger.kernel.org Date: Mon, 09 Nov 2020 18:52:08 -0800 In-Reply-To: <20201027164255.1573301-1-trix@redhat.com> References: <20201027164255.1573301-1-trix@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, 2020-10-27 at 09:42 -0700, trix@redhat.com wrote: > This rfc will describe > An upcoming treewide cleanup. > How clang tooling was used to programatically do the clean up. > Solicit opinions on how to generally use clang tooling. > > The clang warning -Wextra-semi-stmt produces about 10k warnings. > Reviewing these, a subset of semicolon after a switch looks safe to > fix all the time. An example problem > > void foo(int a) { >      switch(a) { >       case 1: > ... >      }; <--- extra semicolon > } > > Treewide, there are about 100 problems in 50 files for x86_64 allyesconfig. > These fixes will be the upcoming cleanup. coccinelle already does some of these. For instance: scripts/coccinelle/misc/semicolon.cocci Perhaps some tool coordination can be done here as coccinelle/checkpatch/clang/Lindent call all be used to do some facet or another of these cleanup issues. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DA28C2D0A3 for ; Tue, 10 Nov 2020 02:53:17 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDA04207D3 for ; Tue, 10 Nov 2020 02:53:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Nsyaz47t" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDA04207D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 255F8852; Tue, 10 Nov 2020 03:52:22 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 255F8852 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1604976792; bh=vFOusr1hJLpH35pWwzUEkL8zQzz3cD29HNAGi/uNRpU=; h=Subject:From:To:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Nsyaz47tpz09mNElacGBM7FCPTz8e33vvAaMdW/HOkalQr+X2GNvkOUOX9IUwhcpS omacrV2CIpi6Qosi2+BWVmxsRIP/mPCd5yHfKkwdP1WYcjLdLpxhgpWE5RXFkWGe/I jEAxF8mpFNuYVE9YDQ0zMXvDXn+s4IxxZSKk7cyg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 94357F80161; Tue, 10 Nov 2020 03:52:21 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D01C0F801D5; Tue, 10 Nov 2020 03:52:19 +0100 (CET) Received: from smtprelay.hostedemail.com (smtprelay0025.hostedemail.com [216.40.44.25]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C08EDF800EB for ; Tue, 10 Nov 2020 03:52:16 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C08EDF800EB Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id F008012CB; Tue, 10 Nov 2020 02:52:13 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: ink22_1714ef1272f1 X-Filterd-Recvd-Size: 2439 Received: from [192.168.0.160] (cpe-72-134-80-165.natsow.res.rr.com [72.134.80.165]) (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA; Tue, 10 Nov 2020 02:52:09 +0000 (UTC) Message-ID: <3c39c363690d0b46069afddc3ad09213011e5cd4.camel@perches.com> Subject: Re: Subject: [RFC] clang tooling cleanups From: Joe Perches To: trix@redhat.com, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, cocci Date: Mon, 09 Nov 2020 18:52:08 -0800 In-Reply-To: <20201027164255.1573301-1-trix@redhat.com> References: <20201027164255.1573301-1-trix@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: alsa-devel@alsa-project.org, linux-aspeed@lists.ozlabs.org, linux-iio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-rdma@vger.kernel.org, qat-linux@intel.com, amd-gfx@lists.freedesktop.org, linux-pm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 2020-10-27 at 09:42 -0700, trix@redhat.com wrote: > This rfc will describe > An upcoming treewide cleanup. > How clang tooling was used to programatically do the clean up. > Solicit opinions on how to generally use clang tooling. > > The clang warning -Wextra-semi-stmt produces about 10k warnings. > Reviewing these, a subset of semicolon after a switch looks safe to > fix all the time. An example problem > > void foo(int a) { >      switch(a) { >       case 1: > ... >      }; <--- extra semicolon > } > > Treewide, there are about 100 problems in 50 files for x86_64 allyesconfig. > These fixes will be the upcoming cleanup. coccinelle already does some of these. For instance: scripts/coccinelle/misc/semicolon.cocci Perhaps some tool coordination can be done here as coccinelle/checkpatch/clang/Lindent call all be used to do some facet or another of these cleanup issues. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BDC0C4742C for ; Tue, 10 Nov 2020 14:04:12 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34EA320797 for ; Tue, 10 Nov 2020 14:04:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34EA320797 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id 0AAE3hTT029675; Tue, 10 Nov 2020 15:03:43 +0100 (CET) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id 1AB4874CE; Tue, 10 Nov 2020 15:03:43 +0100 (CET) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id E5A98454B for ; Tue, 10 Nov 2020 14:28:00 +0100 (CET) Received: from smtprelay.hostedemail.com (smtprelay0003.hostedemail.com [216.40.44.3]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id 0AADRxEw016844 for ; Tue, 10 Nov 2020 14:28:00 +0100 (CET) Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave01.hostedemail.com (Postfix) with ESMTP id 8102F180196A2 for ; Tue, 10 Nov 2020 02:52:17 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id F008012CB; Tue, 10 Nov 2020 02:52:13 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: ink22_1714ef1272f1 X-Filterd-Recvd-Size: 2439 Received: from [192.168.0.160] (cpe-72-134-80-165.natsow.res.rr.com [72.134.80.165]) (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA; Tue, 10 Nov 2020 02:52:09 +0000 (UTC) Message-ID: <3c39c363690d0b46069afddc3ad09213011e5cd4.camel@perches.com> From: Joe Perches To: trix@redhat.com, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, cocci Date: Mon, 09 Nov 2020 18:52:08 -0800 In-Reply-To: <20201027164255.1573301-1-trix@redhat.com> References: <20201027164255.1573301-1-trix@redhat.com> User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Tue, 10 Nov 2020 15:03:43 +0100 (CET) X-Greylist: Delayed for 10:35:45 by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Tue, 10 Nov 2020 14:28:00 +0100 (CET) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Mailman-Approved-At: Tue, 10 Nov 2020 15:03:41 +0100 Cc: alsa-devel@alsa-project.org, linux-aspeed@lists.ozlabs.org, linux-iio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-rdma@vger.kernel.org, qat-linux@intel.com, amd-gfx@lists.freedesktop.org, linux-pm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [Cocci] Subject: [RFC] clang tooling cleanups X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr On Tue, 2020-10-27 at 09:42 -0700, trix@redhat.com wrote: > This rfc will describe > An upcoming treewide cleanup. > How clang tooling was used to programatically do the clean up. > Solicit opinions on how to generally use clang tooling. > = > The clang warning -Wextra-semi-stmt produces about 10k warnings. > Reviewing these, a subset of semicolon after a switch looks safe to > fix all the time. An example problem > = > void foo(int a) { > =A0=A0=A0=A0=A0switch(a) { > =A0=A0=A0=A0=A0 case 1: > ... > =A0=A0=A0=A0=A0}; <--- extra semicolon > } > = > Treewide, there are about 100 problems in 50 files for x86_64 allyesconfi= g. > These fixes will be the upcoming cleanup. coccinelle already does some of these. For instance: scripts/coccinelle/misc/semicolon.cocci Perhaps some tool coordination can be done here as coccinelle/checkpatch/clang/Lindent call all be used to do some facet or another of these cleanup issues. _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1BF3C5517A for ; Tue, 10 Nov 2020 02:52:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 241DA206ED for ; Tue, 10 Nov 2020 02:52:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ve83W9/V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 241DA206ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zgezQLJ8Rt8RSVvQxZIypCm2NRgBhg4cl8U691wgFCQ=; b=ve83W9/VIPgKGeXmDrPOIFWfh Er822cF395rSEJGuX8ODzkLAgV8vEEzyXAAAcWxzDwyKEnFJ18zHyR2V7sMhWMCKViIlWr+z8d0l2 bXGsHwaUBAoggDIw3xgZJoN23vWcMX5PykLC/ngSZFIOPPjmxckmh2GvIEyvRG9JS1+F47hCAEJfR HIcN0rKaTqATYC05mihocRKjj9OivbsSlEdZWnaDAM+BUSmVbG37fyYD9A+xLiN6aPqRbeFCzyPY0 Vf/VYwYcMyx+rgFWt1zIyAxFXX79i2EL4kCIHRXACn8RUWit8T8HuMsqxN09I5nKDLHPJ9X2ZAoYh trIStKiMg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcJle-0002fJ-H2; Tue, 10 Nov 2020 02:52:22 +0000 Received: from smtprelay0101.hostedemail.com ([216.40.44.101] helo=smtprelay.hostedemail.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcJla-0002du-VE; Tue, 10 Nov 2020 02:52:19 +0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id F008012CB; Tue, 10 Nov 2020 02:52:13 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: ink22_1714ef1272f1 X-Filterd-Recvd-Size: 2439 Received: from [192.168.0.160] (cpe-72-134-80-165.natsow.res.rr.com [72.134.80.165]) (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA; Tue, 10 Nov 2020 02:52:09 +0000 (UTC) Message-ID: <3c39c363690d0b46069afddc3ad09213011e5cd4.camel@perches.com> Subject: Re: Subject: [RFC] clang tooling cleanups From: Joe Perches To: trix@redhat.com, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, cocci Date: Mon, 09 Nov 2020 18:52:08 -0800 In-Reply-To: <20201027164255.1573301-1-trix@redhat.com> References: <20201027164255.1573301-1-trix@redhat.com> User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201109_215219_066706_069BB8BC X-CRM114-Status: UNSURE ( 9.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, linux-aspeed@lists.ozlabs.org, linux-iio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-rdma@vger.kernel.org, qat-linux@intel.com, amd-gfx@lists.freedesktop.org, linux-pm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 2020-10-27 at 09:42 -0700, trix@redhat.com wrote: > This rfc will describe > An upcoming treewide cleanup. > How clang tooling was used to programatically do the clean up. > Solicit opinions on how to generally use clang tooling. > = > The clang warning -Wextra-semi-stmt produces about 10k warnings. > Reviewing these, a subset of semicolon after a switch looks safe to > fix all the time. An example problem > = > void foo(int a) { > =A0=A0=A0=A0=A0switch(a) { > =A0=A0=A0=A0=A0 case 1: > ... > =A0=A0=A0=A0=A0}; <--- extra semicolon > } > = > Treewide, there are about 100 problems in 50 files for x86_64 allyesconfi= g. > These fixes will be the upcoming cleanup. coccinelle already does some of these. For instance: scripts/coccinelle/misc/semicolon.cocci Perhaps some tool coordination can be done here as coccinelle/checkpatch/clang/Lindent call all be used to do some facet or another of these cleanup issues. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89E88C4741F for ; Tue, 10 Nov 2020 02:52:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3727206ED for ; Tue, 10 Nov 2020 02:52:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3727206ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A198189533; Tue, 10 Nov 2020 02:52:16 +0000 (UTC) Received: from smtprelay.hostedemail.com (smtprelay0179.hostedemail.com [216.40.44.179]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1783E89533; Tue, 10 Nov 2020 02:52:14 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id F008012CB; Tue, 10 Nov 2020 02:52:13 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: ink22_1714ef1272f1 X-Filterd-Recvd-Size: 2439 Received: from [192.168.0.160] (cpe-72-134-80-165.natsow.res.rr.com [72.134.80.165]) (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA; Tue, 10 Nov 2020 02:52:09 +0000 (UTC) Message-ID: <3c39c363690d0b46069afddc3ad09213011e5cd4.camel@perches.com> Subject: Re: Subject: [RFC] clang tooling cleanups From: Joe Perches To: trix@redhat.com, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, cocci Date: Mon, 09 Nov 2020 18:52:08 -0800 In-Reply-To: <20201027164255.1573301-1-trix@redhat.com> References: <20201027164255.1573301-1-trix@redhat.com> User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, linux-aspeed@lists.ozlabs.org, linux-iio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-rdma@vger.kernel.org, qat-linux@intel.com, amd-gfx@lists.freedesktop.org, linux-pm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 2020-10-27 at 09:42 -0700, trix@redhat.com wrote: > This rfc will describe > An upcoming treewide cleanup. > How clang tooling was used to programatically do the clean up. > Solicit opinions on how to generally use clang tooling. > = > The clang warning -Wextra-semi-stmt produces about 10k warnings. > Reviewing these, a subset of semicolon after a switch looks safe to > fix all the time. An example problem > = > void foo(int a) { > =A0=A0=A0=A0=A0switch(a) { > =A0=A0=A0=A0=A0 case 1: > ... > =A0=A0=A0=A0=A0}; <--- extra semicolon > } > = > Treewide, there are about 100 problems in 50 files for x86_64 allyesconfi= g. > These fixes will be the upcoming cleanup. coccinelle already does some of these. For instance: scripts/coccinelle/misc/semicolon.cocci Perhaps some tool coordination can be done here as coccinelle/checkpatch/clang/Lindent call all be used to do some facet or another of these cleanup issues. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDCF6C55ABD for ; Tue, 10 Nov 2020 08:25:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 657C920829 for ; Tue, 10 Nov 2020 08:25:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 657C920829 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 81FB7898A8; Tue, 10 Nov 2020 08:25:46 +0000 (UTC) Received: from smtprelay.hostedemail.com (smtprelay0179.hostedemail.com [216.40.44.179]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1783E89533; Tue, 10 Nov 2020 02:52:14 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id F008012CB; Tue, 10 Nov 2020 02:52:13 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: ink22_1714ef1272f1 X-Filterd-Recvd-Size: 2439 Received: from [192.168.0.160] (cpe-72-134-80-165.natsow.res.rr.com [72.134.80.165]) (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA; Tue, 10 Nov 2020 02:52:09 +0000 (UTC) Message-ID: <3c39c363690d0b46069afddc3ad09213011e5cd4.camel@perches.com> Subject: Re: Subject: [RFC] clang tooling cleanups From: Joe Perches To: trix@redhat.com, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, cocci Date: Mon, 09 Nov 2020 18:52:08 -0800 In-Reply-To: <20201027164255.1573301-1-trix@redhat.com> References: <20201027164255.1573301-1-trix@redhat.com> User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 X-Mailman-Approved-At: Tue, 10 Nov 2020 08:25:45 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, linux-aspeed@lists.ozlabs.org, linux-iio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-rdma@vger.kernel.org, qat-linux@intel.com, amd-gfx@lists.freedesktop.org, linux-pm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Tue, 2020-10-27 at 09:42 -0700, trix@redhat.com wrote: > This rfc will describe > An upcoming treewide cleanup. > How clang tooling was used to programatically do the clean up. > Solicit opinions on how to generally use clang tooling. > = > The clang warning -Wextra-semi-stmt produces about 10k warnings. > Reviewing these, a subset of semicolon after a switch looks safe to > fix all the time. An example problem > = > void foo(int a) { > =A0=A0=A0=A0=A0switch(a) { > =A0=A0=A0=A0=A0 case 1: > ... > =A0=A0=A0=A0=A0}; <--- extra semicolon > } > = > Treewide, there are about 100 problems in 50 files for x86_64 allyesconfi= g. > These fixes will be the upcoming cleanup. coccinelle already does some of these. For instance: scripts/coccinelle/misc/semicolon.cocci Perhaps some tool coordination can be done here as coccinelle/checkpatch/clang/Lindent call all be used to do some facet or another of these cleanup issues. _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56BDDC2D0A3 for ; Tue, 10 Nov 2020 02:52:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA9BE206ED for ; Tue, 10 Nov 2020 02:52:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="H/waKqN6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA9BE206ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rUmaDqZzYkWJuDfQUnPb76qt9C8p6hgkyuEPEN8ULns=; b=H/waKqN6hmMJihModLDfo+aek dNf8CoTyWgdhS3OYwUzsbHYkqEO43ZDK8DyJvBqB1/IxyE9BLZSRbBgYK1dw3BLyLDmSs41T5utu8 XcLbKJ1h/HwXT+E4WwxON2VFkGo9PKPQRu6vSZEqO0QgT5WSXLPH17xlNDX8vnroafBzVWlqXjWQ7 A6wNuKpTMKwAyvGFoO1DMBZg0376ovMbKxQ7ScuVTU8hlar7tyblCUdtPItMXUaQDT72aT4OZhHoE htMCfhaxk1Ewi91jh24KqIWTYoTWpcSEOQmrTmglYN5lOIf888dGoMd90zO9oxezP5KSsRAVfxkQy Jws9ayEYg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcJld-0002ef-BC; Tue, 10 Nov 2020 02:52:21 +0000 Received: from smtprelay0101.hostedemail.com ([216.40.44.101] helo=smtprelay.hostedemail.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcJla-0002du-VE; Tue, 10 Nov 2020 02:52:19 +0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id F008012CB; Tue, 10 Nov 2020 02:52:13 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: ink22_1714ef1272f1 X-Filterd-Recvd-Size: 2439 Received: from [192.168.0.160] (cpe-72-134-80-165.natsow.res.rr.com [72.134.80.165]) (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA; Tue, 10 Nov 2020 02:52:09 +0000 (UTC) Message-ID: <3c39c363690d0b46069afddc3ad09213011e5cd4.camel@perches.com> Subject: Re: Subject: [RFC] clang tooling cleanups From: Joe Perches To: trix@redhat.com, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, cocci Date: Mon, 09 Nov 2020 18:52:08 -0800 In-Reply-To: <20201027164255.1573301-1-trix@redhat.com> References: <20201027164255.1573301-1-trix@redhat.com> User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201109_215219_066706_069BB8BC X-CRM114-Status: UNSURE ( 9.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, linux-aspeed@lists.ozlabs.org, linux-iio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-rdma@vger.kernel.org, qat-linux@intel.com, amd-gfx@lists.freedesktop.org, linux-pm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Tue, 2020-10-27 at 09:42 -0700, trix@redhat.com wrote: > This rfc will describe > An upcoming treewide cleanup. > How clang tooling was used to programatically do the clean up. > Solicit opinions on how to generally use clang tooling. > = > The clang warning -Wextra-semi-stmt produces about 10k warnings. > Reviewing these, a subset of semicolon after a switch looks safe to > fix all the time. An example problem > = > void foo(int a) { > =A0=A0=A0=A0=A0switch(a) { > =A0=A0=A0=A0=A0 case 1: > ... > =A0=A0=A0=A0=A0}; <--- extra semicolon > } > = > Treewide, there are about 100 problems in 50 files for x86_64 allyesconfi= g. > These fixes will be the upcoming cleanup. coccinelle already does some of these. For instance: scripts/coccinelle/misc/semicolon.cocci Perhaps some tool coordination can be done here as coccinelle/checkpatch/clang/Lindent call all be used to do some facet or another of these cleanup issues. _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic