From: Bart Van Assche <bvanassche@acm.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Daejun Park <daejun7.park@samsung.com>,
Bean Huo <beanhuo@micron.com>, Can Guo <cang@codeaurora.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Avri Altman <avri.altman@wdc.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Asutosh Das <asutoshd@codeaurora.org>
Subject: Re: [PATCH 5/5] scsi: ufs: Add a sysfs attribute for triggering the UFS EH
Date: Wed, 13 Oct 2021 09:50:11 -0700 [thread overview]
Message-ID: <3c42ab83-3344-418c-5523-1640dd29f018@acm.org> (raw)
In-Reply-To: <YWaIcpHbK4e6ELih@kroah.com>
On 10/13/21 12:19 AM, Greg Kroah-Hartman wrote:
>> static const struct attribute_group *ufshcd_driver_groups[] = {
>> &ufs_sysfs_unit_descriptor_group,
>> &ufs_sysfs_lun_attributes_group,
>> @@ -8183,6 +8219,7 @@ static struct scsi_host_template ufshcd_driver_template = {
>> .max_segment_size = PRDT_DATA_BYTE_COUNT_MAX,
>> .max_host_blocked = 1,
>> .track_queue_depth = 1,
>> + .shost_attrs = ufshcd_shost_attrs,
>
> Why can't this get added to the sdev_groups list?
The UFS error handler resets the host controller. There is one SCSI host
per UFS host controller. Hence the choice to associate the sysfs
attribute with the SCSI host.
There is one SCSI sdev per SCSI LUN. Although I'm not sure this can
happen for UFS, it is possible that zero SCSI devices (sdevs) are
associated with a SCSI host.
Bart.
next prev parent reply other threads:[~2021-10-13 16:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 21:54 [PATCH 0/5] UFS patches for kernel v5.16 Bart Van Assche
2021-10-12 21:54 ` [PATCH 1/5] scsi: ufs: Revert "Retry aborted SCSI commands instead of completing these successfully" Bart Van Assche
2021-10-12 21:54 ` [PATCH 2/5] scsi: ufs: Improve source code comments Bart Van Assche
2021-10-12 21:54 ` [PATCH 3/5] scsi: ufs: Improve static type checking Bart Van Assche
2021-10-12 21:54 ` [PATCH 4/5] scsi: ufs: Log error handler activity Bart Van Assche
2021-10-13 7:43 ` Adrian Hunter
2021-10-12 21:54 ` [PATCH 5/5] scsi: ufs: Add a sysfs attribute for triggering the UFS EH Bart Van Assche
2021-10-13 7:19 ` Greg Kroah-Hartman
2021-10-13 16:50 ` Bart Van Assche [this message]
2021-10-13 8:09 ` Adrian Hunter
2021-10-13 10:11 ` Avri Altman
2021-10-13 16:56 ` Bart Van Assche
2021-10-14 6:11 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c42ab83-3344-418c-5523-1640dd29f018@acm.org \
--to=bvanassche@acm.org \
--cc=adrian.hunter@intel.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=cang@codeaurora.org \
--cc=daejun7.park@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=martin.petersen@oracle.com \
--cc=mchehab+huawei@kernel.org \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.