From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0883AC10DCE for ; Thu, 12 Mar 2020 22:51:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C4931206CD for ; Thu, 12 Mar 2020 22:51:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="ecEYYmaR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726608AbgCLWvx (ORCPT ); Thu, 12 Mar 2020 18:51:53 -0400 Received: from smtp-fw-9101.amazon.com ([207.171.184.25]:31580 "EHLO smtp-fw-9101.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726513AbgCLWvw (ORCPT ); Thu, 12 Mar 2020 18:51:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1584053513; x=1615589513; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=APmuTEj00jSwH9UdKFoz86SYSwY6N2q5esvdw5Bdl+o=; b=ecEYYmaRVNMS+YIAPUNaFPu4KOI9ow4wXEonCS4K5gw22JkwEjqyNCfj ThnppnmJ9xKzs8xK32WjQ7/YHF3PH36ejOUcqnWCakDGeye545GjBBXdI NxMn91IyDjlQdKJe6tvy5ziR3KXSTBUQvrzHZGDE96zy1Un8pdtWiliHv w=; IronPort-SDR: ugjucCAlacrlOlBoX7R+p/ruO8wypS9aieV7ZL/kdFBMiPo3e2F7WuMI4vhcZCTvJ8GlrtvpiT e4ImMoCq71Cg== X-IronPort-AV: E=Sophos;i="5.70,546,1574121600"; d="scan'208";a="22562882" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-1e-303d0b0e.us-east-1.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-9101.sea19.amazon.com with ESMTP; 12 Mar 2020 22:51:50 +0000 Received: from EX13MTAUWB001.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan3.iad.amazon.com [10.40.159.166]) by email-inbound-relay-1e-303d0b0e.us-east-1.amazon.com (Postfix) with ESMTPS id C14F3A277A; Thu, 12 Mar 2020 22:51:46 +0000 (UTC) Received: from EX13D01UWB001.ant.amazon.com (10.43.161.75) by EX13MTAUWB001.ant.amazon.com (10.43.161.207) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 12 Mar 2020 22:51:46 +0000 Received: from EX13D01UWB002.ant.amazon.com (10.43.161.136) by EX13d01UWB001.ant.amazon.com (10.43.161.75) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 12 Mar 2020 22:51:45 +0000 Received: from EX13D01UWB002.ant.amazon.com ([10.43.161.136]) by EX13d01UWB002.ant.amazon.com ([10.43.161.136]) with mapi id 15.00.1497.006; Thu, 12 Mar 2020 22:51:45 +0000 From: "Singh, Balbir" To: "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "axboe@kernel.dk" CC: "hch@lst.de" , "Chaitanya.Kulkarni@wdc.com" , "jejb@linux.ibm.com" , "mst@redhat.com" Subject: Re: [PATCH v2 0/5] Add support for block disk resize notification Thread-Topic: [PATCH v2 0/5] Add support for block disk resize notification Thread-Index: AQHV+MDObGy8ubWnEEm2OFraTMxGPw== Date: Thu, 12 Mar 2020 22:51:45 +0000 Message-ID: <3c43712ebbd3d4e5c301677a17ec7a301487faa4.camel@amazon.com> References: <20200225200129.6687-1-sblbir@amazon.com> <05bb1606-4cf1-dba3-22a0-5f8624b43767@kernel.dk> In-Reply-To: <05bb1606-4cf1-dba3-22a0-5f8624b43767@kernel.dk> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.162.115] Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org T24gVGh1LCAyMDIwLTAzLTEyIGF0IDA4OjA2IC0wNjAwLCBKZW5zIEF4Ym9lIHdyb3RlOg0KPiAN Cj4gT24gMy8yLzIwIDk6MDMgUE0sIFNpbmdoLCBCYWxiaXIgd3JvdGU6DQo+ID4gT24gVHVlLCAy MDIwLTAyLTI1IGF0IDIwOjAxICswMDAwLCBCYWxiaXIgU2luZ2ggd3JvdGU6DQo+ID4gPiBBbGxv dyBibG9jay9nZW5oZCB0byBub3RpZnkgdXNlciBzcGFjZSBhYm91dCBkaXNrIHNpemUgY2hhbmdl cyB1c2luZyBhDQo+ID4gPiBuZXcgaGVscGVyIHNldF9jYXBhY2l0eV9yZXZhbGlkYXRlX2FuZF9u b3RpZnkoKSwgd2hpY2ggaXMgYSB3cmFwcGVyDQo+ID4gPiBvbiB0b3Agb2Ygc2V0X2NhcGFjaXR5 KCkuIHNldF9jYXBhY2l0eV9yZXZhbGlkYXRlX2FuZF9ub3RpZnkoKSB3aWxsIG9ubHkNCj4gPiA+ IG5vdGlmeQ0KPiA+ID4gaWZmIHRoZSBjdXJyZW50IGNhcGFjaXR5IG9yIHRoZSB0YXJnZXQgY2Fw YWNpdHkgaXMgbm90IHplcm8gYW5kIHRoZQ0KPiA+ID4gY2FwYWNpdHkgcmVhbGx5IGNoYW5nZXMu DQo+ID4gPiANCj4gPiA+IEJhY2tncm91bmQ6DQo+ID4gPiANCj4gPiA+IEFzIGEgcGFydCBvZiBh IHBhdGNoIHRvIGFsbG93IHNlbmRpbmcgdGhlIFJFU0laRSBldmVudCBvbiBkaXNrIGNhcGFjaXR5 DQo+ID4gPiBjaGFuZ2UsIENocmlzdG9waCAoaGNoQGxzdC5kZSkgcmVxdWVzdGVkIHRoYXQgdGhl IHBhdGNoIGJlIG1hZGUgZ2VuZXJpYw0KPiA+ID4gYW5kIHRoZSBoYWNrcyBmb3IgdmlydGlvIGJs b2NrIGFuZCB4ZW4gYmxvY2sgZGV2aWNlcyBiZSByZW1vdmVkIGFuZA0KPiA+ID4gbWVyZ2VkIHZp YSBhIGdlbmVyaWMgaGVscGVyLg0KPiA+ID4gDQo+ID4gPiBUaGlzIHNlcmllcyBjb25zaXN0cyBv ZiA1IGNoYW5nZXMuIFRoZSBmaXJzdCBvbmUgYWRkcyB0aGUgYmFzaWMNCj4gPiA+IHN1cHBvcnQg Zm9yIGNoYW5naW5nIHRoZSBzaXplIGFuZCBub3RpZnlpbmcuIFRoZSBmb2xsb3cgdXAgcGF0Y2hl cw0KPiA+ID4gYXJlIHBlciBibG9jayBzdWJzeXN0ZW0gY2hhbmdlcy4gT3RoZXIgYmxvY2sgZHJp dmVycyBjYW4gYWRkIHRoZWlyDQo+ID4gPiBjaGFuZ2VzIGFzIG5lY2Vzc2FyeSBvbiB0b3Agb2Yg dGhpcyBzZXJpZXMuIFNpbmNlIG5vdCBhbGwgZGV2aWNlcw0KPiA+ID4gYXJlIHJlc2l6YWJsZSwg dGhlIGRlZmF1bHQgd2FzIHRvIGFkZCBhIG5ldyBBUEkgYW5kIGxldCB1c2Vycw0KPiA+ID4gc2xv d2x5IGNvbnZlcnQgb3ZlciBhcyBuZWVkZWQuDQo+ID4gPiANCj4gPiA+IFRlc3Rpbmc6DQo+ID4g PiAxLiBJIGRpZCBzb21lIGJhc2ljIHRlc3Rpbmcgd2l0aCBhbiBOVk1FIGRldmljZSwgYnkgcmVz aXppbmcgaXQgaW4NCj4gPiA+IHRoZSBiYWNrZW5kIGFuZCBlbnN1cmVkIHRoYXQgdWRldmQgcmVj ZWl2ZWQgdGhlIGV2ZW50Lg0KPiA+ID4gDQo+ID4gPiANCj4gPiA+IENoYW5nZWxvZyB2MjoNCj4g PiA+IC0gUmVuYW1lIGRpc2tfc2V0X2NhcGFjaXR5IHRvIHNldF9jYXBhY2l0eV9yZXZhbGlkYXRl X2FuZF9ub3RpZnkNCj4gPiA+IC0gc2V0X2NhcGFjaXR5X3JldmFsaWRhdGVfYW5kX25vdGlmeSBj YW4gY2FsbCByZXZhbGlkYXRlIGRpc2sNCj4gPiA+ICAgaWYgbmVlZGVkLCBhIG5ldyBib29sIHBh cmFtZXRlciBpcyBwYXNzZWQgKHN1Z2dlc3RlZCBieSBCb2IgTGl1KQ0KPiA+ID4gDQo+ID4gDQo+ ID4gUGluZz8gSXQncyBub3QgYW4gdXJnZW50IHBhdGNoc2V0LCBJIGFtIGhhcHB5IHRvIHdhaXQg aWYgbm90aGluZyBlbHNlIGlzDQo+ID4gbmVlZGVkLg0KPiANCj4gSXQgZG9lc24ndCBhcHBseSB0 byB0aGUgNS43IGJyYW5jaGVzLCBjYW4geW91IHJlc2VuZCBhZ2FpbnN0IGZvci01LjcvYmxvY2s/ DQo+IA0KDQpUaGFua3MsIEknbGwgdGFrZSBhIGxvb2suIEkgdXNlZCB0aGUgbGF0ZXN0IG5leHQg KG5leHQtMjAyMDAzMTIpIGFuZCByZWJhc2VkDQpvbiBpdC4gSSBnb3QgYSB0aHJlZSB3YXkgbWVy Z2Ugc3VjY2VzcyBvbiB4ZW4tYmxrZnJvbnQNCg0KVXNpbmcgaW5kZXggaW5mbyB0byByZWNvbnN0 cnVjdCBhIGJhc2UgdHJlZS4uLg0KTSAgICAgICBkcml2ZXJzL2Jsb2NrL3hlbi1ibGtmcm9udC5j DQpGYWxsaW5nIGJhY2sgdG8gcGF0Y2hpbmcgYmFzZSBhbmQgMy13YXkgbWVyZ2UuLi4NCg0KSSBw cmVzdW1lIHlvdSBhcmUgcnVubmluZyBpbnRvIHRoZSBzYW1lIHRoaW5nLg0KDQpJIHdpbGwgcmVz ZW5kIHRoZSBwYXRjaGVzIG9uIHRvcCBvZiBuZXh0IHNob3J0bHkNCg0KQmFsYmlyDQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_ADSP_ALL, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A532C2BB1D for ; Thu, 12 Mar 2020 22:51:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1C3B206CD for ; Thu, 12 Mar 2020 22:51:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CoL3wqNq"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="XgHhBMIC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1C3B206CD Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Udz8RFtLrnUo/Ty2sn959soZktc6igBWAWFJlWE2xN8=; b=CoL3wqNqqyTGLz AkarsNVgivEl6ustD167NYLqguH13KKqD+Fm5ozzPk5BB72RQu/vwsa91eIplXPeT5B64vFlqMtQC dQgTZExKxH6JbZpk3Sx3rkLZRNd6Ib07IQhnRhUx1V/a4avgG9spu6dw+mzfoMwDP8xrVbCqqjjmR /Vy6jQ08AogFbpSl+HkS/kqyxBv0HCf6TM/gLaWoiFlqrKN4f8Ij4BsRaAkH5bmjSHsMtYt5zDAFr MqJQUpoez1VVK7Qh2wywxJ8yULVxYZG6Uf0zOar0yhPYYqxEj2i18qlD0rsx7RQl9bV2asewA89vD J5Oa7qxFCcu+lOOWrUug==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCWgH-0006Fu-DL; Thu, 12 Mar 2020 22:51:57 +0000 Received: from smtp-fw-9101.amazon.com ([207.171.184.25]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCWgF-0006Eq-Hu for linux-nvme@lists.infradead.org; Thu, 12 Mar 2020 22:51:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1584053516; x=1615589516; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=APmuTEj00jSwH9UdKFoz86SYSwY6N2q5esvdw5Bdl+o=; b=XgHhBMIC3QeKYb9psHYTKUdgpHTaPoIb0cnbh08ZQHnx1K1+z5QZwU93 JCIZvlwHut8BGW/4tKJdZaY4Ncoi5dB+CeBBN6Yr0Pn1gH3LWFERD8s9v xowtHEvCx391qrpuOqL4TAkxEd69qFXON9JISoyOqzNgsk8xm8fiUyn1e 8=; IronPort-SDR: ugjucCAlacrlOlBoX7R+p/ruO8wypS9aieV7ZL/kdFBMiPo3e2F7WuMI4vhcZCTvJ8GlrtvpiT e4ImMoCq71Cg== X-IronPort-AV: E=Sophos;i="5.70,546,1574121600"; d="scan'208";a="22562882" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-1e-303d0b0e.us-east-1.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-9101.sea19.amazon.com with ESMTP; 12 Mar 2020 22:51:50 +0000 Received: from EX13MTAUWB001.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan3.iad.amazon.com [10.40.159.166]) by email-inbound-relay-1e-303d0b0e.us-east-1.amazon.com (Postfix) with ESMTPS id C14F3A277A; Thu, 12 Mar 2020 22:51:46 +0000 (UTC) Received: from EX13D01UWB001.ant.amazon.com (10.43.161.75) by EX13MTAUWB001.ant.amazon.com (10.43.161.207) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 12 Mar 2020 22:51:46 +0000 Received: from EX13D01UWB002.ant.amazon.com (10.43.161.136) by EX13d01UWB001.ant.amazon.com (10.43.161.75) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 12 Mar 2020 22:51:45 +0000 Received: from EX13D01UWB002.ant.amazon.com ([10.43.161.136]) by EX13d01UWB002.ant.amazon.com ([10.43.161.136]) with mapi id 15.00.1497.006; Thu, 12 Mar 2020 22:51:45 +0000 From: "Singh, Balbir" To: "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "axboe@kernel.dk" Subject: Re: [PATCH v2 0/5] Add support for block disk resize notification Thread-Topic: [PATCH v2 0/5] Add support for block disk resize notification Thread-Index: AQHV+MDObGy8ubWnEEm2OFraTMxGPw== Date: Thu, 12 Mar 2020 22:51:45 +0000 Message-ID: <3c43712ebbd3d4e5c301677a17ec7a301487faa4.camel@amazon.com> References: <20200225200129.6687-1-sblbir@amazon.com> <05bb1606-4cf1-dba3-22a0-5f8624b43767@kernel.dk> In-Reply-To: <05bb1606-4cf1-dba3-22a0-5f8624b43767@kernel.dk> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.162.115] Content-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200312_155155_634455_69F54E2C X-CRM114-Status: GOOD ( 23.31 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "jejb@linux.ibm.com" , "hch@lst.de" , "Chaitanya.Kulkarni@wdc.com" , "mst@redhat.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, 2020-03-12 at 08:06 -0600, Jens Axboe wrote: > > On 3/2/20 9:03 PM, Singh, Balbir wrote: > > On Tue, 2020-02-25 at 20:01 +0000, Balbir Singh wrote: > > > Allow block/genhd to notify user space about disk size changes using a > > > new helper set_capacity_revalidate_and_notify(), which is a wrapper > > > on top of set_capacity(). set_capacity_revalidate_and_notify() will only > > > notify > > > iff the current capacity or the target capacity is not zero and the > > > capacity really changes. > > > > > > Background: > > > > > > As a part of a patch to allow sending the RESIZE event on disk capacity > > > change, Christoph (hch@lst.de) requested that the patch be made generic > > > and the hacks for virtio block and xen block devices be removed and > > > merged via a generic helper. > > > > > > This series consists of 5 changes. The first one adds the basic > > > support for changing the size and notifying. The follow up patches > > > are per block subsystem changes. Other block drivers can add their > > > changes as necessary on top of this series. Since not all devices > > > are resizable, the default was to add a new API and let users > > > slowly convert over as needed. > > > > > > Testing: > > > 1. I did some basic testing with an NVME device, by resizing it in > > > the backend and ensured that udevd received the event. > > > > > > > > > Changelog v2: > > > - Rename disk_set_capacity to set_capacity_revalidate_and_notify > > > - set_capacity_revalidate_and_notify can call revalidate disk > > > if needed, a new bool parameter is passed (suggested by Bob Liu) > > > > > > > Ping? It's not an urgent patchset, I am happy to wait if nothing else is > > needed. > > It doesn't apply to the 5.7 branches, can you resend against for-5.7/block? > Thanks, I'll take a look. I used the latest next (next-20200312) and rebased on it. I got a three way merge success on xen-blkfront Using index info to reconstruct a base tree... M drivers/block/xen-blkfront.c Falling back to patching base and 3-way merge... I presume you are running into the same thing. I will resend the patches on top of next shortly Balbir _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme