From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 473BDC61DA4 for ; Sat, 18 Mar 2023 17:46:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230030AbjCRRq2 (ORCPT ); Sat, 18 Mar 2023 13:46:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229886AbjCRRq0 (ORCPT ); Sat, 18 Mar 2023 13:46:26 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7294B25957 for ; Sat, 18 Mar 2023 10:46:25 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id g18so5099009wmk.0 for ; Sat, 18 Mar 2023 10:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679161584; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jN4mwQJK9fgKVvZv47WjlhMEzt/KoX94uhMPM+Y9DlA=; b=oIfRvfgZyNkDWjeZHLg1Equ47Ga+HSCzg0fblb86EPcQq0XL80IhCMhjcZzpsGv8wB L+YFdRa+prK+BpESnLLSIgcl8OGDCtTTLclL6XdmgN2hGA30eUs9HUjJv8oz4WpjBO9v fQ0aWOKbbxlXwD5h1f+6nXRJucKhpPfOvLZY1fBMZ2TE2Ebu9U2wjMAYeGneR747vE26 UtR8ahq05Aet1Skm3kgzufEh6ZTxJP6juxIZU2sNIsBYoGI3d0KFZdSGlj98f8oqhAyF m6uvBMQ/UfofqPt3miR5jgWwWNPGfoQqEm6nZj3V65SS3LoSdC3waOJWVHFwQbxz1cSz zvJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679161584; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jN4mwQJK9fgKVvZv47WjlhMEzt/KoX94uhMPM+Y9DlA=; b=vlGpSCzwfuT9FWVbeT3dMBQn8ylAxiBAF/OHFDSaYhHhp1eN7mAr7vjfaAGQgebw2V VV0/IiHHszgkyYEKW0BFH7tjdjoDLEVA7AaF4gSQTVZ/GRRrQhHwvxD3PWpMyifTrrOj og9Flvd0F3VmspwSEIc66GMjkxT2C5GzyhASuENbn7aeZl/jg/Fq+JTwMXnp4J7x3c2l Ck6O1VEEn5gHJywv5ARMlOuDeCOvYtTrGqI2gYFkoxYH6XOsDLQGXR17OE9eoIln6Ems /mgUh24l/hBgoa1gY5SN/+7WIYAR1fVzQ2P8UaQAMPSYL+YKjBv0SZ++nbU9rtGduAy1 AKzA== X-Gm-Message-State: AO0yUKU938HL5cmDM4X0m/OjBDxUl+lc3ILMzbWIS5roqaodh4myyhyO FZkoLkGJv4TdcxmL/y2DXfjZCw== X-Google-Smtp-Source: AK7set+vfT4pr/nMnXehtADBF2zgRujwgpJ2UK9FWHSQN29ogeql1dwskTkujmjvzlt4xNOXGmeGiA== X-Received: by 2002:a05:600c:2185:b0:3ed:8780:f27b with SMTP id e5-20020a05600c218500b003ed8780f27bmr5401853wme.16.1679161583967; Sat, 18 Mar 2023 10:46:23 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id u17-20020a05600c19d100b003e204fdb160sm11785131wmq.3.2023.03.18.10.46.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Mar 2023 10:46:23 -0700 (PDT) Message-ID: <3c63ccd5-3320-afdc-2620-aadc77faef35@linaro.org> Date: Sat, 18 Mar 2023 17:46:22 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 17/18] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM usb-role-switching for usb_1 Content-Language: en-US To: Konrad Dybcio , linux@roeck-us.net, heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Cc: wcheng@codeaurora.org, caleb.connolly@linaro.org, subbaram@quicinc.com, jackp@quicinc.com, robertom@qti.qualcomm.com References: <20230318121828.739424-1-bryan.odonoghue@linaro.org> <20230318121828.739424-18-bryan.odonoghue@linaro.org> <6e897b77-671b-2049-4327-631350e8f868@linaro.org> From: Bryan O'Donoghue In-Reply-To: <6e897b77-671b-2049-4327-631350e8f868@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 18/03/2023 13:10, Konrad Dybcio wrote: >> + usb-role-switch; > This could maybe go to the SoC DTSI.. Bjorn, Krzysztof, WDYT? Eh well I think this is a correct comment. There's no good reason to have this as board-specific since it is a controller property. Moreover it only does something when there is a an agent to feed data into it. arch/arm64/boot/dts/qcom/sc7280.dtsi: usb-role-switch; --- bod