From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C996C433DB for ; Wed, 23 Dec 2020 20:48:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5AF502246B for ; Wed, 23 Dec 2020 20:48:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728184AbgLWUs4 (ORCPT ); Wed, 23 Dec 2020 15:48:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727008AbgLWUsz (ORCPT ); Wed, 23 Dec 2020 15:48:55 -0500 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07D52C061794; Wed, 23 Dec 2020 12:48:15 -0800 (PST) Received: by mail-lf1-x133.google.com with SMTP id y19so264107lfa.13; Wed, 23 Dec 2020 12:48:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XAOZFX5PmO3BnjJ+pCRmO9VP1XkSYch3y2iUGGqB3o8=; b=Hkvv+mPSRToI5mHA8J6YUX4CFXMXssDIGtVj6ay0ksThjJWupHF+KIutY8dH4sL7ed du7+7yoSg/YOCXgiTfEyg4CyB2NpnVsLGJ89dV9SqoWOqPUSKFl+2NZOIeKzMxyTNXs6 pvuhxNC+RAkVqtQKrSVHWh94rQCm6AEAARMEmMKIyG0Cczj8D1kgdOX+ldMR9yzqHekC yDjSgnsDvou5/c8J+cRX0bs8foGprzKYHTXElxVD89Q6W5OlGffGLeI2A5ZfRV+Jo9KY pbKavgg6wX3W4BZM+XSfnGSMohsNPFg6mW2yFVUGZi/CUBKgPDlW8uQkMqeBWYVO60Tr 617g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XAOZFX5PmO3BnjJ+pCRmO9VP1XkSYch3y2iUGGqB3o8=; b=opHhOoBo6o1iBkav+nH8tcemcb/Zx0j2dojejo2H+WTXqdXRbf8pzXh0+7LmgGaMXr GXiuvVziVskZw2caR0nG6D1vjI/EKysfroZdjysu+iGSzd4DbMd/fq8Q5XERXGKBbPXP c0SY+GvEugGU7mCo888BrlGzauCPU+tcbgbHQZ2JxtGgsU8FNEbwCZE1jBPKiheXqoZc H3Sxkv4owq1jK5i9nr9ThkkpY9looqLoea80v0LXngQEab/zmwnLN+tuENuws4QjBHol 4HWGwVnEkJxwarH24EudL11g32DA/oPygC2U+FtYy0EfcsovCSb8B95+mS0+rVTaT15a bVXQ== X-Gm-Message-State: AOAM531L8s4WaTBAarwdtNuNHlnxQZq7IXa8qIhS+/VoIAo2Axu9zC5b 7Wrlmx8SHlRqFsO/zvCoEi/vky6/liw= X-Google-Smtp-Source: ABdhPJzjYrLYkWsalFBLSailKegbFX3ZOqy7cBTjqEzJ0UJwKuOkOkF6TKPSPxQv5z+pj73dmBDjnA== X-Received: by 2002:a2e:9053:: with SMTP id n19mr10022964ljg.283.1608756493408; Wed, 23 Dec 2020 12:48:13 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id n8sm3351553lfi.48.2020.12.23.12.48.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Dec 2020 12:48:12 -0800 (PST) Subject: Re: [PATCH v2 14/48] opp: Filter out OPPs based on availability of a required-OPP To: Viresh Kumar Cc: Thierry Reding , Jonathan Hunter , Mark Brown , Liam Girdwood , Ulf Hansson , Mauro Carvalho Chehab , Rob Herring , Peter Geis , Nicolas Chauvet , Krzysztof Kozlowski , "Rafael J. Wysocki" , Kevin Hilman , Peter De Schrijver , Viresh Kumar , Stephen Boyd , Michael Turquette , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org References: <20201217180638.22748-1-digetx@gmail.com> <20201217180638.22748-15-digetx@gmail.com> <20201222085940.y625zxee4tevbqm5@vireshk-i7> <9ed8bde3-f7b5-025c-c038-87f35ea39e5f@gmail.com> <20201223042200.ey2azaqizazrz6bp@vireshk-i7> From: Dmitry Osipenko Message-ID: <3c6a1e43-02c7-30d3-3aee-fde1dbf76472@gmail.com> Date: Wed, 23 Dec 2020 23:48:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <20201223042200.ey2azaqizazrz6bp@vireshk-i7> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 23.12.2020 07:22, Viresh Kumar пишет: > On 22-12-20, 22:17, Dmitry Osipenko wrote: >> 22.12.2020 11:59, Viresh Kumar пишет: >>> On 17-12-20, 21:06, Dmitry Osipenko wrote: >>>> A required OPP may not be available, and thus, all OPPs which are using >>>> this required OPP should be unavailable too. >>>> >>>> Signed-off-by: Dmitry Osipenko >>>> --- >>>> drivers/opp/core.c | 11 ++++++++++- >>>> 1 file changed, 10 insertions(+), 1 deletion(-) >>> >>> Please send a separate patchset for fixes, as these can also go to 5.11 itself. >> >> Alright, although I don't think that this patch fixes any problems for >> existing OPP users. > > Because nobody is using this feature, but otherwise this is a fix for me. > >>>> diff --git a/drivers/opp/core.c b/drivers/opp/core.c >>>> index d9feb7639598..3d02fe33630b 100644 >>>> --- a/drivers/opp/core.c >>>> +++ b/drivers/opp/core.c >>>> @@ -1588,7 +1588,7 @@ int _opp_add(struct device *dev, struct dev_pm_opp *new_opp, >>>> struct opp_table *opp_table, bool rate_not_available) >>>> { >>>> struct list_head *head; >>>> - int ret; >>>> + int i, ret; >>>> >>>> mutex_lock(&opp_table->lock); >>>> head = &opp_table->opp_list; >>>> @@ -1615,6 +1615,15 @@ int _opp_add(struct device *dev, struct dev_pm_opp *new_opp, >>>> __func__, new_opp->rate); >>>> } >>>> >>>> + for (i = 0; i < opp_table->required_opp_count && new_opp->available; i++) { >>>> + if (new_opp->required_opps[i]->available) >>>> + continue; >>>> + >>>> + new_opp->available = false; >>>> + dev_warn(dev, "%s: OPP not supported by required OPP %pOF (%lu)\n", >>>> + __func__, new_opp->required_opps[i]->np, new_opp->rate); >>> >>> Why not just break from here ? >> >> The new_opp could be already marked as unavailable by a previous voltage >> check, hence this loop should be skipped entirely in that case. > > Then add a separate check for that before the loop as we don't need that check > on every iteration here. > Perhaps the break will be a better option in this case, since it won't hurt at all to print the additional message even if OPP was already disabled by another check. I'll update it in next revision, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5979BC433DB for ; Wed, 23 Dec 2020 20:48:20 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 001DA22283 for ; Wed, 23 Dec 2020 20:48:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 001DA22283 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id AA2018734B; Wed, 23 Dec 2020 20:48:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hqDQ3DhrgE4z; Wed, 23 Dec 2020 20:48:18 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id AD02F872FD; Wed, 23 Dec 2020 20:48:18 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id B4FCF1BF86B for ; Wed, 23 Dec 2020 20:48:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id A987385FA5 for ; Wed, 23 Dec 2020 20:48:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SPVCObDwJb6h for ; Wed, 23 Dec 2020 20:48:15 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 3073885F83 for ; Wed, 23 Dec 2020 20:48:15 +0000 (UTC) Received: by mail-lf1-f48.google.com with SMTP id h205so363497lfd.5 for ; Wed, 23 Dec 2020 12:48:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XAOZFX5PmO3BnjJ+pCRmO9VP1XkSYch3y2iUGGqB3o8=; b=Hkvv+mPSRToI5mHA8J6YUX4CFXMXssDIGtVj6ay0ksThjJWupHF+KIutY8dH4sL7ed du7+7yoSg/YOCXgiTfEyg4CyB2NpnVsLGJ89dV9SqoWOqPUSKFl+2NZOIeKzMxyTNXs6 pvuhxNC+RAkVqtQKrSVHWh94rQCm6AEAARMEmMKIyG0Cczj8D1kgdOX+ldMR9yzqHekC yDjSgnsDvou5/c8J+cRX0bs8foGprzKYHTXElxVD89Q6W5OlGffGLeI2A5ZfRV+Jo9KY pbKavgg6wX3W4BZM+XSfnGSMohsNPFg6mW2yFVUGZi/CUBKgPDlW8uQkMqeBWYVO60Tr 617g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XAOZFX5PmO3BnjJ+pCRmO9VP1XkSYch3y2iUGGqB3o8=; b=nE+OxKorQsiOzLjl+JrBwTylcd1/q9PU7SnrUHYGftUU/a68P8CjBEAl7KQc7ELCcC sYzUK7yzlVywoVf1BZUflTcqSMb/ua3Kr+jlv4EfXK6CjH3sY/1RjtwNnSjPf2D72EcA SpyJqts253sF0GcX8EyX6lFbSaiGcRJJ2VgAWhaYV2HBYOgbGFxJt7Hil0E9n15jIWdZ 0zWw20WHj1kirGOr2C0recjjD9hRoY5zERrlelbjEaW1KCixD0w7iNi3Vjw1e0PiIUaj D93JcCBH6jg4tS+5xqP3i+9reDDJYhyyfnbRXVx7EGahnPTyk3GIZ8fD7W1M4/OPzao9 i4vw== X-Gm-Message-State: AOAM5334B1zneIJTx9U7/FzDmtVyyP/MIYfe3mhjyzkT6RySGLdPQjZh agivCRm+wpXNylykVfX7v/s= X-Google-Smtp-Source: ABdhPJzjYrLYkWsalFBLSailKegbFX3ZOqy7cBTjqEzJ0UJwKuOkOkF6TKPSPxQv5z+pj73dmBDjnA== X-Received: by 2002:a2e:9053:: with SMTP id n19mr10022964ljg.283.1608756493408; Wed, 23 Dec 2020 12:48:13 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id n8sm3351553lfi.48.2020.12.23.12.48.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Dec 2020 12:48:12 -0800 (PST) Subject: Re: [PATCH v2 14/48] opp: Filter out OPPs based on availability of a required-OPP To: Viresh Kumar References: <20201217180638.22748-1-digetx@gmail.com> <20201217180638.22748-15-digetx@gmail.com> <20201222085940.y625zxee4tevbqm5@vireshk-i7> <9ed8bde3-f7b5-025c-c038-87f35ea39e5f@gmail.com> <20201223042200.ey2azaqizazrz6bp@vireshk-i7> From: Dmitry Osipenko Message-ID: <3c6a1e43-02c7-30d3-3aee-fde1dbf76472@gmail.com> Date: Wed, 23 Dec 2020 23:48:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <20201223042200.ey2azaqizazrz6bp@vireshk-i7> Content-Language: en-US X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Michael Turquette , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thierry Reding , linux-clk@vger.kernel.org, devel@driverdev.osuosl.org, Kevin Hilman , Nicolas Chauvet , Viresh Kumar , Krzysztof Kozlowski , Jonathan Hunter , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , linux-tegra@vger.kernel.org, Mauro Carvalho Chehab , Stephen Boyd , Peter De Schrijver , "Rafael J. Wysocki" , Liam Girdwood , Mark Brown , Peter Geis Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" MjMuMTIuMjAyMCAwNzoyMiwgVmlyZXNoIEt1bWFyINC/0LjRiNC10YI6Cj4gT24gMjItMTItMjAs IDIyOjE3LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4+IDIyLjEyLjIwMjAgMTE6NTksIFZpcmVz aCBLdW1hciDQv9C40YjQtdGCOgo+Pj4gT24gMTctMTItMjAsIDIxOjA2LCBEbWl0cnkgT3NpcGVu a28gd3JvdGU6Cj4+Pj4gQSByZXF1aXJlZCBPUFAgbWF5IG5vdCBiZSBhdmFpbGFibGUsIGFuZCB0 aHVzLCBhbGwgT1BQcyB3aGljaCBhcmUgdXNpbmcKPj4+PiB0aGlzIHJlcXVpcmVkIE9QUCBzaG91 bGQgYmUgdW5hdmFpbGFibGUgdG9vLgo+Pj4+Cj4+Pj4gU2lnbmVkLW9mZi1ieTogRG1pdHJ5IE9z aXBlbmtvIDxkaWdldHhAZ21haWwuY29tPgo+Pj4+IC0tLQo+Pj4+ICBkcml2ZXJzL29wcC9jb3Jl LmMgfCAxMSArKysrKysrKysrLQo+Pj4+ICAxIGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbigtKQo+Pj4KPj4+IFBsZWFzZSBzZW5kIGEgc2VwYXJhdGUgcGF0Y2hzZXQg Zm9yIGZpeGVzLCBhcyB0aGVzZSBjYW4gYWxzbyBnbyB0byA1LjExIGl0c2VsZi4KPj4KPj4gQWxy aWdodCwgYWx0aG91Z2ggSSBkb24ndCB0aGluayB0aGF0IHRoaXMgcGF0Y2ggZml4ZXMgYW55IHBy b2JsZW1zIGZvcgo+PiBleGlzdGluZyBPUFAgdXNlcnMuCj4gCj4gQmVjYXVzZSBub2JvZHkgaXMg dXNpbmcgdGhpcyBmZWF0dXJlLCBidXQgb3RoZXJ3aXNlIHRoaXMgaXMgYSBmaXggZm9yIG1lLgo+ IAo+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL29wcC9jb3JlLmMgYi9kcml2ZXJzL29wcC9jb3Jl LmMKPj4+PiBpbmRleCBkOWZlYjc2Mzk1OTguLjNkMDJmZTMzNjMwYiAxMDA2NDQKPj4+PiAtLS0g YS9kcml2ZXJzL29wcC9jb3JlLmMKPj4+PiArKysgYi9kcml2ZXJzL29wcC9jb3JlLmMKPj4+PiBA QCAtMTU4OCw3ICsxNTg4LDcgQEAgaW50IF9vcHBfYWRkKHN0cnVjdCBkZXZpY2UgKmRldiwgc3Ry dWN0IGRldl9wbV9vcHAgKm5ld19vcHAsCj4+Pj4gIAkgICAgIHN0cnVjdCBvcHBfdGFibGUgKm9w cF90YWJsZSwgYm9vbCByYXRlX25vdF9hdmFpbGFibGUpCj4+Pj4gIHsKPj4+PiAgCXN0cnVjdCBs aXN0X2hlYWQgKmhlYWQ7Cj4+Pj4gLQlpbnQgcmV0Owo+Pj4+ICsJaW50IGksIHJldDsKPj4+PiAg Cj4+Pj4gIAltdXRleF9sb2NrKCZvcHBfdGFibGUtPmxvY2spOwo+Pj4+ICAJaGVhZCA9ICZvcHBf dGFibGUtPm9wcF9saXN0Owo+Pj4+IEBAIC0xNjE1LDYgKzE2MTUsMTUgQEAgaW50IF9vcHBfYWRk KHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRldl9wbV9vcHAgKm5ld19vcHAsCj4+Pj4gIAkJ CSBfX2Z1bmNfXywgbmV3X29wcC0+cmF0ZSk7Cj4+Pj4gIAl9Cj4+Pj4gIAo+Pj4+ICsJZm9yIChp ID0gMDsgaSA8IG9wcF90YWJsZS0+cmVxdWlyZWRfb3BwX2NvdW50ICYmIG5ld19vcHAtPmF2YWls YWJsZTsgaSsrKSB7Cj4+Pj4gKwkJaWYgKG5ld19vcHAtPnJlcXVpcmVkX29wcHNbaV0tPmF2YWls YWJsZSkKPj4+PiArCQkJY29udGludWU7Cj4+Pj4gKwo+Pj4+ICsJCW5ld19vcHAtPmF2YWlsYWJs ZSA9IGZhbHNlOwo+Pj4+ICsJCWRldl93YXJuKGRldiwgIiVzOiBPUFAgbm90IHN1cHBvcnRlZCBi eSByZXF1aXJlZCBPUFAgJXBPRiAoJWx1KVxuIiwKPj4+PiArCQkJIF9fZnVuY19fLCBuZXdfb3Bw LT5yZXF1aXJlZF9vcHBzW2ldLT5ucCwgbmV3X29wcC0+cmF0ZSk7Cj4+Pgo+Pj4gV2h5IG5vdCBq dXN0IGJyZWFrIGZyb20gaGVyZSA/Cj4+Cj4+IFRoZSBuZXdfb3BwIGNvdWxkIGJlIGFscmVhZHkg bWFya2VkIGFzIHVuYXZhaWxhYmxlIGJ5IGEgcHJldmlvdXMgdm9sdGFnZQo+PiBjaGVjaywgaGVu Y2UgdGhpcyBsb29wIHNob3VsZCBiZSBza2lwcGVkIGVudGlyZWx5IGluIHRoYXQgY2FzZS4KPiAK PiBUaGVuIGFkZCBhIHNlcGFyYXRlIGNoZWNrIGZvciB0aGF0IGJlZm9yZSB0aGUgbG9vcCBhcyB3 ZSBkb24ndCBuZWVkIHRoYXQgY2hlY2sKPiBvbiBldmVyeSBpdGVyYXRpb24gaGVyZS4KPiAKClBl cmhhcHMgdGhlIGJyZWFrIHdpbGwgYmUgYSBiZXR0ZXIgb3B0aW9uIGluIHRoaXMgY2FzZSwgc2lu Y2UgaXQgd29uJ3QKaHVydCBhdCBhbGwgdG8gcHJpbnQgdGhlIGFkZGl0aW9uYWwgbWVzc2FnZSBl dmVuIGlmIE9QUCB3YXMgYWxyZWFkeQpkaXNhYmxlZCBieSBhbm90aGVyIGNoZWNrLiBJJ2xsIHVw ZGF0ZSBpdCBpbiBuZXh0IHJldmlzaW9uLCB0aGFua3MuCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRldmVsIG1haWxpbmcgbGlzdApkZXZlbEBsaW51eGRy aXZlcnByb2plY3Qub3JnCmh0dHA6Ly9kcml2ZXJkZXYubGludXhkcml2ZXJwcm9qZWN0Lm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaXZlcmRldi1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60875C433E0 for ; Fri, 25 Dec 2020 09:42:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2BB51230FF for ; Fri, 25 Dec 2020 09:42:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2BB51230FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C061189B8F; Fri, 25 Dec 2020 09:42:10 +0000 (UTC) Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by gabe.freedesktop.org (Postfix) with ESMTPS id F05776E891 for ; Wed, 23 Dec 2020 20:48:14 +0000 (UTC) Received: by mail-lf1-x12c.google.com with SMTP id o17so373739lfg.4 for ; Wed, 23 Dec 2020 12:48:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XAOZFX5PmO3BnjJ+pCRmO9VP1XkSYch3y2iUGGqB3o8=; b=Hkvv+mPSRToI5mHA8J6YUX4CFXMXssDIGtVj6ay0ksThjJWupHF+KIutY8dH4sL7ed du7+7yoSg/YOCXgiTfEyg4CyB2NpnVsLGJ89dV9SqoWOqPUSKFl+2NZOIeKzMxyTNXs6 pvuhxNC+RAkVqtQKrSVHWh94rQCm6AEAARMEmMKIyG0Cczj8D1kgdOX+ldMR9yzqHekC yDjSgnsDvou5/c8J+cRX0bs8foGprzKYHTXElxVD89Q6W5OlGffGLeI2A5ZfRV+Jo9KY pbKavgg6wX3W4BZM+XSfnGSMohsNPFg6mW2yFVUGZi/CUBKgPDlW8uQkMqeBWYVO60Tr 617g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XAOZFX5PmO3BnjJ+pCRmO9VP1XkSYch3y2iUGGqB3o8=; b=OjiAFxAd0NAoFHxwQTH2P0jQwt6fDr/1poC4YNfEr11Om2yax0y7iB+XBd5XcscXlb JfXmkqtvWFTHJ1C7ji+Zo2A3/sutXsz8j02iIcqKZhO4L1dkyy650qEyK+tv9H3B95Qj wP9ruJCgrFzNnBNUKxrMmKI9ka1Z2PExSMEp1ysrrCxUMcd7mBzulnTd9pMnSMBVTHPF LhbJ48Y0dhnTm0/JiUmxQjmQY6M3fQh+5hiPGQCgSFZ9TJ8jOYaK2zM/zlwwcxzjqYgN qGpUsq76fVzrP9uM83FzNyd42iYFS4w2xJ+KS0/AiNLXbfhhiNjdcSXFeG0tdhfZYW/K 2jBg== X-Gm-Message-State: AOAM531awXIXWcUmdQ1k120fnzvNV+gmA2yzLA5kmGvChrb4d9HCQKf5 xL3YCVhCATCrsBaLJo8n4pc= X-Google-Smtp-Source: ABdhPJzjYrLYkWsalFBLSailKegbFX3ZOqy7cBTjqEzJ0UJwKuOkOkF6TKPSPxQv5z+pj73dmBDjnA== X-Received: by 2002:a2e:9053:: with SMTP id n19mr10022964ljg.283.1608756493408; Wed, 23 Dec 2020 12:48:13 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id n8sm3351553lfi.48.2020.12.23.12.48.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Dec 2020 12:48:12 -0800 (PST) Subject: Re: [PATCH v2 14/48] opp: Filter out OPPs based on availability of a required-OPP To: Viresh Kumar References: <20201217180638.22748-1-digetx@gmail.com> <20201217180638.22748-15-digetx@gmail.com> <20201222085940.y625zxee4tevbqm5@vireshk-i7> <9ed8bde3-f7b5-025c-c038-87f35ea39e5f@gmail.com> <20201223042200.ey2azaqizazrz6bp@vireshk-i7> From: Dmitry Osipenko Message-ID: <3c6a1e43-02c7-30d3-3aee-fde1dbf76472@gmail.com> Date: Wed, 23 Dec 2020 23:48:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <20201223042200.ey2azaqizazrz6bp@vireshk-i7> Content-Language: en-US X-Mailman-Approved-At: Fri, 25 Dec 2020 09:42:09 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Michael Turquette , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thierry Reding , linux-clk@vger.kernel.org, devel@driverdev.osuosl.org, Kevin Hilman , Nicolas Chauvet , Viresh Kumar , Krzysztof Kozlowski , Jonathan Hunter , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , linux-tegra@vger.kernel.org, Mauro Carvalho Chehab , Stephen Boyd , Peter De Schrijver , "Rafael J. Wysocki" , Liam Girdwood , Mark Brown , Peter Geis Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" MjMuMTIuMjAyMCAwNzoyMiwgVmlyZXNoIEt1bWFyINC/0LjRiNC10YI6Cj4gT24gMjItMTItMjAs IDIyOjE3LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4+IDIyLjEyLjIwMjAgMTE6NTksIFZpcmVz aCBLdW1hciDQv9C40YjQtdGCOgo+Pj4gT24gMTctMTItMjAsIDIxOjA2LCBEbWl0cnkgT3NpcGVu a28gd3JvdGU6Cj4+Pj4gQSByZXF1aXJlZCBPUFAgbWF5IG5vdCBiZSBhdmFpbGFibGUsIGFuZCB0 aHVzLCBhbGwgT1BQcyB3aGljaCBhcmUgdXNpbmcKPj4+PiB0aGlzIHJlcXVpcmVkIE9QUCBzaG91 bGQgYmUgdW5hdmFpbGFibGUgdG9vLgo+Pj4+Cj4+Pj4gU2lnbmVkLW9mZi1ieTogRG1pdHJ5IE9z aXBlbmtvIDxkaWdldHhAZ21haWwuY29tPgo+Pj4+IC0tLQo+Pj4+ICBkcml2ZXJzL29wcC9jb3Jl LmMgfCAxMSArKysrKysrKysrLQo+Pj4+ICAxIGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbigtKQo+Pj4KPj4+IFBsZWFzZSBzZW5kIGEgc2VwYXJhdGUgcGF0Y2hzZXQg Zm9yIGZpeGVzLCBhcyB0aGVzZSBjYW4gYWxzbyBnbyB0byA1LjExIGl0c2VsZi4KPj4KPj4gQWxy aWdodCwgYWx0aG91Z2ggSSBkb24ndCB0aGluayB0aGF0IHRoaXMgcGF0Y2ggZml4ZXMgYW55IHBy b2JsZW1zIGZvcgo+PiBleGlzdGluZyBPUFAgdXNlcnMuCj4gCj4gQmVjYXVzZSBub2JvZHkgaXMg dXNpbmcgdGhpcyBmZWF0dXJlLCBidXQgb3RoZXJ3aXNlIHRoaXMgaXMgYSBmaXggZm9yIG1lLgo+ IAo+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL29wcC9jb3JlLmMgYi9kcml2ZXJzL29wcC9jb3Jl LmMKPj4+PiBpbmRleCBkOWZlYjc2Mzk1OTguLjNkMDJmZTMzNjMwYiAxMDA2NDQKPj4+PiAtLS0g YS9kcml2ZXJzL29wcC9jb3JlLmMKPj4+PiArKysgYi9kcml2ZXJzL29wcC9jb3JlLmMKPj4+PiBA QCAtMTU4OCw3ICsxNTg4LDcgQEAgaW50IF9vcHBfYWRkKHN0cnVjdCBkZXZpY2UgKmRldiwgc3Ry dWN0IGRldl9wbV9vcHAgKm5ld19vcHAsCj4+Pj4gIAkgICAgIHN0cnVjdCBvcHBfdGFibGUgKm9w cF90YWJsZSwgYm9vbCByYXRlX25vdF9hdmFpbGFibGUpCj4+Pj4gIHsKPj4+PiAgCXN0cnVjdCBs aXN0X2hlYWQgKmhlYWQ7Cj4+Pj4gLQlpbnQgcmV0Owo+Pj4+ICsJaW50IGksIHJldDsKPj4+PiAg Cj4+Pj4gIAltdXRleF9sb2NrKCZvcHBfdGFibGUtPmxvY2spOwo+Pj4+ICAJaGVhZCA9ICZvcHBf dGFibGUtPm9wcF9saXN0Owo+Pj4+IEBAIC0xNjE1LDYgKzE2MTUsMTUgQEAgaW50IF9vcHBfYWRk KHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRldl9wbV9vcHAgKm5ld19vcHAsCj4+Pj4gIAkJ CSBfX2Z1bmNfXywgbmV3X29wcC0+cmF0ZSk7Cj4+Pj4gIAl9Cj4+Pj4gIAo+Pj4+ICsJZm9yIChp ID0gMDsgaSA8IG9wcF90YWJsZS0+cmVxdWlyZWRfb3BwX2NvdW50ICYmIG5ld19vcHAtPmF2YWls YWJsZTsgaSsrKSB7Cj4+Pj4gKwkJaWYgKG5ld19vcHAtPnJlcXVpcmVkX29wcHNbaV0tPmF2YWls YWJsZSkKPj4+PiArCQkJY29udGludWU7Cj4+Pj4gKwo+Pj4+ICsJCW5ld19vcHAtPmF2YWlsYWJs ZSA9IGZhbHNlOwo+Pj4+ICsJCWRldl93YXJuKGRldiwgIiVzOiBPUFAgbm90IHN1cHBvcnRlZCBi eSByZXF1aXJlZCBPUFAgJXBPRiAoJWx1KVxuIiwKPj4+PiArCQkJIF9fZnVuY19fLCBuZXdfb3Bw LT5yZXF1aXJlZF9vcHBzW2ldLT5ucCwgbmV3X29wcC0+cmF0ZSk7Cj4+Pgo+Pj4gV2h5IG5vdCBq dXN0IGJyZWFrIGZyb20gaGVyZSA/Cj4+Cj4+IFRoZSBuZXdfb3BwIGNvdWxkIGJlIGFscmVhZHkg bWFya2VkIGFzIHVuYXZhaWxhYmxlIGJ5IGEgcHJldmlvdXMgdm9sdGFnZQo+PiBjaGVjaywgaGVu Y2UgdGhpcyBsb29wIHNob3VsZCBiZSBza2lwcGVkIGVudGlyZWx5IGluIHRoYXQgY2FzZS4KPiAK PiBUaGVuIGFkZCBhIHNlcGFyYXRlIGNoZWNrIGZvciB0aGF0IGJlZm9yZSB0aGUgbG9vcCBhcyB3 ZSBkb24ndCBuZWVkIHRoYXQgY2hlY2sKPiBvbiBldmVyeSBpdGVyYXRpb24gaGVyZS4KPiAKClBl cmhhcHMgdGhlIGJyZWFrIHdpbGwgYmUgYSBiZXR0ZXIgb3B0aW9uIGluIHRoaXMgY2FzZSwgc2lu Y2UgaXQgd29uJ3QKaHVydCBhdCBhbGwgdG8gcHJpbnQgdGhlIGFkZGl0aW9uYWwgbWVzc2FnZSBl dmVuIGlmIE9QUCB3YXMgYWxyZWFkeQpkaXNhYmxlZCBieSBhbm90aGVyIGNoZWNrLiBJJ2xsIHVw ZGF0ZSBpdCBpbiBuZXh0IHJldmlzaW9uLCB0aGFua3MuCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=