From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: jsnow@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH v2 0/2] mirror: Fix hang (operation waiting for itself/circular dependency)
Date: Thu, 26 Mar 2020 10:53:20 -0500 [thread overview]
Message-ID: <3c799e1c-2a59-eac9-4f13-30d3415b24c7@redhat.com> (raw)
In-Reply-To: <20200326153628.4869-1-kwolf@redhat.com>
On 3/26/20 10:36 AM, Kevin Wolf wrote:
> The recent fix didn't actually fix the whole problem. Operations can't
> only wait for themselves, but we can also end up with circular
> dependencies like two operations waiting for each other to complete.
>
> This reverts the first fix and implements another approach.
>
> v2:
> - Mark active mirror operations as in-flight, too
>
> Kevin Wolf (2):
> Revert "mirror: Don't let an operation wait for itself"
> mirror: Wait only for in-flight operations
Series:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2020-03-26 15:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 15:36 [PATCH v2 0/2] mirror: Fix hang (operation waiting for itself/circular dependency) Kevin Wolf
2020-03-26 15:36 ` [PATCH v2 1/2] Revert "mirror: Don't let an operation wait for itself" Kevin Wolf
2020-03-26 15:36 ` [PATCH v2 2/2] mirror: Wait only for in-flight operations Kevin Wolf
2020-03-26 18:27 ` Max Reitz
2020-03-26 15:53 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c799e1c-2a59-eac9-4f13-30d3415b24c7@redhat.com \
--to=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.