All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Nguyen <tony.nguyen@bt.com>
To: qemu-devel@nongnu.org
Cc: Tony Nguyen <tony.nguyen@bt.com>,
	Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
	Richard Henderson <richard.henderson@linaro.org>,
	Artyom Tarasenko <atar4qemu@gmail.com>
Subject: [Qemu-devel] [PATCH v9 20/20] target/sparc: sun4u Invert Endian TTE bit
Date: Sat, 24 Aug 2019 04:36:58 +1000	[thread overview]
Message-ID: <3c8d5181a584f1b3712d3d8d66801b13cecb4b88.1566466906.git.tony.nguyen@bt.com> (raw)
In-Reply-To: <cover.1566466906.git.tony.nguyen@bt.com>

This bit configures endianness of PCI MMIO devices. It is used by
Solaris and OpenBSD sunhme drivers.

Tested working on OpenBSD.

Unfortunately Solaris 10 had a unrelated keyboard issue blocking
testing... another inch towards Solaris 10 on SPARC64 =)

Signed-off-by: Tony Nguyen <tony.nguyen@bt.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
 target/sparc/cpu.h        | 2 ++
 target/sparc/mmu_helper.c | 8 +++++++-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/target/sparc/cpu.h b/target/sparc/cpu.h
index 694d7139cf..490e14dfcf 100644
--- a/target/sparc/cpu.h
+++ b/target/sparc/cpu.h
@@ -275,6 +275,7 @@ enum {
 
 #define TTE_VALID_BIT       (1ULL << 63)
 #define TTE_NFO_BIT         (1ULL << 60)
+#define TTE_IE_BIT          (1ULL << 59)
 #define TTE_USED_BIT        (1ULL << 41)
 #define TTE_LOCKED_BIT      (1ULL <<  6)
 #define TTE_SIDEEFFECT_BIT  (1ULL <<  3)
@@ -291,6 +292,7 @@ enum {
 
 #define TTE_IS_VALID(tte)   ((tte) & TTE_VALID_BIT)
 #define TTE_IS_NFO(tte)     ((tte) & TTE_NFO_BIT)
+#define TTE_IS_IE(tte)      ((tte) & TTE_IE_BIT)
 #define TTE_IS_USED(tte)    ((tte) & TTE_USED_BIT)
 #define TTE_IS_LOCKED(tte)  ((tte) & TTE_LOCKED_BIT)
 #define TTE_IS_SIDEEFFECT(tte) ((tte) & TTE_SIDEEFFECT_BIT)
diff --git a/target/sparc/mmu_helper.c b/target/sparc/mmu_helper.c
index 826e14b6f0..77dc86ac5c 100644
--- a/target/sparc/mmu_helper.c
+++ b/target/sparc/mmu_helper.c
@@ -537,6 +537,10 @@ static int get_physical_address_data(CPUSPARCState *env, hwaddr *physical,
         if (ultrasparc_tag_match(&env->dtlb[i], address, context, physical)) {
             int do_fault = 0;
 
+            if (TTE_IS_IE(env->dtlb[i].tte)) {
+                attrs->byte_swap = true;
+            }
+
             /* access ok? */
             /* multiple bits in SFSR.FT may be set on TT_DFAULT */
             if (TTE_IS_PRIV(env->dtlb[i].tte) && is_user) {
@@ -792,7 +796,7 @@ void dump_mmu(CPUSPARCState *env)
             }
             if (TTE_IS_VALID(env->dtlb[i].tte)) {
                 qemu_printf("[%02u] VA: %" PRIx64 ", PA: %llx"
-                            ", %s, %s, %s, %s, ctx %" PRId64 " %s\n",
+                            ", %s, %s, %s, %s, ie %s, ctx %" PRId64 " %s\n",
                             i,
                             env->dtlb[i].tag & (uint64_t)~0x1fffULL,
                             TTE_PA(env->dtlb[i].tte),
@@ -801,6 +805,8 @@ void dump_mmu(CPUSPARCState *env)
                             TTE_IS_W_OK(env->dtlb[i].tte) ? "RW" : "RO",
                             TTE_IS_LOCKED(env->dtlb[i].tte) ?
                             "locked" : "unlocked",
+                            TTE_IS_IE(env->dtlb[i].tte) ?
+                            "yes" : "no",
                             env->dtlb[i].tag & (uint64_t)0x1fffULL,
                             TTE_IS_GLOBAL(env->dtlb[i].tte) ?
                             "global" : "local");
-- 
2.23.0



      parent reply	other threads:[~2019-08-23 18:54 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-23  1:02 [Qemu-devel] [PATCH v9 00/20] Invert Endian bit in SPARCv9 MMU TTE Tony Nguyen
2019-08-23  1:02 ` Tony Nguyen
2019-08-23  1:19   ` Tony Nguyen
2019-08-23  2:29   ` Richard Henderson
2019-08-23 12:25     ` tony.nguyen
2019-08-23 16:46       ` Richard Henderson
2019-08-23 18:51       ` Richard Henderson
2019-08-23 18:10   ` [Qemu-devel] [PATCH v9 01/20] tcg: TCGMemOp is now accelerator independent MemOp Tony Nguyen
2019-08-23 18:10     ` [Qemu-riscv] " Tony Nguyen
2019-08-23 18:29   ` [Qemu-devel] [PATCH v9 02/20] memory: Introduce size_memop Tony Nguyen
2019-08-23 18:36   ` [Qemu-devel] [PATCH v9 03/20] target/mips: Access MemoryRegion with MemOp Tony Nguyen
2019-08-23 18:36   ` [Qemu-devel] [PATCH v9 04/20] hw/s390x: " Tony Nguyen
2019-08-23 18:36   ` [Qemu-devel] [PATCH v9 05/20] hw/intc/armv7m_nic: " Tony Nguyen
2019-08-23 18:36   ` [Qemu-devel] [PATCH v9 06/20] hw/virtio: " Tony Nguyen
2019-08-23 18:36   ` [Qemu-devel] [PATCH v9 07/20] hw/vfio: " Tony Nguyen
2019-08-23 18:36   ` [Qemu-devel] [PATCH v9 08/20] exec: " Tony Nguyen
2019-08-23 18:36   ` [Qemu-devel] [PATCH v9 09/20] cputlb: " Tony Nguyen
2019-08-23 18:36   ` [Qemu-devel] [PATCH v9 10/20] memory: " Tony Nguyen
2019-08-23 18:36   ` [Qemu-devel] [PATCH v9 11/20] hw/s390x: Hard code size with MO_{8|16|32|64} Tony Nguyen
2019-08-23 18:36   ` [Qemu-devel] [PATCH v9 12/20] target/mips: " Tony Nguyen
2019-08-23 18:36   ` [Qemu-devel] [PATCH v9 13/20] exec: " Tony Nguyen
2019-08-23 18:36   ` [Qemu-devel] [PATCH v9 14/20] memory: Access MemoryRegion with endianness Tony Nguyen
2019-08-23 19:04     ` Richard Henderson
2019-08-23 18:36   ` [Qemu-devel] [PATCH v9 15/20] cputlb: Replace size and endian operands for MemOp Tony Nguyen
2019-08-23 18:36   ` [Qemu-devel] [PATCH v9 16/20] memory: Single byte swap along the I/O path Tony Nguyen
2019-08-23 19:12     ` Richard Henderson
2019-08-23 18:36   ` [Qemu-devel] [PATCH v9 17/20] cpu: TLB_FLAGS_MASK bit to force memory slow path Tony Nguyen
2019-08-23 22:27     ` Richard Henderson
2019-08-23 18:36   ` [Qemu-devel] [PATCH v9 18/20] cputlb: Byte swap memory transaction attribute Tony Nguyen
2019-08-23 18:36   ` [Qemu-devel] [PATCH v9 19/20] target/sparc: Add TLB entry with attributes Tony Nguyen
2019-08-23 18:36   ` Tony Nguyen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c8d5181a584f1b3712d3d8d66801b13cecb4b88.1566466906.git.tony.nguyen@bt.com \
    --to=tony.nguyen@bt.com \
    --cc=atar4qemu@gmail.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.