From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BDDBC54EE9 for ; Tue, 20 Sep 2022 08:12:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:Message-ID:In-Reply-To:Subject:cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GI/NGneGomxeh7KEAj/tujaqRHXW5p47Hzkr+Sggsgs=; b=oF1K2Ng4aWgRDP6pBiTm8OqidZ SV7G4R+sLnA2ea/bZmOzHbzrCVSG+Vx3Q+YPwTvjeoO4zqvad3aOlm57qjXvbXVX5z8FHJlXWErCM 2mtuO1WZqYeYo76x5Nu3olRoZCdVjdAEmZg+xeVKbZ5spT2TF2HqRlVidkmU+QHP4id8SbZ7sKfSN Tfui7eD5QbgNNIamF50TcwEZ/nhRbItsg+3ilvkcxESW2wZ+m7AIOUdWr3Jzi6pWo0e71ILyB4fsN 5+i8lxVDOlK5ccJfg/fk328f6J0owAJPyHBjc7uyRzSRLGa62Tz8u5aLoyq5YzuuS7jmqUh2bOViB fnbzxC8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaYLs-001dkj-Vs; Tue, 20 Sep 2022 08:11:33 +0000 Received: from mga02.intel.com ([134.134.136.20]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaYLe-001dXh-8T for linux-arm-kernel@lists.infradead.org; Tue, 20 Sep 2022 08:11:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663661478; x=1695197478; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=NpXFnndhkQG9hC09OmD04EE4e1t8OODVtE0sPkSoK7I=; b=gD/gxehfChmUNUH1UTtosAHKqFMYM9PDNtZCrTFlObphqqmG2tc2Uu4k PzOYqzVx041pKRS0ue2skhrl00hUHnAA9UiXvkcQD3sE8rcUselJ0qXRK OymxWl1N8CRQLoNLiIcWC476cNfW3nGdvgig2eMCr0K25iGU+Xo9Gnkc5 N9SOmfnsaNPsnIVMrdVml1Ji4gagUagLz1cs5XRyWMkoM1B5UVw/wwqwl 4MjATwsKAoj+qMEyuXSx60S5Qb9u9S8hwnwMovgCNigOGKXSq9d5T6mvd 8wF16LeW4N+uP31DxDM0sOA7zTnYHzSzEBB4R7a/m6DdVnXVabe4UhKHc w==; X-IronPort-AV: E=McAfee;i="6500,9779,10475"; a="286679415" X-IronPort-AV: E=Sophos;i="5.93,330,1654585200"; d="scan'208";a="286679415" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2022 01:11:12 -0700 X-IronPort-AV: E=Sophos;i="5.93,330,1654585200"; d="scan'208";a="614304129" Received: from bdallmer-mobl.ger.corp.intel.com ([10.252.59.238]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2022 01:11:10 -0700 Date: Tue, 20 Sep 2022 11:11:08 +0300 (EEST) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Jiri Slaby cc: Greg Kroah-Hartman , linux-serial , LKML , Vladimir Zapolskiy , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 05/10] tty: serial: extract tx_ready() from __serial_lpc32xx_tx() In-Reply-To: <20220920052049.20507-6-jslaby@suse.cz> Message-ID: <3c92a9b4-c531-d960-a3cd-827c42f7f48e@linux.intel.com> References: <20220920052049.20507-1-jslaby@suse.cz> <20220920052049.20507-6-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1092543553-1663661472=:1766" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220920_011118_563495_620FE435 X-CRM114-Status: GOOD ( 10.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1092543553-1663661472=:1766 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT On Tue, 20 Sep 2022, Jiri Slaby wrote: > The condition in __serial_lpc32xx_tx()'s loop is barely readable. > Extract it to a separate function. This will make the cleanup in the > next patches easier too. > > Cc: Vladimir Zapolskiy > Cc: > Signed-off-by: Jiri Slaby Reviewed-by: Ilpo Järvinen I noticed that wait_for_xmit_ready() uses < 32 for the similar check which seems fishy... -- i. --8323329-1092543553-1663661472=:1766 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --8323329-1092543553-1663661472=:1766-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C1E4ECAAD8 for ; Tue, 20 Sep 2022 08:13:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231398AbiITINj (ORCPT ); Tue, 20 Sep 2022 04:13:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230431AbiITIMw (ORCPT ); Tue, 20 Sep 2022 04:12:52 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C1676555B; Tue, 20 Sep 2022 01:11:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663661473; x=1695197473; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=NpXFnndhkQG9hC09OmD04EE4e1t8OODVtE0sPkSoK7I=; b=DmJcOwMqeZRFmOxuome3v/k3B7g/1+epzgEhkWX7SAvXTTJXnbu3xrF4 t6VFZF99fE/21FHqz33JnN229ehuwBpQ6c5cTNvCef2RBI0GuUyamyvV1 G/Pzi2AUhENxsv9N+kielpsMrZ7XmyUE874W/XeO1chZLuGjDqsGu2IRQ snVljn7OxOhsOCSrvrvneLSNfrAKaXBJB7VD7VCEjcK8QAlE7MTYUxLOw m2QlfvHFHczYD5XybWlcBxo8pAWLt9Ju30Pe1/RUznTRYuCnkXouYnwod XhllsKs2Qdb62ma9BlZfMjsT1uos10MFNDCoRkY0ThO+hJB8g4QDPccQ5 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10475"; a="297222696" X-IronPort-AV: E=Sophos;i="5.93,330,1654585200"; d="scan'208";a="297222696" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2022 01:11:12 -0700 X-IronPort-AV: E=Sophos;i="5.93,330,1654585200"; d="scan'208";a="614304129" Received: from bdallmer-mobl.ger.corp.intel.com ([10.252.59.238]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2022 01:11:10 -0700 Date: Tue, 20 Sep 2022 11:11:08 +0300 (EEST) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Jiri Slaby cc: Greg Kroah-Hartman , linux-serial , LKML , Vladimir Zapolskiy , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 05/10] tty: serial: extract tx_ready() from __serial_lpc32xx_tx() In-Reply-To: <20220920052049.20507-6-jslaby@suse.cz> Message-ID: <3c92a9b4-c531-d960-a3cd-827c42f7f48e@linux.intel.com> References: <20220920052049.20507-1-jslaby@suse.cz> <20220920052049.20507-6-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1092543553-1663661472=:1766" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1092543553-1663661472=:1766 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT On Tue, 20 Sep 2022, Jiri Slaby wrote: > The condition in __serial_lpc32xx_tx()'s loop is barely readable. > Extract it to a separate function. This will make the cleanup in the > next patches easier too. > > Cc: Vladimir Zapolskiy > Cc: > Signed-off-by: Jiri Slaby Reviewed-by: Ilpo Järvinen I noticed that wait_for_xmit_ready() uses < 32 for the similar check which seems fishy... -- i. --8323329-1092543553-1663661472=:1766--