From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74FFEECAAD8 for ; Fri, 16 Sep 2022 08:57:06 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B877A84BA7; Fri, 16 Sep 2022 10:57:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=quarantine dis=none) header.from=theobroma-systems.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=cherrycloud.onmicrosoft.com header.i=@cherrycloud.onmicrosoft.com header.b="lHZEaBBb"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3B31184BAC; Fri, 16 Sep 2022 10:57:02 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130052.outbound.protection.outlook.com [40.107.13.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8BA7284BA1 for ; Fri, 16 Sep 2022 10:56:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=theobroma-systems.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=quentin.schulz@theobroma-systems.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OFp2f53Gi3VhO99c8ad97GMrhsch+vuxb0wPg5TfYq0+VhIUPDC2P5j8ttrhnoUv0yfDJJHFfjz7Q17CothZtCb1T3GJzuGtlD0gKIluEOz6OdnHiOezcjU2/OzG/IQlDowj+EhWG2Zf1ix+KwaF5+qzZzZrAH9Cmj47Qc/LkiMhdAcDfAkaEd/js1aVEVFzn4PWK4x1gxCA3QC2TvdN9fTJ9DuO6oBN0LudnoW5zsg2A/OELRgXsJGYBi/I3dco82fAadVi/KE2TamQGJ1/VJLJ7MDI1NgSQpvOBo4018ZPtX5hlGuS1p7AFsaXPHf6ne7KYeH1UA0qz1g4Kh9F5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uwSc5BUaaChqdJrkuWTUnbyGIZGge3vgT1Bhi7iL6jo=; b=Li7fwCU3yEBZIqOxThkUlLmwsOzqgnqy/0PPd+ZoWgYZr5vu3aQOjzPm10qI4hqh/LzLGl6XUAOom+OE/B2jUd/8Sj+XUYGo0+5an88n3pL1zL3jDSHcn0A/7nhOEKfjH4xt1OxT01knXGVYBHuy3WbUOQK37l/AgYdbIvCUGsMhVXtFaXkMCqktcpTzWPOxw/W2bTEbHi6vDmhUZezHE9ndBZsDdx0IDmaM+g/npM+Nh3H9QNVpL7agpyv5jSSvsqLfggMMLVxkO+FCyTA7DltHTuUpF4pROAaxbuV71BqFoEiGClok15z/Lqo2uCs+8C2DyqCJSP7/IqGHgrStCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=theobroma-systems.com; dmarc=pass action=none header.from=theobroma-systems.com; dkim=pass header.d=theobroma-systems.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cherrycloud.onmicrosoft.com; s=selector2-cherrycloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uwSc5BUaaChqdJrkuWTUnbyGIZGge3vgT1Bhi7iL6jo=; b=lHZEaBBbhdhBnYXJW3g6i1Mxxm+m2GpldeKcZOCKnJjktmGr+8FjIY6qU2GofuUnKnW6br81PeO2vwn5RSxHivwd593Q3qMJoPBoLpAYvdrol5xR5e3xno+c8xgMpJWL6NhmTN6cKJFfzu6Wx6m33IS4lTQejlEcXJyfZm74HmQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=theobroma-systems.com; Received: from DU2PR04MB8536.eurprd04.prod.outlook.com (2603:10a6:10:2d7::10) by AS8PR04MB7848.eurprd04.prod.outlook.com (2603:10a6:20b:288::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16; Fri, 16 Sep 2022 08:56:58 +0000 Received: from DU2PR04MB8536.eurprd04.prod.outlook.com ([fe80::5e5e:1989:e5ec:c833]) by DU2PR04MB8536.eurprd04.prod.outlook.com ([fe80::5e5e:1989:e5ec:c833%3]) with mapi id 15.20.5632.016; Fri, 16 Sep 2022 08:56:58 +0000 Message-ID: <3c95dc1f-0434-6ba7-a570-d781876605b9@theobroma-systems.com> Date: Fri, 16 Sep 2022 10:56:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] mmc: dwmmc: only clear handled interrupts Content-Language: en-US To: John Keeping , Jaehoon Chung Cc: Peng Fan , u-boot@lists.denx.de References: <20220915175656.3447093-1-john@metanate.com> From: Quentin Schulz In-Reply-To: <20220915175656.3447093-1-john@metanate.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: VI1PR0902CA0051.eurprd09.prod.outlook.com (2603:10a6:802:1::40) To DU2PR04MB8536.eurprd04.prod.outlook.com (2603:10a6:10:2d7::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8536:EE_|AS8PR04MB7848:EE_ X-MS-Office365-Filtering-Correlation-Id: f116ee8e-a019-4b80-e871-08da97c1697c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: baNwk7lWz4Vu8fiP6CH0nStKUhjCCT9ABVaVKZBePhMfW9AXS1bSqFftl/Qlv+rm0YZ1nab2+2U946/YkeVm8TTUL24KCUxFLzR8F3kDLGnsneBBJA2NdkdmQzd/bBhUmuhGk/ULxALO6nGtR6km2fKo3lPkwIRWU/56G6jmY2AxPVaAUeIPE+dreX+hj7ED7K9rLxLL8GPwv9/RGhZxagu2TOECRDgR4fAuLKba/34AziBa3jnKWaLWZZNq5QUnhNLE6UmLLJa+Xn8hRzkUwOIxMlxGCflFuUlYWDK/11gJl0CGszaYW8oCx8JLwemYsAGIi8qaAd0VCK5smqCXfk+FOayN31vq1Dz0N5Q1ddJ2qlvPqKPCZ0ofmom8WevIG7WpWR9x5WvgrGhyeUlkX/bwHi5+ZtuC4GvQlo+yn8aXagaW1Hx7rwwddd45t7z60oWINroPamPJTpl0JbJC3f+JpYM3fseDSVVX2kcO0U/jZ7jkTJE3n/vfz/BQL69QsZAQOXtAozJfcnJbQIvs3hcRqVEN0fnji/VlzsmNW5dgii+bkjUmZ+DDnLbZCZSyBktS5+v/9fKtk4Z7s/Mfd9nPowSUHEcCGBjZYA/FsuI3ysMQx+4c4QqQ5/TgYCGGzObpHsoZlr+8zVBMepaLuCCavYNRRww7iEJoaWzdUICr+DM/E90bLP3lleFGEYtb4fpzpdNjKZ4g3O2++4TyOzpI+K3NEBEqw1pSnl6wjUvfYKGCNsXjdLI5YngWCtpWbyYceeMO9fipgLUYao2ZoLnJculUUjcyyzZpEXbeMUU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8536.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(136003)(396003)(39850400004)(366004)(346002)(451199015)(110136005)(31686004)(6486002)(186003)(26005)(41300700001)(478600001)(38100700002)(4326008)(8676002)(66556008)(66476007)(66946007)(83380400001)(2616005)(6512007)(8936002)(316002)(5660300002)(4744005)(44832011)(31696002)(6506007)(36756003)(86362001)(53546011)(2906002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0pNNUhTZVhsYU55b3VGL0hma2k2RFN5U253ZEVGSWhoT2FmSWtsZk1TdGx1?= =?utf-8?B?MzRGbWZlZFJsZTRRWGhkSi9TSGkyVGR5VlY1TFFKbVFiaytUb29Pc0Q2Z2RT?= =?utf-8?B?L0trckgwRk9PRWUwVjdGbHF4TXl1a05EdEZxTDRHWDUyQm1CR2hPOEVURW1D?= =?utf-8?B?TTR3TU11UXhKUTMyVTdSL2FPNEE4Myt1a0w4clUxNVFYdFhFZGxWNVNJMXVD?= =?utf-8?B?TjlvVkdwbmsyV2JkeVhVOEpXVlRDL0hOaHFLeTFraGRFRVNOc01JK2MzcHRX?= =?utf-8?B?UEs0K0xnejAxYXU0dk56M1JONThqQnZIb0dMbnZ5aTFtbElKQUZ0QnBBWkcy?= =?utf-8?B?clJvYWIxcitvR0tLbk9ObFpMVXFINU40cXdyT2FEMndaUzBqL3AwNlA5SEYv?= =?utf-8?B?OTVLdmZCMmJCZS9VUVBWcDRWYUtFZ2ZNZkNrS2IzeW9HU29XOEhJcTUzc3B6?= =?utf-8?B?WWszM3NBUUpjZXRSVE5qMFVsQjVtUlNSbHVJM3NCZ1V3Y29EaDQvNDZ2Rk1a?= =?utf-8?B?elhQZWtvNWcvdlgxTExDM0w3aVh0bHBFdERPaCtraDBZNVAwZ1Y5K1hXV29K?= =?utf-8?B?MVMzby8xbm5GaFBUWmF1M1Y3YUx2b3ZlTGtPZzIvYk1HcXlEa0FMUTZHN1hr?= =?utf-8?B?cFlBZlpORFI3TnNCeUZ6VlgyeFV0Q0paY0NiNDU2bVhRUU1oMEh4UkZtNDN3?= =?utf-8?B?L3d2L01qU1FjM0tscUtoTE9XRW9QUi9ETklBcHgzbWx2OWxwb2dRczVqeDJw?= =?utf-8?B?RHNlUkg2MHlydCtiMmQ0YzUyQk5hVDZYNjVOa0R2K3FtODdvRFpNY09yUEpm?= =?utf-8?B?MzBqMGhFRG92ZkhNSmxzTkdWSnZtNnErTktFbHlzMnBLNGd2MVVSMXhDbGli?= =?utf-8?B?Nmk4S0VDMWpZd0crM2R5Nk9pdGVISHFnaE9KSDB6TVBsUHM0NGdSYUlwRGNu?= =?utf-8?B?UmxQVWxlc3F0YitMMHMvd21KUmN0K25ubVJWMjY5Y1FEN0FZY0h2ZEV2S0VO?= =?utf-8?B?N2t3cVZ1VmVyM2N0VkRyYWI4NUpPQmhYV1I5SmZPc3VTRERSNFh5S2o4VTJZ?= =?utf-8?B?bi9DVW1jZlk2Qk5Va053LzU2RW40akFrN2s3VmZrTzV5MkZwTnRRWDV5ZkpD?= =?utf-8?B?V1B6TVVXZW5LQTBjVll2cjJWWUlmb3NnbGszbjdpRmlmTG1ndVgzME02ZmhJ?= =?utf-8?B?MzdhSE1xa2pKT28yUjRLOUpuMGJNL0pRZVpNY0hHWmE1ZHB2MnFSTjk0SCtp?= =?utf-8?B?VVdndnJZUzNzY1JMbElIZnpOQ0JGLzRSMGd2OFRFSjU3ZmhuNXR6WWE4bFly?= =?utf-8?B?TXlNTi80aGt4Zjc0RFY3bm1vdmFwUXhTbFBvSVFWbXNxaml6NlpXWmZWTkpP?= =?utf-8?B?L3R1VUZJWGxLaHBwckhxMEIvTEFlbTZVZi94N1VFNlRZRFdCd2w5ZmdlbWdZ?= =?utf-8?B?RlFFVThzV3JzYjB6VFpZM2xFeE8vaUd2V3ZHSEpIREtTcGh2Q2t6OWJzKzhS?= =?utf-8?B?Y2RFNXJ4aVRHeUR1R0ZpNkRid1dWVmhiUm5ubFlKUUd6N3dVekx0N2Z5NS96?= =?utf-8?B?cG5nWFZvOWZPZUErb09XcnJvTVhTeUUrN3c5VEptK1FlbTBScldtRm8zd2Ry?= =?utf-8?B?WkkyRnhvTVJUNXQ2MVlDN1pCekNvd3pFcVJuZmVQRWRjdHg4UlcxS20xQW1q?= =?utf-8?B?NGRqUE1CeUs3QS9pOUlacFNwMHQ4TkRhQjc5cnhOMGViUVRTcjZJNG1ZbGFk?= =?utf-8?B?VGRjMjI4ek5acEJET3dWWmFuTGhVN20yMFROVlp6OE1LQUpCSjQ3cVBxR3FQ?= =?utf-8?B?d0VoUzVXRWJ5dmhvL2JUK0lTWVptblhwdUF4WHFOL1BDaDNZcVNnV3JIMDZQ?= =?utf-8?B?N2xNMzBibTJUbXZuN3UwNzFjWVF1R3JBTGMzeXY4RGhFa0FKL09OU09PU254?= =?utf-8?B?N1E5RWd3dkZLY09teGZWLzRwb3FIVkxCVlBYbnl2cFFiUU5mSFBuVVVMb1pz?= =?utf-8?B?YmZPL2hBYXhPMkExcXZiaEhNMVhRWHd6MzhqUzVKNnFXYVNkOE83QnVGTldP?= =?utf-8?B?TjVhUXFlcGw1cUdrZG8rQ3l6RDMrRGtxdFhrUXE3WWp0MzVielR3amd3UHZ0?= =?utf-8?B?Ti9xc21DSGMrWGtQQzhoWWFEaHkzRXpmWGNEN0lsUzdTWlhFWkNQcHpkYXRI?= =?utf-8?Q?/OfgNK2XdYvsQtu3E6060sM=3D?= X-OriginatorOrg: theobroma-systems.com X-MS-Exchange-CrossTenant-Network-Message-Id: f116ee8e-a019-4b80-e871-08da97c1697c X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8536.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 08:56:58.2340 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5e0e1b52-21b5-4e7b-83bb-514ec460677e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5UOmMtQbMaoFjyisBb3QyVjH/baCngjqNRAeA1ol44oEpB9FYR3bqV5HZ3/cMRvq/QH/dOIs8piouKeM7c4p9aoc51v0Iq4hrz3VCjvXvDlxkRdlmDyc9wjSn/ncpWXy X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7848 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi John, On 9/15/22 19:56, John Keeping wrote: > Unconditionally clearing DTO when RXDR is set leads to spurious timeouts > in FIFO mode transfers if events occur in the following order: > > mask = dwmci_readl(host, DWMCI_RINTSTS); > > // Hardware asserts DWMCI_INTMSK_DTO here > > dwmci_writel(host, DWMCI_RINTSTS, DWMCI_INTMSK_DTO); > > if (mask & DWMCI_INTMSK_DTO) { > // Unreachable as DTO is cleared without being handled! > return 0; > } > > Only clear interrupts that we have seen and are handling so that DTO is > not missed. > > Signed-off-by: John Keeping Awesome! I was having what I thought were stability issues on a board I'm bringing up and this fixes the issue. Thanks! Tested-by: Quentin Schulz (PX30-based eMMC+SD, Puma RK3399 eMMC) Cheers, Quentin