From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EB04C47096 for ; Thu, 3 Jun 2021 16:31:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 500BB613EE for ; Thu, 3 Jun 2021 16:31:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229941AbhFCQcp (ORCPT ); Thu, 3 Jun 2021 12:32:45 -0400 Received: from mail-wr1-f48.google.com ([209.85.221.48]:37412 "EHLO mail-wr1-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229812AbhFCQco (ORCPT ); Thu, 3 Jun 2021 12:32:44 -0400 Received: by mail-wr1-f48.google.com with SMTP id i94so1447402wri.4 for ; Thu, 03 Jun 2021 09:30:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=reply-to:subject:to:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=K+QHPJyxgFtSkUCGSgJqOFgm6FpUIz56+9nBPBUsUEg=; b=jrxb2FlwDG/i8AKw6RpFmaEfeOx9YUTwfUFSiQ4iWtld/eleR/4kNImnbY6u4az9eN w4S2jedBZmVtCZZUS/H8UI3FKIlp03DaIKsrUCHezoPZ+R2L+DF5N4BSnZ5bTCSaUjHm vHdjoKo8Vqb7j+9des44Xc7Fk6gQyuE+6tWpaSdzzGLFxX8Kmd4BA+gSbxEfKCe7ZXbl YIxUgU1f/s+scWtXGq78MTvVn85+vbmgGhdNsMr5tWFR6QAAYE1wB8S77Z0kzWM06QY9 Z3JnZquMxLDM5EPxTUTSqWds9+8u4fyL3O51kUtchfBijn+DQHibXLcCI3PTl7gy3IDj 6l3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=K+QHPJyxgFtSkUCGSgJqOFgm6FpUIz56+9nBPBUsUEg=; b=ErU3iGuAuNXh9LinpH5bmy6Mrgo6LBJw9mDBLTA7VyQIWjLvj+06tuj9HMrYnTthae PNKr0HhC181RddfkhyMtmS1O6xMpqsGPfvy2lrIFiuOJEhwb6pehbms1igwtuaWxY0gi 83+Q18GbNwouSoGjVZ5mgtV9YUQLbZffYGwu0vjQfj+8gwMYIvDftSKkN1rgAea951Ds lm5IcF+RLwdAbJoipeGyMh3nk3UfhNPw80PXsuP4S81z8B+nKVZAZYR3DdnM4I1bzuZh HOdlDeiSb3fWdiePRotZ62q55slRBFrTm7G9SeqnubhZX64buToqBm56Pq4sy0m55bK0 4+1g== X-Gm-Message-State: AOAM530meOO6mnjgBYC7auSZC1glN6VzgXWAdl02Ms7VEr38MvxdRItk oIdU2lYCC5O9eUr5c7q2MLwfOuYwE4yYsA== X-Google-Smtp-Source: ABdhPJykYa2Y4bt1Toern5/jC3uH/816oweS2/xMvzt6oR95Dnctt5ePG2a5RtHx9YrjGceak28Vmg== X-Received: by 2002:a5d:5049:: with SMTP id h9mr764620wrt.221.1622737782147; Thu, 03 Jun 2021 09:29:42 -0700 (PDT) Received: from ?IPv6:2a01:e0a:410:bb00:104d:bd76:408:a323? ([2a01:e0a:410:bb00:104d:bd76:408:a323]) by smtp.gmail.com with ESMTPSA id n9sm4512223wrt.81.2021.06.03.09.29.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Jun 2021 09:29:41 -0700 (PDT) Reply-To: nicolas.dichtel@6wind.com Subject: Re: [PATCH] ipv6: parameter p.name is empty To: David Ahern , zhang kai , davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210603095030.2920-1-zhangkaiheb@126.com> From: Nicolas Dichtel Organization: 6WIND Message-ID: <3c9bcc89-0ec7-0588-719e-d63b36bef132@6wind.com> Date: Thu, 3 Jun 2021 18:29:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 03/06/2021 à 17:15, David Ahern a écrit : > On 6/3/21 7:33 AM, Nicolas Dichtel wrote: >> Le 03/06/2021 à 11:50, zhang kai a écrit : >>> so do not check it. >>> >>> Signed-off-by: zhang kai >>> --- >>> net/ipv6/addrconf.c | 3 --- >>> 1 file changed, 3 deletions(-) >>> >>> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c >>> index b0ef65eb9..4c6b3fc7e 100644 >>> --- a/net/ipv6/addrconf.c >>> +++ b/net/ipv6/addrconf.c >>> @@ -2833,9 +2833,6 @@ static int addrconf_set_sit_dstaddr(struct net *net, struct net_device *dev, >>> if (err) >>> return err; >>> >>> - dev = __dev_get_by_name(net, p.name); >>> - if (!dev) >>> - return -ENOBUFS; >>> return dev_open(dev, NULL); >>> } >>> >>> >> This bug seems to exist since the beginning of the SIT driver (24 years!): >> https://git.kernel.org/pub/scm/linux/kernel/git/davem/netdev-vger-cvs.git/commit/?id=e5afd356a411a >> Search addrconf_set_dstaddr() >> >> Acked-by: Nicolas Dichtel >> > > A patch was sent yesterday, "sit: set name of device back to struct > parms", to set the name field in params. > Oh yes, it was in my spam folder ...