From: Juergen Gross <jgross@suse.com>
To: Ian Jackson <iwj@xenproject.org>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v5 2/2] tools/xenstore: set open file descriptor limit for xenstored
Date: Wed, 29 Sep 2021 07:31:33 +0200 [thread overview]
Message-ID: <3c9bfe5d-c471-c771-d6a7-a15cca466cb6@suse.com> (raw)
In-Reply-To: <24915.13356.139165.259646@mariner.uk.xensource.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 721 bytes --]
On 28.09.21 17:26, Ian Jackson wrote:
> Juergen Gross writes ("Re: [PATCH v5 2/2] tools/xenstore: set open file descriptor limit for xenstored"):
>> Hmm, maybe I should just use:
>>
>> prlimit --nofile=$XENSTORED_MAX_OPEN_FDS \
>> $XENSTORED --pid-file @XEN_RUN_DIR@/xenstored.pid $XENSTORED_ARGS
>
> I guess that would probably work (although it involves another
> exec) but I don't understand what's wrong with ulimit, which is a
> shell builtin.
My main concern with ulimit is that this would set the open file limit
for _all_ children of the script. I don't think right now this is a real
problem, but it feels wrong to me (systemd-notify ought to be fine, but
you never know ...).
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2021-09-29 5:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 9:15 [PATCH v5 0/2] tools/xenstore: set resource limits of xenstored Juergen Gross
2021-09-28 9:15 ` [PATCH v5 1/2] tools/xenstore: set oom score for xenstore daemon on Linux Juergen Gross
2021-09-28 9:15 ` [PATCH v5 2/2] tools/xenstore: set open file descriptor limit for xenstored Juergen Gross
2021-09-28 12:02 ` Ian Jackson
2021-09-28 12:15 ` Juergen Gross
2021-09-28 15:26 ` Ian Jackson
2021-09-29 5:31 ` Juergen Gross [this message]
2021-10-11 9:31 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c9bfe5d-c471-c771-d6a7-a15cca466cb6@suse.com \
--to=jgross@suse.com \
--cc=iwj@xenproject.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.