From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brWm7-0005TU-GX for qemu-devel@nongnu.org; Tue, 04 Oct 2016 16:57:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brWm2-0006oh-Cc for qemu-devel@nongnu.org; Tue, 04 Oct 2016 16:57:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40158) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brWm2-0006oZ-3H for qemu-devel@nongnu.org; Tue, 04 Oct 2016 16:57:14 -0400 References: <20161003190442.GE3877@thinpad.lan.raisama.net> <20161004182234.GH3877@thinpad.lan.raisama.net> From: Eric Blake Message-ID: <3cb10a75-52f0-d718-bcec-6f888ac0a6a8@redhat.com> Date: Tue, 4 Oct 2016 15:57:10 -0500 MIME-Version: 1.0 In-Reply-To: <20161004182234.GH3877@thinpad.lan.raisama.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bvFad5qHsSNb9WXnp9tJdIF4MJT70LwkH" Subject: Re: [Qemu-devel] [libvirt] QMP stubs: how to return "not implemented" errors? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Markus Armbruster , libvir-list@redhat.com, David Hildenbrand , Jiri Denemark , "Jason J. Herne" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --bvFad5qHsSNb9WXnp9tJdIF4MJT70LwkH From: Eric Blake To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Markus Armbruster , libvir-list@redhat.com, David Hildenbrand , Jiri Denemark , "Jason J. Herne" Message-ID: <3cb10a75-52f0-d718-bcec-6f888ac0a6a8@redhat.com> Subject: Re: [libvirt] QMP stubs: how to return "not implemented" errors? References: <20161003190442.GE3877@thinpad.lan.raisama.net> <20161004182234.GH3877@thinpad.lan.raisama.net> In-Reply-To: <20161004182234.GH3877@thinpad.lan.raisama.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/04/2016 01:22 PM, Eduardo Habkost wrote: > On Mon, Oct 03, 2016 at 03:15:39PM -0500, Eric Blake wrote: > [...] >>> 3.2) Removing the unimplemented command from query-commands only >>> (by calling qmp_disable_command()), but keeping it on the QAPI >>> schema. I am not sure it's OK to do that. If it is, this >>> sounds like the simplest solution. >> >> We already have existing commands in this category, and it is >> conceptually the easiest (if query-commands doesn't list the command, >> then the command doesn't work even if the introspection still shows it= ). > [...] >=20 > Which commands are already in this category? I don't see any > qmp_disable_command() calls on the tree except for guest agent > code. Probably a typo on my side; commit 5032a16d adds the use of qmp_unregister_command(), not qmp_disable_command(). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --bvFad5qHsSNb9WXnp9tJdIF4MJT70LwkH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX9BemAAoJEKeha0olJ0NqNZEH/AgvC7m4dk8+Bh9ReZR1Xp7r k8T0gYf6ImCBMNLcBKzwL3V2ltoYa8pLckY3QUPAbfxQ4Gp+nFQwHM1YbQI/dmTX WDgkkwnGrtixQbu1KEFAOAM3HKPKw+GGn9oZK6tx1PJj70qT3yczlKaPYpeU8qa6 Eet8JV6MbDkVjU+h4CY0wWdAz47gkaOOQ6fd2/hs6kAIqFIRrIaeZvMEDGxwyY5p C65ZRpavacPUVSuv/3ecO9Ls6mqOpx153WOU86Jo9GtqkMbFxHhNkZCxirE2jTCv IZMmlaaPUsVTHcskQmSmA/f+FIUnFqguNfkOk4F7xay3qIOZua86L8ufN2ZiBIY= =HwoA -----END PGP SIGNATURE----- --bvFad5qHsSNb9WXnp9tJdIF4MJT70LwkH--