From mboxrd@z Thu Jan  1 00:00:00 1970
From: Akhil Goyal <akhil.goyal@nxp.com>
Subject: Re: [PATCH] doc: announce API changes in crypto library
Date: Tue, 9 May 2017 14:27:59 +0530
Message-ID: <3cb940aa-8f53-f20f-714d-fb2efd74c8a8@nxp.com>
References: <1493912243-7584-1-git-send-email-tomaszx.kulasek@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <declan.doherty@intel.com>
To: Tomasz Kulasek <tomaszx.kulasek@intel.com>, <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-BY2-obe.outbound.protection.outlook.com
 (mail-by2nam03on0044.outbound.protection.outlook.com [104.47.42.44])
 by dpdk.org (Postfix) with ESMTP id 947944A63
 for <dev@dpdk.org>; Tue,  9 May 2017 10:58:07 +0200 (CEST)
In-Reply-To: <1493912243-7584-1-git-send-email-tomaszx.kulasek@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/4/2017 9:07 PM, Tomasz Kulasek wrote:
> API changes are planned for 17.08 to made sessions agnostic to the
> underlaying devices, removing coupling with crypto PMDs, so a single
> session can be used on multiple devices.
>
> It requires to change "struct rte_cryptodev_sym_session" to store more
> than one private data for devices, as well as remove redundant dev_id
> and dev_type.
>
> Effected public functions:
>
>  - rte_cryptodev_sym_session_pool_create
>  - rte_cryptodev_sym_session_create
>  - rte_cryptodev_sym_session_free
>
> While session will not be directly associated with device, followed API
> will be changed adding uint8_t dev_id to the argument list:
>
>  - rte_cryptodev_queue_pair_attach_sym_session
>  - rte_cryptodev_queue_pair_detach_sym_session
>
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> ---
>
> Detailed list of changes and scope of work is sent in the separate RFC:
> http://dpdk.org/dev/patchwork/patch/24091/ ("[dpdk-dev,RFC] cryptodev:
> make crypto session device independent")
>
>  doc/guides/rel_notes/deprecation.rst | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index a3e7c72..5527c20 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -81,3 +81,24 @@ Deprecation Notices
>
>    - ``rte_crpytodev_scheduler_mode_get``, replaced by ``rte_cryptodev_scheduler_mode_get``
>    - ``rte_crpytodev_scheduler_mode_set``, replaced by ``rte_cryptodev_scheduler_mode_set``
> +
> +* cryptodev: API changes are planned for 17.08 for the sessions management
> +  to make it agnostic to the underlying devices, removing coupling with
> +  crypto PMDs, so a single session can be used on multiple devices.
> +
> +  - ``struct rte_cryptodev_sym_session``, dev_id, dev_type will be removed,
> +    _private field changed to the indirect array of private data pointers of
> +    all supported devices
> +
> +  An API of followed functions will be changed to allow operate on multiple
> +  devices with one session:
> +
> +  - ``rte_cryptodev_sym_session_create``
> +  - ``rte_cryptodev_sym_session_free``
> +  - ``rte_cryptodev_sym_session_pool_create``
> +
> +  While dev_id will not be stored in the ``struct rte_cryptodev_sym_session``,
> +  directly, the change of followed API is required:
> +
> +  - ``rte_cryptodev_queue_pair_attach_sym_session``
> +  - ``rte_cryptodev_queue_pair_detach_sym_session``
> \ No newline at end of file
>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>