All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Sergey Shtylyov <s.shtylyov@omp.ru>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	<linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] scsi: hisi_sas: propagate errors in interrupt_init_v1_hw()
Date: Thu, 20 May 2021 09:44:49 +0100	[thread overview]
Message-ID: <3cbaf195-6f08-24e0-0eaa-f50616573c04@huawei.com> (raw)
In-Reply-To: <49ba93a3-d427-7542-d85a-b74fe1a33a73@omp.ru>

On 19/05/2021 20:20, Sergey Shtylyov wrote:
> After the commit 6c11dc060427 ("scsi: hisi_sas: Fix IRQ checks") we have
> the error codes returned by platform_get_irq() ready for the propagation
> upsream in interrupt_init_v1_hw() -- that will fix still broken deferred
> probing. Let's propagate the error codes from devm_request_irq() as well
> since I don't see the reason to override them with -ENOENT...
> 
> Fixes: df2d8213d9e3 ("hisi_sas: use platform_get_irq()")

Personally I would drop the fixes tag. I am almost sure that this HW is 
not used any longer. And I don't see a point in this change being picked 
up by stable.

> Signed-off-by: Sergey Shtylyov<s.shtylyov@omp.ru>

Acked-by: John Garry <john.garry@huawei.com>

  reply	other threads:[~2021-05-20  8:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19 19:20 [PATCH] scsi: hisi_sas: propagate errors in interrupt_init_v1_hw() Sergey Shtylyov
2021-05-20  8:44 ` John Garry [this message]
2021-05-21 21:05 ` Martin K. Petersen
2021-05-26  4:07 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3cbaf195-6f08-24e0-0eaa-f50616573c04@huawei.com \
    --to=john.garry@huawei.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=s.shtylyov@omp.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.