From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4B18C433ED for ; Sun, 2 May 2021 18:35:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44E18611EE for ; Sun, 2 May 2021 18:35:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44E18611EE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39220 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldGvo-00087o-MC for qemu-devel@archiver.kernel.org; Sun, 02 May 2021 14:35:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldGnn-0000UF-Hy; Sun, 02 May 2021 14:26:47 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:42813) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldGnl-0000VA-Oy; Sun, 02 May 2021 14:26:47 -0400 Received: from [192.168.100.1] ([82.142.20.222]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.119]) with ESMTPSA (Nemesis) id 1M2OEq-1lZPBN3sYI-003sCC; Sun, 02 May 2021 20:26:28 +0200 Subject: Re: [PATCH-for-6.0?] hw/rx/rx-gdbsim: Do not accept invalid memory size To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, QEMU Trivial References: <20210407223056.1870497-1-f4bug@amsat.org> From: Laurent Vivier Message-ID: <3cc4fcdc-18a8-bbd7-6d4e-116129283dd7@vivier.eu> Date: Sun, 2 May 2021 20:26:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:SchIq+yAqxOxhiOuCaQ08DiDW0GeIqrGb1+4ZtSAsUchU4puxyG 8uvPQ6X7VSm4SnOT6GWvMsKYLFKBD5VxMgVX4lAgbhpF8rOwEjnQ/ihrkL1liK8cTdER64V Iz1feT8RZEMD64cHfPlz9ae8WFhcSavFXZiZ8jaMi9YcoQsRZ6opLkBpVj+tNz3LDJUalL0 eRyzs4a5UiDl2OAEuQZOg== X-UI-Out-Filterresults: notjunk:1;V03:K0:0wOFndYwsjA=:xPU0fM3OfjEmDf6cy64VGo rIn1DqyeDARN/5Goer88AZqBlXWxQTif3g8sIQardQkI/RYDjAUvkNCOVBQlhpAkMGkJWM8mo hhg+6wLxKUEEG4P2uya4KZ+c6tsNwypZHJPQUyHc5l9PIcUA0meDIzFENn8yj8DHqtNa24Bzd 4GhD/FjA36IffBjgl67s5sdcevjQ/VskEi2VC8tFKj4JMTzhxngWfX5PJCzVk85blnSuX2yoE 9Rr1DMJlRm6UPsCwI7eQxpd8NZKlG1jIzBF5bn6fVqxqGRuvBBY3ezk6Y0V/weJ20mZYpjqNr 8CtLTLNoQVzqoHAdW19KnEqnX/Yi8nJbagSHtuf8hSB/ui/7r6sKwZJ+rIrdf1eTQ8JMyO9Zt /zokT+9bItvAudMDLY+4NKJZPfM2PMgtfL9IXelpb/9sc1nScpeOZuipTuXoV/uTQ2p6BlBlk aGI3tS+iT76TOVk0mVgUd2AlvjV2Q9cnsLYulxqM73i+5clavEL9JDxzEmZG5bbT3azHoIz0K GfNG/ZcwwDzRq4qGv7Mo4I= Received-SPF: none client-ip=217.72.192.73; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yoshinori Sato Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 02/05/2021 à 18:27, Philippe Mathieu-Daudé a écrit : > Hi Laurent, could you take this patch via your Trivial tree please? > > On 4/8/21 12:30 AM, Philippe Mathieu-Daudé wrote: >> We check the amount of RAM is enough, warn when it is >> not, but if so we neglect to bail out. Fix that by >> adding the missing exit() call. >> >> Fixes: bda19d7bb56 ("hw/rx: Add RX GDB simulator") >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/rx/rx-gdbsim.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/hw/rx/rx-gdbsim.c b/hw/rx/rx-gdbsim.c >> index b1d7c2488ff..4e4ececae4b 100644 >> --- a/hw/rx/rx-gdbsim.c >> +++ b/hw/rx/rx-gdbsim.c >> @@ -93,6 +93,7 @@ static void rx_gdbsim_init(MachineState *machine) >> char *sz = size_to_str(mc->default_ram_size); >> error_report("Invalid RAM size, should be more than %s", sz); >> g_free(sz); >> + exit(1); >> } >> >> /* Allocate memory space */ >> > Applied to my trivial-patches branch. Thanks, Laurent