From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43984C4346E for ; Fri, 25 Sep 2020 02:48:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EBAD0206FB for ; Fri, 25 Sep 2020 02:48:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726954AbgIYCsB convert rfc822-to-8bit (ORCPT ); Thu, 24 Sep 2020 22:48:01 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:3560 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726448AbgIYCsB (ORCPT ); Thu, 24 Sep 2020 22:48:01 -0400 Received: from dggeme752-chm.china.huawei.com (unknown [172.30.72.55]) by Forcepoint Email with ESMTP id 0E2D0C137D03431F3A16; Fri, 25 Sep 2020 10:47:59 +0800 (CST) Received: from dggeme753-chm.china.huawei.com (10.3.19.99) by dggeme752-chm.china.huawei.com (10.3.19.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1913.5; Fri, 25 Sep 2020 10:47:58 +0800 Received: from dggeme753-chm.china.huawei.com ([10.7.64.70]) by dggeme753-chm.china.huawei.com ([10.7.64.70]) with mapi id 15.01.1913.007; Fri, 25 Sep 2020 10:47:58 +0800 From: linmiaohe To: Andrew Morton CC: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] mm/mempool: Add 'else' to split mutually exclusive case Thread-Topic: [PATCH v2] mm/mempool: Add 'else' to split mutually exclusive case Thread-Index: AdaS5faxg3FHsPPEQpeRvHY4DCGK8w== Date: Fri, 25 Sep 2020 02:47:58 +0000 Message-ID: <3cc5c0cd2eef450ca8d8843ab72edc98@huawei.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.176.109] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton wrote: > On Thu, 24 Sep 2020 07:16:41 -0400 Miaohe Lin wrote: > >> Add else to split mutually exclusive case and avoid some unnecessary check. >> It doesn't seem to change code generation (compiler is smart), but I >> think it helps readability. > > OK, I guess. But the comments are now in the wrong place. > Many thanks for kindly reply and fix the wrong comments place. Have a good day! > --- a/mm/mempool.c~mm-mempool-add-else-to-split-mutually-exclusive-case-fix > +++ a/mm/mempool.c > @@ -60,8 +60,8 @@ static void check_element(mempool_t *poo > /* Mempools backed by slab allocator */ > if (pool->free == mempool_free_slab || pool->free == mempool_kfree) { > __check_element(pool, element, ksize(element)); > - /* Mempools backed by page allocator */ > } else if (pool->free == mempool_free_pages) { > + /* Mempools backed by page allocator */ > int order = (int)(long)pool->pool_data; > void *addr = kmap_atomic((struct page *)element); > > @@ -83,8 +83,8 @@ static void poison_element(mempool_t *po > /* Mempools backed by slab allocator */ > if (pool->alloc == mempool_alloc_slab || pool->alloc == mempool_kmalloc) { > __poison_element(element, ksize(element)); > - /* Mempools backed by page allocator */ > } else if (pool->alloc == mempool_alloc_pages) { > + /* Mempools backed by page allocator */ > int order = (int)(long)pool->pool_data; > void *addr = kmap_atomic((struct page *)element); > > _ > >