From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinan Kaya Subject: Re: [PATCH 29/30] i7300_idle: deprecate pci_get_bus_and_slot() Date: Wed, 22 Nov 2017 11:50:53 -0500 Message-ID: <3cca8693-72bf-db72-f698-f111c9ef707c@codeaurora.org> References: <1511328675-21981-1-git-send-email-okaya@codeaurora.org> <1511328675-21981-30-git-send-email-okaya@codeaurora.org> <20171122075345.GC26583@kroah.com> <81de37c1-26b5-41f7-ab32-b98012890971@codeaurora.org> <20171122164546.GB30812@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171122164546.GB30812@kroah.com> Content-Language: en-US Sender: linux-pci-owner@vger.kernel.org To: Greg Kroah-Hartman Cc: linux-pci@vger.kernel.org, timur@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Philippe Ombredanne , Kate Stewart , Thomas Gleixner , open list List-Id: linux-arm-msm@vger.kernel.org On 11/22/2017 11:45 AM, Greg Kroah-Hartman wrote: >> Funny thing is nobody is calling this function. Maybe, I should just kill it >> instead. > Yes, delete it. Why doesn't the build warn about it not being used? > OK. Because it is in a header file that nobody includes. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [PATCH 29/30] i7300_idle: deprecate pci_get_bus_and_slot() To: Greg Kroah-Hartman References: <1511328675-21981-1-git-send-email-okaya@codeaurora.org> <1511328675-21981-30-git-send-email-okaya@codeaurora.org> <20171122075345.GC26583@kroah.com> <81de37c1-26b5-41f7-ab32-b98012890971@codeaurora.org> <20171122164546.GB30812@kroah.com> From: Sinan Kaya Message-ID: <3cca8693-72bf-db72-f698-f111c9ef707c@codeaurora.org> Date: Wed, 22 Nov 2017 11:50:53 -0500 MIME-Version: 1.0 In-Reply-To: <20171122164546.GB30812@kroah.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kate Stewart , linux-pci@vger.kernel.org, timur@codeaurora.org, open list , Philippe Ombredanne , linux-arm-msm@vger.kernel.org, Thomas Gleixner , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: On 11/22/2017 11:45 AM, Greg Kroah-Hartman wrote: >> Funny thing is nobody is calling this function. Maybe, I should just kill it >> instead. > Yes, delete it. Why doesn't the build warn about it not being used? > OK. Because it is in a header file that nobody includes. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: okaya@codeaurora.org (Sinan Kaya) Date: Wed, 22 Nov 2017 11:50:53 -0500 Subject: [PATCH 29/30] i7300_idle: deprecate pci_get_bus_and_slot() In-Reply-To: <20171122164546.GB30812@kroah.com> References: <1511328675-21981-1-git-send-email-okaya@codeaurora.org> <1511328675-21981-30-git-send-email-okaya@codeaurora.org> <20171122075345.GC26583@kroah.com> <81de37c1-26b5-41f7-ab32-b98012890971@codeaurora.org> <20171122164546.GB30812@kroah.com> Message-ID: <3cca8693-72bf-db72-f698-f111c9ef707c@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/22/2017 11:45 AM, Greg Kroah-Hartman wrote: >> Funny thing is nobody is calling this function. Maybe, I should just kill it >> instead. > Yes, delete it. Why doesn't the build warn about it not being used? > OK. Because it is in a header file that nobody includes. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.