From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E137C433DB for ; Fri, 29 Jan 2021 06:25:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7E4A64E00 for ; Fri, 29 Jan 2021 06:25:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231977AbhA2GY6 (ORCPT ); Fri, 29 Jan 2021 01:24:58 -0500 Received: from mga14.intel.com ([192.55.52.115]:28815 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbhA2GY6 (ORCPT ); Fri, 29 Jan 2021 01:24:58 -0500 IronPort-SDR: dm5xGpU9x8P2adH7WYf0PueRibpYkQxtDBzbHLFVlgn5+haoB+FbnuE4z6zFUKth+rAZBJrZgo jXKLo9NTc57A== X-IronPort-AV: E=McAfee;i="6000,8403,9878"; a="179592621" X-IronPort-AV: E=Sophos;i="5.79,384,1602572400"; d="scan'208";a="179592621" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 22:24:16 -0800 IronPort-SDR: EK93pEI217TQHa8q2fHpFwHLFvEwlrOHY9lSiGKvzsdIcsMAHTfNKCGN8Eiv036RmP8M8ib6Q/ 5/HpzIK70ZqQ== X-IronPort-AV: E=Sophos;i="5.79,384,1602572400"; d="scan'208";a="578942440" Received: from chengpol-mobl1.ccr.corp.intel.com ([10.249.170.29]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 22:24:14 -0800 Message-ID: <3ccebb5f3b7ae48166abf000b286589bd80a2ada.camel@intel.com> Subject: Re: [PATCH -next] acpi: fpdt: drop errant comma in pr_info() From: Zhang Rui To: Randy Dunlap , linux-kernel@vger.kernel.org Cc: "Rafael J. Wysocki" , "Rafael J . Wysocki" , Len Brown , linux-acpi@vger.kernel.org Date: Fri, 29 Jan 2021 14:24:12 +0800 In-Reply-To: <20210128232528.21117-1-rdunlap@infradead.org> References: <20210128232528.21117-1-rdunlap@infradead.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi, Randy, Thanks for the patch, a similar patch has been posted earlier, but I forgot to cc linux-acpi mailing list. https://marc.info/?l=linux-next&m=161172750710666&w=2 Now given that there are a couple of fixes needed for the original patch, I just refreshed the original patch to include all the fixes. https://patchwork.kernel.org/project/linux-acpi/patch/20210129061548.13448-1-rui.zhang@intel.com/ thanks, rui On Thu, 2021-01-28 at 15:25 -0800, Randy Dunlap wrote: > Drop a mistaken comma in the pr_info() args to prevent the > build warning. > > ../drivers/acpi/acpi_fpdt.c: In function 'acpi_init_fpdt': > ../include/linux/kern_levels.h:5:18: warning: too many arguments for > format [-Wformat-extra-args] > ../drivers/acpi/acpi_fpdt.c:255:4: note: in expansion of macro > 'pr_info' > pr_info(FW_BUG, "Invalid subtable type %d found.\n", > > Fixes: 208757d71098 ("ACPI: tables: introduce support for FPDT > table") > Signed-off-by: Randy Dunlap > Cc: "Rafael J. Wysocki" > Cc: Rafael J. Wysocki > Cc: Len Brown > Cc: linux-acpi@vger.kernel.org > Cc: Zhang Rui > --- > drivers/acpi/acpi_fpdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20210128.orig/drivers/acpi/acpi_fpdt.c > +++ linux-next-20210128/drivers/acpi/acpi_fpdt.c > @@ -252,7 +252,7 @@ void acpi_init_fpdt(void) > subtable->type); > break; > default: > - pr_info(FW_BUG, "Invalid subtable type %d > found.\n", > + pr_info(FW_BUG "Invalid subtable type %d > found.\n", > subtable->type); > return; > }