From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sun, 7 Aug 2016 16:05:48 +0200 Subject: [U-Boot] [PATCH] spi: cadence_qspi_apb: Ensure baudrate doesn't exceed max value In-Reply-To: <1470578014-2263-1-git-send-email-clsee@altera.com> References: <1470578014-2263-1-git-send-email-clsee@altera.com> Message-ID: <3cd3937b-81e1-6c17-9d2d-035cb341cc82@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/07/2016 03:53 PM, Chin Liang See wrote: > Ensuring the baudrate divisor value doesn't exceed the max value > in the calculation.It will be capped at max value to ensure the > correct value being written into the register. > > Signed-off-by: Chin Liang See > Cc: Marek Vasut > Cc: Jagan Teki > Cc: Dinh Nguyen > --- > drivers/spi/cadence_qspi_apb.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/spi/cadence_qspi_apb.c b/drivers/spi/cadence_qspi_apb.c > index 1a35d55..e6a8ecb 100644 > --- a/drivers/spi/cadence_qspi_apb.c > +++ b/drivers/spi/cadence_qspi_apb.c > @@ -293,6 +293,10 @@ void cadence_qspi_apb_config_baudrate_div(void *reg_base, > debug("%s: ref_clk %dHz sclk %dHz Div 0x%x\n", __func__, > ref_clk_hz, sclk_hz, div); > > + /* ensure the baud rate doesn't exceed the max value */ > + if (div > CQSPI_REG_CONFIG_BAUD_MASK) > + div = CQSPI_REG_CONFIG_BAUD_MASK; > + > div = (div & CQSPI_REG_CONFIG_BAUD_MASK) << CQSPI_REG_CONFIG_BAUD_LSB; The capping happens here ^ already , doesn't it ? > reg |= div; > writel(reg, reg_base + CQSPI_REG_CONFIG); > -- Best regards, Marek Vasut