From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B04EC05027 for ; Thu, 2 Feb 2023 16:19:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232600AbjBBQTg (ORCPT ); Thu, 2 Feb 2023 11:19:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232591AbjBBQTT (ORCPT ); Thu, 2 Feb 2023 11:19:19 -0500 Received: from mailout-taastrup.gigahost.dk (mailout-taastrup.gigahost.dk [46.183.139.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9686F4CE69; Thu, 2 Feb 2023 08:19:11 -0800 (PST) Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id C5A801883528; Thu, 2 Feb 2023 16:19:07 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id BABFF250007B; Thu, 2 Feb 2023 16:19:07 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id B0E8191201E4; Thu, 2 Feb 2023 16:19:07 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Thu, 02 Feb 2023 17:19:07 +0100 From: netdev@kapio-technology.com To: Ido Schimmel Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , "maintainer:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER" , Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , =?UTF-8?Q?Cl=C3=A9m?= =?UTF-8?Q?ent_L=C3=A9ger?= , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Russell King , Christian Marangi , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER" , "moderated list:ETHERNET BRIDGE" Subject: Re: [PATCH net-next 0/5] ATU and FDB synchronization on locked ports In-Reply-To: References: <20230130173429.3577450-1-netdev@kapio-technology.com> User-Agent: Gigahost Webmail Message-ID: <3cecf4425b0e6f38646e25e40fd8f0fd@kapio-technology.com> X-Sender: netdev@kapio-technology.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-02-02 16:43, Ido Schimmel wrote: > On Thu, Feb 02, 2023 at 08:37:08AM +0100, netdev@kapio-technology.com > wrote: >> On 2023-01-31 20:25, Ido Schimmel wrote: >> > >> > Will try to review tomorrow, but it looks like this set is missing >> > selftests. What about extending bridge_locked_port.sh? >> >> I knew you would take this up. :-) >> But I am not sure that it's so easy to have selftests here as it is >> timing >> based and it would take the 5+ minutes just waiting to test in the >> stadard >> case, and there is opnly support for mv88e6xxx driver with this patch >> set. > > The ageing time is configurable: See commit 081197591769 ("selftests: > net: bridge: Parameterize ageing timeout"). Please add test cases in > the > next version. When I was looking at configuring the ageing time last time, my finding was that the ageing time could not be set very low as there was some part in the DSA layer etc, and confusion wrt units. I think the minimum secured was like around 2 min. (not validated), which is not that much of an improvement for fast testing. If you know what would be a good low timeout to set, I would like to know. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9DF2FC64EC3 for ; Thu, 2 Feb 2023 16:20:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=p1epzuN0DXFBkRPBb9z3e+GIW0TcPM2ZzHwEst6/1n8=; b=lKrOpmlOYcMV/+l2pym0kTcLvp wF1ssWYPXWozQQgekKTTLNWxdfeQIqFBhMXSc3TDKPHSp175sUI84FpDuaW9xTAtF0/fbUQercooQ +64Y4yi35xs2mv+/HJmHxlKlA77Fyk38swCexE7H/k3O2qMnrnl32Fmz2i1YLK1m9x+9GLrOfte/Z zm3a5YKOx8nB7AlWYaCWklpk2JSnmtKZ4Bj1yAocUCz/oGPNaQyFEBFaccOYSMEWe/LaHRrVx3mBc UmfrQSitkSpxID+VOFVLO+GUfrUXKXT/CyPatqNz5VHl9yxONt2wgpzjEIbaa35zdkJ8zBdkHMXeL ctMgvfFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNcIz-00GdOT-2Y; Thu, 02 Feb 2023 16:19:22 +0000 Received: from mailout-taastrup.gigahost.dk ([46.183.139.199]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNcIs-00GdKs-3u; Thu, 02 Feb 2023 16:19:15 +0000 Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id C5A801883528; Thu, 2 Feb 2023 16:19:07 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id BABFF250007B; Thu, 2 Feb 2023 16:19:07 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id B0E8191201E4; Thu, 2 Feb 2023 16:19:07 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Thu, 02 Feb 2023 17:19:07 +0100 From: netdev@kapio-technology.com To: Ido Schimmel Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , "maintainer:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER" , Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , =?UTF-8?Q?Cl=C3=A9m?= =?UTF-8?Q?ent_L=C3=A9ger?= , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Russell King , Christian Marangi , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER" , "moderated list:ETHERNET BRIDGE" Subject: Re: [PATCH net-next 0/5] ATU and FDB synchronization on locked ports In-Reply-To: References: <20230130173429.3577450-1-netdev@kapio-technology.com> User-Agent: Gigahost Webmail Message-ID: <3cecf4425b0e6f38646e25e40fd8f0fd@kapio-technology.com> X-Sender: netdev@kapio-technology.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230202_081914_362159_540FB9EF X-CRM114-Status: GOOD ( 16.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023-02-02 16:43, Ido Schimmel wrote: > On Thu, Feb 02, 2023 at 08:37:08AM +0100, netdev@kapio-technology.com > wrote: >> On 2023-01-31 20:25, Ido Schimmel wrote: >> > >> > Will try to review tomorrow, but it looks like this set is missing >> > selftests. What about extending bridge_locked_port.sh? >> >> I knew you would take this up. :-) >> But I am not sure that it's so easy to have selftests here as it is >> timing >> based and it would take the 5+ minutes just waiting to test in the >> stadard >> case, and there is opnly support for mv88e6xxx driver with this patch >> set. > > The ageing time is configurable: See commit 081197591769 ("selftests: > net: bridge: Parameterize ageing timeout"). Please add test cases in > the > next version. When I was looking at configuring the ageing time last time, my finding was that the ageing time could not be set very low as there was some part in the DSA layer etc, and confusion wrt units. I think the minimum secured was like around 2 min. (not validated), which is not that much of an improvement for fast testing. If you know what would be a good low timeout to set, I would like to know. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 08BAD60B65 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org F1DB960B50 MIME-Version: 1.0 Date: Thu, 02 Feb 2023 17:19:07 +0100 From: netdev@kapio-technology.com In-Reply-To: References: <20230130173429.3577450-1-netdev@kapio-technology.com> Message-ID: <3cecf4425b0e6f38646e25e40fd8f0fd@kapio-technology.com> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH net-next 0/5] ATU and FDB synchronization on locked ports List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ido Schimmel Cc: Andrew Lunn , Alexandre Belloni , Nikolay Aleksandrov , Kurt Kanzenbach , Eric Dumazet , Ivan Vecera , Florian Fainelli , "moderated list:ETHERNET BRIDGE" , Russell King , Roopa Prabhu , kuba@kernel.org, Paolo Abeni , =?UTF-8?Q?Cl=C3=A9m?= =?UTF-8?Q?ent_L=C3=A9ger?= , Christian Marangi , Woojung Huh , Landen Chao , Jiri Pirko , Hauke Mehrtens , Sean Wang , DENG Qingfang , Claudiu Manoil , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , netdev@vger.kernel.org, open list , "maintainer:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER" , "open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER" , Vladimir Oltean , davem@davemloft.net On 2023-02-02 16:43, Ido Schimmel wrote: > On Thu, Feb 02, 2023 at 08:37:08AM +0100, netdev@kapio-technology.com > wrote: >> On 2023-01-31 20:25, Ido Schimmel wrote: >> > >> > Will try to review tomorrow, but it looks like this set is missing >> > selftests. What about extending bridge_locked_port.sh? >> >> I knew you would take this up. :-) >> But I am not sure that it's so easy to have selftests here as it is >> timing >> based and it would take the 5+ minutes just waiting to test in the >> stadard >> case, and there is opnly support for mv88e6xxx driver with this patch >> set. > > The ageing time is configurable: See commit 081197591769 ("selftests: > net: bridge: Parameterize ageing timeout"). Please add test cases in > the > next version. When I was looking at configuring the ageing time last time, my finding was that the ageing time could not be set very low as there was some part in the DSA layer etc, and confusion wrt units. I think the minimum secured was like around 2 min. (not validated), which is not that much of an improvement for fast testing. If you know what would be a good low timeout to set, I would like to know.