From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D888DC433E0 for ; Fri, 5 Mar 2021 10:11:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A698E64F5B for ; Fri, 5 Mar 2021 10:11:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229997AbhCEKK7 (ORCPT ); Fri, 5 Mar 2021 05:10:59 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:49536 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbhCEKKy (ORCPT ); Fri, 5 Mar 2021 05:10:54 -0500 Received: from mail-wm1-f69.google.com ([209.85.128.69]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lI7Q5-0005wG-79 for kernel-janitors@vger.kernel.org; Fri, 05 Mar 2021 10:10:53 +0000 Received: by mail-wm1-f69.google.com with SMTP id n25so572822wmk.1 for ; Fri, 05 Mar 2021 02:10:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Dc1X7XD8sIPk/f9CtULIHpjeF451ceoNr0To1nwZ7Rk=; b=derJm2cno3SFP+sR1a6lZB+UNEgTQbYd35FMIaomm3mpws6RnZX9t/r/sF/gcdlVXc Wa6JgnhGGwB3U9YCvy2CHCNk8WWrwbaOftkX6ccZogMzAr5omnzT68xa6YCXqb/kAN6F drQ64i1ztmUOGez5wIEeZmq1dw5uwIfaihpkdqUymomXVCS8zAmtW3MniMQy2b4cYW/q YgPeCsOzoN/Jr9Apt7gZj2KFJwwdDz65vUuVUc+GcFl3hi236pSsd3xR4eSZqEgdnTdg iCPOZy3dIdDXQF2+J9601BHBQbsbKNpfcHe/AflkcPA8oN7ZChqI3chK7f5jOrJoX6RX DTOw== X-Gm-Message-State: AOAM532XlFfuqPHvAaLsl2qJThpM64T+TaO32zTeSZMed0DYupYsFIQw ktyNBpzG+ilAqGAQF5mV4v8ajDNYmQD54mvHpmny6ZKHgVAVEzXSB915m2b9Ub0vOZsMtdWq5eN wgK3B6pwRRnegYZF0Ue0HwrsEjF9/8tm2mKwEaI4jbUpTVg== X-Received: by 2002:a1c:7312:: with SMTP id d18mr8029188wmb.155.1614939053018; Fri, 05 Mar 2021 02:10:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJxJTFUqM4RWURTdZMPFSaLPGO6A85/2AN+p8IFVvZ8Jnf1yZlTvGqR63lFecZvTKp5HVZ2Rlg== X-Received: by 2002:a1c:7312:: with SMTP id d18mr8029170wmb.155.1614939052859; Fri, 05 Mar 2021 02:10:52 -0800 (PST) Received: from [192.168.1.116] (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.gmail.com with ESMTPSA id o14sm3527991wri.48.2021.03.05.02.10.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Mar 2021 02:10:52 -0800 (PST) Subject: Re: [PATCH -next] USB: gadget: udc: s3c2410_udc: fix return value check in s3c2410_udc_probe() To: 'Wei Yongjun , Felipe Balbi , Greg Kroah-Hartman , Nathan Chancellor , Nick Desaulniers , "Gustavo A. R. Silva" , Arnd Bergmann Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, kernel-janitors@vger.kernel.org, Hulk Robot References: <20210305034927.3232386-1-weiyongjun1@huawei.com> From: Krzysztof Kozlowski Message-ID: <3cf7abbf-0dc8-495f-4737-2d84bbea8158@canonical.com> Date: Fri, 5 Mar 2021 11:10:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210305034927.3232386-1-weiyongjun1@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On 05/03/2021 04:49, 'Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function devm_platform_ioremap_resource() > returns ERR_PTR() and never returns NULL. The NULL test in the > return value check should be replaced with IS_ERR(). > > Fixes: 188db4435ac6 ("usb: gadget: s3c: use platform resources") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1BFBC433E0 for ; Fri, 5 Mar 2021 10:13:17 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 480EB64F6E for ; Fri, 5 Mar 2021 10:13:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 480EB64F6E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/wGwyuHbitiOm3U7jX9wOkbEAusYnwFoTt50ve9Q5P4=; b=RSV6TZMxCtNcR25Ic3vDxjouB oDtiOVgnHXHl1tYfZwH9KOp8XFYIEOGS9O/4tHEgSYonArYJd4Bpm4KbmbJTQlEF8h8tzQKjD1N+z Vx6aB2SZhbI4m0Lmg0Ug0uQovDCwEA3XJOpdm6swVKyoeOBRIRoHt5m2M7OrR62yUXim3NAFOapZY FqUtH9Sq9V2kNo9n2bj7NrK1zom+nDI98DNT5vtRXJOw2LEd8EkbbeB7sSsIbJuubRVthI1npsjfR OyTqxcopzXZUnejS/MTFFp7FZzB7k2MqdFeVANvsllpkOMAYaB2dsjxjRMNyH3Up1l88IbPL3AJIi dLn4LXx2g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lI7QF-00ET6R-Pd; Fri, 05 Mar 2021 10:11:07 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lI7Q5-00ET0j-NN for linux-arm-kernel@lists.infradead.org; Fri, 05 Mar 2021 10:10:56 +0000 Received: from mail-wm1-f69.google.com ([209.85.128.69]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lI7Q5-0005wH-7C for linux-arm-kernel@lists.infradead.org; Fri, 05 Mar 2021 10:10:53 +0000 Received: by mail-wm1-f69.google.com with SMTP id f9so573256wml.0 for ; Fri, 05 Mar 2021 02:10:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Dc1X7XD8sIPk/f9CtULIHpjeF451ceoNr0To1nwZ7Rk=; b=l84NPUK5C+3XgE7BlWJn277+YqIX+jFBgJqAeyVNS3bvuxcPelbVN93kV1ZjlkQ9sV Nd3aWZUzDCVfmedQguft0Bb2FN6l6W3P/jDVwHGs2LWhN15r9jEt8HsqCcOcwA1kBbTz j9pWrN5E/vLCRHyyWcGHWyc6uxRFyt7a6IZWiFBqhvn53T5l6DsdTkwMcc3fGByv2QkG U1z37K+ptalOgPhC/DTxau4ad33ryQRgvcX8+Og17DmQbm6oTCb7vC7Nv+izKwsx8UND VsRTf8JgBWI91DDyNMGFORBDBf74nh9cDsqz+TY3DpH6JnuhRcZ4lHRdbr0iEo2qQwPq spOQ== X-Gm-Message-State: AOAM532i9hWUvpkpvH0+7lNin7TuVkk147taGNmSgp7oGPp4dZCyNcL/ fvpx6FINT92bSBBT38xJ14lyq5GLfJPUYSELt5VB+JLutRJansFjR0HkPAh7mXYpIg121TUBkrM ae4GLYWRuaF8rUpYOI0vWshmqcXsI9NDgc60zM4wUAXbmCYJq1jau X-Received: by 2002:a1c:7312:: with SMTP id d18mr8029186wmb.155.1614939053017; Fri, 05 Mar 2021 02:10:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJxJTFUqM4RWURTdZMPFSaLPGO6A85/2AN+p8IFVvZ8Jnf1yZlTvGqR63lFecZvTKp5HVZ2Rlg== X-Received: by 2002:a1c:7312:: with SMTP id d18mr8029170wmb.155.1614939052859; Fri, 05 Mar 2021 02:10:52 -0800 (PST) Received: from [192.168.1.116] (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.gmail.com with ESMTPSA id o14sm3527991wri.48.2021.03.05.02.10.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Mar 2021 02:10:52 -0800 (PST) Subject: Re: [PATCH -next] USB: gadget: udc: s3c2410_udc: fix return value check in s3c2410_udc_probe() To: 'Wei Yongjun , Felipe Balbi , Greg Kroah-Hartman , Nathan Chancellor , Nick Desaulniers , "Gustavo A. R. Silva" , Arnd Bergmann Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, kernel-janitors@vger.kernel.org, Hulk Robot References: <20210305034927.3232386-1-weiyongjun1@huawei.com> From: Krzysztof Kozlowski Message-ID: <3cf7abbf-0dc8-495f-4737-2d84bbea8158@canonical.com> Date: Fri, 5 Mar 2021 11:10:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210305034927.3232386-1-weiyongjun1@huawei.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210305_101054_707124_3BE4A94C X-CRM114-Status: GOOD ( 13.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/03/2021 04:49, 'Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function devm_platform_ioremap_resource() > returns ERR_PTR() and never returns NULL. The NULL test in the > return value check should be replaced with IS_ERR(). > > Fixes: 188db4435ac6 ("usb: gadget: s3c: use platform resources") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel