From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FD0FC06511 for ; Mon, 1 Jul 2019 10:03:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 711CD20881 for ; Mon, 1 Jul 2019 10:03:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 711CD20881 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0983A6B0006; Mon, 1 Jul 2019 06:03:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 047DF8E0003; Mon, 1 Jul 2019 06:03:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E53CF8E0002; Mon, 1 Jul 2019 06:03:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-ed1-f80.google.com (mail-ed1-f80.google.com [209.85.208.80]) by kanga.kvack.org (Postfix) with ESMTP id 9AF076B0006 for ; Mon, 1 Jul 2019 06:03:57 -0400 (EDT) Received: by mail-ed1-f80.google.com with SMTP id k15so16486689eda.6 for ; Mon, 01 Jul 2019 03:03:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:subject:to:cc :references:from:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=K0mgmTcmYXP8qDylUGCEGeIJ5ZlkkY6bcSPbLKy0oAQ=; b=tgDoVVRnu6+3OnnPa8FcqA5gIPeDVNmdUmQFuywl3NC+JKkDu6KudvE4WCBs3ZkCPc WYIVYxw9NSWw1U8VKCxVARutRDiFm/DtDqLMO8nW+DuMrypvDS7qNekKYOTuqAlwnZvd cgG22WZdmSKfxrVAlL/07gQl+TsYslkjNu6SyJapIO3CW7Bsu8Dohs7TwnciLMc9aS6e gAoefhg4c7o4IR+ksmrJV1R2CQik0p59BIdhTgWfQzL7DNc5oWhsewl/jhgzaUlPoOBH fSlKQF+1IMyxu2muaZUoPN8ohIwv+8jhfS8Z9fDD7NwhlXMvbk2jsjczKTexzjVfyYsQ fDNQ== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of steven.price@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=steven.price@arm.com X-Gm-Message-State: APjAAAWhhu/97nvzJIUF4ReFDx5mRUDcxoGVhgtNxhHcLDI7KVLHNMfw cgxrhLiG86P27pbTXz6vvVJ+1BzovbB96pqDfTV/YgLdxexZ09bUx1dnrY6GMc0WG5/Ax2SPw3W o9AMrCZ1ZbBlgZJUtOcz6tPQjq1XHK+MJE9xhGkjZPhFnq2HiWIGm2N8vueP0g+I8pA== X-Received: by 2002:a05:6402:1801:: with SMTP id g1mr27619780edy.262.1561975437212; Mon, 01 Jul 2019 03:03:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqyL2mwN5mhWaA8cZT4vOstMj39mYprkvc7uzA5G2M3eiw0BSKh2xLYf14Ynr7X3ezpRncyL X-Received: by 2002:a05:6402:1801:: with SMTP id g1mr27619703edy.262.1561975436516; Mon, 01 Jul 2019 03:03:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561975436; cv=none; d=google.com; s=arc-20160816; b=b2UXngytmLoKmlXkGxxbnZAgb1if4YQfN+mU/zWbZFfPSMNkBNI7ezgRoPaa5cT/Z2 4RNrML6cZbHu+kxy/Mb9ClBOdx4+dkxmOIpC1JuaV2Bdyu73Zql0Kot9M8xHwT/7/2e2 5HSE3E+BqulHnFscMg/v8O0VPeSG/zG4X3tZy0oODdo0+3fnBMJBHFzkvTQHHZdagpsW tbvt/MbUgfN2eNo2mTjsePY6+MfWblhKWFjAQq6WcSFhEi3jTJp9gncj9ldmkuHMUW5j ulXAoYP4nMQjM/yRwROhL3cENQ2aK3234xM1SBk+2bRN36Fqn0mkghEk3d/S1MBRzKc4 4Gyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=K0mgmTcmYXP8qDylUGCEGeIJ5ZlkkY6bcSPbLKy0oAQ=; b=WEJLoZcJyhBu20HyOcr4msYYRu+FYbELYQ6zzrFB3+uD2cmRjZjJv1WvC2vJcOUlix vSKB6WiKcngjQ8Tja3QnipL+8JNaOafaAkkeRT8gaDvzgQFeHxEkYavJzD6eG8bmJLfX LQTMeIbZwFGJX/53Me1Uf9jtRJKAuy+AdJdRAiZEbrzmgYa8YCVt6jcoPvH01SmrWTsW /nkp3y3wv86MLzaPO6s0POmo91yUMe214WUf/DWqTz0XAHGrT1hgXi+qgSOSM5EI+fh1 7XHQ1tur4TiRxeu3RqQub6KGV2UVwFzT2Mu9HDvmCfLxWvkIhR03XjR6aZSSB4BYXRTD M1Jg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of steven.price@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=steven.price@arm.com Received: from foss.arm.com (foss.arm.com. [217.140.110.172]) by mx.google.com with ESMTP id k15si4504228edd.268.2019.07.01.03.03.56 for ; Mon, 01 Jul 2019 03:03:56 -0700 (PDT) Received-SPF: pass (google.com: domain of steven.price@arm.com designates 217.140.110.172 as permitted sender) client-ip=217.140.110.172; Authentication-Results: mx.google.com; spf=pass (google.com: domain of steven.price@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=steven.price@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8F1772B; Mon, 1 Jul 2019 03:03:55 -0700 (PDT) Received: from [10.1.196.133] (e112269-lin.cambridge.arm.com [10.1.196.133]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0B4143F718; Mon, 1 Jul 2019 03:03:52 -0700 (PDT) Subject: Re: Re: [PATCH 1/3] arm64: mm: Add p?d_large() definitions To: Will Deacon , Nicholas Piggin Cc: linux-mm@kvack.org, Christophe Leroy , Mark Rutland , Anshuman Khandual , Catalin Marinas , Ard Biesheuvel , Will Deacon , Andrew Morton , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org References: <20190623094446.28722-1-npiggin@gmail.com> <20190623094446.28722-2-npiggin@gmail.com> <20190701092756.s4u5rdjr7gazvu66@willie-the-truck> From: Steven Price Message-ID: <3d002af8-d8cd-f750-132e-12109e1e3039@arm.com> Date: Mon, 1 Jul 2019 11:03:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190701092756.s4u5rdjr7gazvu66@willie-the-truck> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01/07/2019 10:27, Will Deacon wrote: > Hi Nick, > > On Sun, Jun 23, 2019 at 07:44:44PM +1000, Nicholas Piggin wrote: >> walk_page_range() is going to be allowed to walk page tables other than >> those of user space. For this it needs to know when it has reached a >> 'leaf' entry in the page tables. This information will be provided by the >> p?d_large() functions/macros. > > I can't remember whether or not I asked this before, but why not call > this macro p?d_leaf() if that's what it's identifying? "Large" and "huge" > are usually synonymous, so I find this naming needlessly confusing based > on this patch in isolation. Hi Will, You replied to my posting of this patch before[1], to which you said: > I've have thought p?d_leaf() might match better with your description > above, but I'm not going to quibble on naming. Have you changed your mind about quibbling? ;) Steve [1] https://lore.kernel.org/lkml/20190611153650.GB4324@fuggles.cambridge.arm.com/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFCFDC06510 for ; Mon, 1 Jul 2019 10:05:33 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B3B22133D for ; Mon, 1 Jul 2019 10:05:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B3B22133D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45cjfy53M0zDqC5 for ; Mon, 1 Jul 2019 20:05:30 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=arm.com (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=steven.price@arm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=arm.com Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lists.ozlabs.org (Postfix) with ESMTP id 45cjdB595TzDqBm for ; Mon, 1 Jul 2019 20:03:57 +1000 (AEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8F1772B; Mon, 1 Jul 2019 03:03:55 -0700 (PDT) Received: from [10.1.196.133] (e112269-lin.cambridge.arm.com [10.1.196.133]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0B4143F718; Mon, 1 Jul 2019 03:03:52 -0700 (PDT) Subject: Re: Re: [PATCH 1/3] arm64: mm: Add p?d_large() definitions To: Will Deacon , Nicholas Piggin References: <20190623094446.28722-1-npiggin@gmail.com> <20190623094446.28722-2-npiggin@gmail.com> <20190701092756.s4u5rdjr7gazvu66@willie-the-truck> From: Steven Price Message-ID: <3d002af8-d8cd-f750-132e-12109e1e3039@arm.com> Date: Mon, 1 Jul 2019 11:03:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190701092756.s4u5rdjr7gazvu66@willie-the-truck> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Ard Biesheuvel , Catalin Marinas , Anshuman Khandual , Will Deacon , linux-mm@kvack.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 01/07/2019 10:27, Will Deacon wrote: > Hi Nick, > > On Sun, Jun 23, 2019 at 07:44:44PM +1000, Nicholas Piggin wrote: >> walk_page_range() is going to be allowed to walk page tables other than >> those of user space. For this it needs to know when it has reached a >> 'leaf' entry in the page tables. This information will be provided by the >> p?d_large() functions/macros. > > I can't remember whether or not I asked this before, but why not call > this macro p?d_leaf() if that's what it's identifying? "Large" and "huge" > are usually synonymous, so I find this naming needlessly confusing based > on this patch in isolation. Hi Will, You replied to my posting of this patch before[1], to which you said: > I've have thought p?d_leaf() might match better with your description > above, but I'm not going to quibble on naming. Have you changed your mind about quibbling? ;) Steve [1] https://lore.kernel.org/lkml/20190611153650.GB4324@fuggles.cambridge.arm.com/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B8E2C0650E for ; Mon, 1 Jul 2019 10:03:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74F462133D for ; Mon, 1 Jul 2019 10:03:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LSdQxe0N" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74F462133D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SYcX2XODOqtRnY3C7As90GBDIfHOxATDVBwqmVMG5UM=; b=LSdQxe0NaIKXtc 5ZD9p7YL81t9H37xNnnUWJtczZcV9wRlsYD+4Kxcif9+fKCet0u2GP4MZ/RCwMQDVAK7ZTxmN4Emx LWuXmiIZjAdROa60eVNfVvlSB3e56YyodV0bV159pMMiJP0IqIJ1n66u66d/qDSCwmVTItSUfRR36 kzmcyE5Hx3Hh4ll4up/tRcM8WUwSTpR6VaG33PYO1XogiBjUkPgfGQABXYGQ0afobOsuEzqsZ3a35 WLdYpeCqMN0sHZIHGqoJAp2+PI2hL1GA9mBTlz1GI/ylUSzFAFNtw6+n6zgKllz8GqgKFvpPVS7Nf J6cjtYJNnkiC2DeS/LnA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hhtAE-0005Ec-JH; Mon, 01 Jul 2019 10:03:58 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hhtAC-0005EC-AI for linux-arm-kernel@lists.infradead.org; Mon, 01 Jul 2019 10:03:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8F1772B; Mon, 1 Jul 2019 03:03:55 -0700 (PDT) Received: from [10.1.196.133] (e112269-lin.cambridge.arm.com [10.1.196.133]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0B4143F718; Mon, 1 Jul 2019 03:03:52 -0700 (PDT) Subject: Re: Re: [PATCH 1/3] arm64: mm: Add p?d_large() definitions To: Will Deacon , Nicholas Piggin References: <20190623094446.28722-1-npiggin@gmail.com> <20190623094446.28722-2-npiggin@gmail.com> <20190701092756.s4u5rdjr7gazvu66@willie-the-truck> From: Steven Price Message-ID: <3d002af8-d8cd-f750-132e-12109e1e3039@arm.com> Date: Mon, 1 Jul 2019 11:03:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190701092756.s4u5rdjr7gazvu66@willie-the-truck> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190701_030356_402890_F4334B7E X-CRM114-Status: GOOD ( 15.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christophe Leroy , Mark Rutland , Ard Biesheuvel , Catalin Marinas , Anshuman Khandual , Will Deacon , linux-mm@kvack.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/07/2019 10:27, Will Deacon wrote: > Hi Nick, > > On Sun, Jun 23, 2019 at 07:44:44PM +1000, Nicholas Piggin wrote: >> walk_page_range() is going to be allowed to walk page tables other than >> those of user space. For this it needs to know when it has reached a >> 'leaf' entry in the page tables. This information will be provided by the >> p?d_large() functions/macros. > > I can't remember whether or not I asked this before, but why not call > this macro p?d_leaf() if that's what it's identifying? "Large" and "huge" > are usually synonymous, so I find this naming needlessly confusing based > on this patch in isolation. Hi Will, You replied to my posting of this patch before[1], to which you said: > I've have thought p?d_leaf() might match better with your description > above, but I'm not going to quibble on naming. Have you changed your mind about quibbling? ;) Steve [1] https://lore.kernel.org/lkml/20190611153650.GB4324@fuggles.cambridge.arm.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel