From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38692)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1bjoXg-0008UW-Dr
	for qemu-devel@nongnu.org; Tue, 13 Sep 2016 10:18:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1bjoXZ-0006wS-Gg
	for qemu-devel@nongnu.org; Tue, 13 Sep 2016 10:18:31 -0400
Received: from mail-wm0-f68.google.com ([74.125.82.68]:34955)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1bjoXZ-0006w4-Ad
	for qemu-devel@nongnu.org; Tue, 13 Sep 2016 10:18:25 -0400
Received: by mail-wm0-f68.google.com with SMTP id c131so3203235wmh.2
	for <qemu-devel@nongnu.org>; Tue, 13 Sep 2016 07:18:25 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1472496380-19706-1-git-send-email-rth@twiddle.net>
	<1472496380-19706-8-git-send-email-rth@twiddle.net>
	<56a3caa7-d870-dc12-77a8-272443df528c@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <3d12326f-61df-e00e-0793-89882962927f@redhat.com>
Date: Tue, 13 Sep 2016 16:17:21 +0200
MIME-Version: 1.0
In-Reply-To: <56a3caa7-d870-dc12-77a8-272443df528c@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 7/9] cutils: Rewrite x86 buffer zero
 checking
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: vijay.kilari@gmail.com



On 13/09/2016 15:26, Paolo Bonzini wrote:
> I need this on top to fix compilation with older compilers:
> 
> diff --git a/util/bufferiszero.c b/util/bufferiszero.c
> index 3b39f82..1ce6b7a 100644
> --- a/util/bufferiszero.c
> +++ b/util/bufferiszero.c
> @@ -71,13 +71,13 @@ buffer_zero_int(const void *buf, size_t len)
> 
>  #if defined(CONFIG_AVX2_OPT) || defined(__SSE2__)
>  #include <cpuid.h>
> -#include <x86intrin.h>
> 
>  /* Note that we're going to check for LEN >= 64 for all of these.  */
> 
>  #ifdef CONFIG_AVX2_OPT
>  #pragma GCC push_options
>  #pragma GCC target("avx2")
> +#include <immintrin.h>
> 
>  static bool
>  buffer_zero_avx2(const void *buf, size_t len)
> @@ -181,6 +181,8 @@ buffer_zero_sse4(const void *buf, size_t len)
>  #pragma GCC target("sse2")
>  #endif /* CONFIG_AVX2_OPT */
> 
> +#include <emmintrin.h>
> +
>  static bool
>  buffer_zero_sse2(const void *buf, size_t len)
>  {
> 

Nope, not enough on GCC 4.8:

$ nm util/bufferiszero.o
0000000000000000 b buffer_accel
0000000000000430 T buffer_is_zero
0000000000000240 t buffer_zero_avx
0000000000000330 t buffer_zero_avx2
0000000000000000 t buffer_zero_int
00000000000000b0 t buffer_zero_sse2
0000000000000190 t buffer_zero_sse4
0000000000000008 b cpuid_cache
                 U _GLOBAL_OFFSET_TABLE_
0000000000000000 t init_cpuid_cache
                 U _mm_cmpeq_epi8
                 U _mm_loadu_si128
                 U _mm_movemask_epi8
                 U _mm_setzero_si128
                 U _mm_testz_si128
00000000000003d0 T test_buffer_is_zero_next_accel

Since I have no idea what's going on, I'm dropping these the last three
patches.

Paolo