From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Karel Balej" <balejk@matfyz.cz>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Markuss Broks" <markuss.broks@gmail.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Duje Mihanović" <duje.mihanovic@skole.hr>,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 2/2] input: Imagis: add support for the IST3032C touchscreen
Date: Thu, 28 Sep 2023 07:25:51 +0200 [thread overview]
Message-ID: <3d15a1a1-d47e-49ad-9491-1ac95f68bc64@linaro.org> (raw)
In-Reply-To: <20230926173531.18715-3-balejk@matfyz.cz>
On 26/09/2023 19:35, Karel Balej wrote:
> The downstream driver sets the regulator voltage to 3.1 V. Without this,
> the touchscreen generates random touches even after it is no longer
> being touched. It is unknown whether the same problem appears with other
> chips of the IST30**C series.
>
> Co-developed-by: Duje Mihanović <duje.mihanovic@skole.hr>
> Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
> Signed-off-by: Karel Balej <balejk@matfyz.cz>
> ---
> .../bindings/input/touchscreen/imagis,ist30xxc.yaml | 1 +
Bindings are always separate patches. Always.
Please run scripts/checkpatch.pl and fix reported warnings. Some
warnings can be ignored, but the code here looks like it needs a fix.
Feel free to get in touch if the warning is not clear.
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-28 5:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 17:35 [PATCH 0/2] input: Imagis: add support for the IST3032C touchscreen Karel Balej
2023-09-26 17:35 ` [PATCH 1/2] input: generalize the Imagis touchscreen driver Karel Balej
2023-09-26 22:17 ` Conor Dooley
2023-09-27 1:48 ` Jeff LaBundy
2023-09-26 17:35 ` [PATCH 2/2] input: Imagis: add support for the IST3032C touchscreen Karel Balej
2023-09-27 1:40 ` Jeff LaBundy
2023-09-28 17:56 ` Karel Balej
2023-10-22 17:17 ` Jeff LaBundy
2023-09-28 5:25 ` Krzysztof Kozlowski [this message]
2023-09-26 22:16 ` [PATCH 0/2] " Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d15a1a1-d47e-49ad-9491-1ac95f68bc64@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=balejk@matfyz.cz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=duje.mihanovic@skole.hr \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markuss.broks@gmail.com \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.