From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamal Hadi Salim Subject: Re: [Patch net] net_sched: refetch skb protocol for each filter Date: Tue, 15 Jan 2019 10:14:27 -0500 Message-ID: <3d1b21a5-e2fe-572b-be99-2c74409a7290@mojatatu.com> References: <20190112025542.397-1-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Linux Kernel Network Developers , Martin Olsson , Jiri Pirko , Lucas Bates To: Cong Wang Return-path: Received: from mail-io1-f67.google.com ([209.85.166.67]:43427 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726077AbfAOPOa (ORCPT ); Tue, 15 Jan 2019 10:14:30 -0500 Received: by mail-io1-f67.google.com with SMTP id b23so2285691ios.10 for ; Tue, 15 Jan 2019 07:14:29 -0800 (PST) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 2019-01-13 3:58 p.m., Cong Wang wrote: > On Sat, Jan 12, 2019 at 4:23 AM Jamal Hadi Salim wrote: >> Cong, >> I am a little worried about the impact of this change. Smells >> more like it has to do with Vlan action or related issues >> than with reclassifying. > > You can verify this patch with Martin's test case. I verified it > with the script below, it works as expected. > Your script is slightly different from his. Probably doesnt matter in the bigger picture - but lets give Lucas a chance to test. So a ping from test1->test2 should be sufficient here, yes? cheers, jamal