From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C27CCC3DA7D for ; Tue, 3 Jan 2023 11:02:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 593838519D; Tue, 3 Jan 2023 12:02:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=monstr.eu Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=monstr-eu.20210112.gappssmtp.com header.i=@monstr-eu.20210112.gappssmtp.com header.b="04gHKayB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 14AC985309; Tue, 3 Jan 2023 12:02:52 +0100 (CET) Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 93A41835AE for ; Tue, 3 Jan 2023 12:02:48 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=monstr.eu Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=monstr@monstr.eu Received: by mail-wr1-x429.google.com with SMTP id d4so21048008wrw.6 for ; Tue, 03 Jan 2023 03:02:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=L19/lFDUnctsZnCBjrwM+8jyfda1bZDnwmwVlN2hYzU=; b=04gHKayBOdzWEctsfpglRB6ygty6dxyIz6Y7DUXTv8hWLhmOQ67mbXc81Zg0VdoOCp oP5kmAqvIP5PhOcj87c3xjTgSFc5Ph1eiNiTFAXCuu69eXRUhgMe1eb99lTu7ZwhJolZ B+xfS7JjTqhp0S9CQu71ztmpgaCnrIjUEsLpJPE9qj0ZQ4ojfl2ebmaQF4AJzU0JWHt+ Vgi0O/qjBGznIRF7KhK5K/6jr7yVwSHjKD6aL2jkiboLCCyNiCtWyh41GlPOR6FIFvXh P/vP7NEFm9LMnb8PTHlEawux4QlYnz+2lcnzKSnLJl4U/PlIsVJpqDZ07FKNypkd22Ox 9WbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L19/lFDUnctsZnCBjrwM+8jyfda1bZDnwmwVlN2hYzU=; b=JZzt7or0G831sfBh8sa3gqwzr8DjO9NQaxBZtjMc4nDyk71BpaWrcbMeF3EBSBB5Z4 v8j+jbaLNh4KcCJV2gm+q9sba4jsWm7wj34qpn0VCMKPL/k3/wREDGPEI0oQkr8X+g15 p/sGE+JjGXFjRDCm7kQjo/2pl7eyanR/eBFwfyj+B8SwtiPwfkI1OPXTenLFjsi0EjBt io3rTrHEYglMhaZq2FLYIBZNPYMWaWaMbC23wC/B3WeZZoEB/CLizT2ic9rjv0MEE4Wy M7iEVks7QedlszXi/VYmPy0691yUuxBDOhureC7n6TBziMd4dVPg71qYhEEE3AdOKCId ZAIw== X-Gm-Message-State: AFqh2kqzoGbX/iiHQn+qKPwH3oUjBdfxvNzwk73esVaF/4l3TV58HuvL y2rloD0WcVH7KcyP0iJ3LsvaEw== X-Google-Smtp-Source: AMrXdXsdTAOKGXH9QgiFDtRDvbMooxjWvnklf0kgK4HVIHE7fZuT2svRFL/+hYaQJu179P8z1ZDyRQ== X-Received: by 2002:adf:cc85:0:b0:290:8144:60b4 with SMTP id p5-20020adfcc85000000b00290814460b4mr7776076wrj.64.1672743768105; Tue, 03 Jan 2023 03:02:48 -0800 (PST) Received: from [192.168.0.105] (nat-35.starnet.cz. [178.255.168.35]) by smtp.gmail.com with ESMTPSA id m16-20020adffe50000000b00241bd7a7165sm34373958wrs.82.2023.01.03.03.02.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jan 2023 03:02:47 -0800 (PST) Message-ID: <3d2a5e8b-0c35-b516-374c-61aabb326f5a@monstr.eu> Date: Tue, 3 Jan 2023 12:02:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 0/4] Enable gigadevice and add new part #s Content-Language: en-US To: Victor Lim , u-boot@lists.denx.de Cc: vigneshr@ti.com, jagan@amarulasolutions.com, michal.simek@xilinx.com, vikhyat.goyal@amd.com, ashok.reddy.soma@amd.com References: <20221219224818.6801-1-vlim@gigadevice.com> From: Michal Simek In-Reply-To: <20221219224818.6801-1-vlim@gigadevice.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 12/19/22 23:48, Victor Lim wrote: > Enabling gigadevice part #s. > These are the part #s added, > gd25b256: 3V QSPI, QE=1, 256Mbit > gd25b512: 3V QSPI, QE=1, 512Mbit > gd55b01g: 3V QSPI, QE=1, 1Gbit > gd55b02g: 3V QSPI, QE=1, 2Gbit > gd25f64: 3V QSPI, QE=1, 64Mbit, high performance > gd25f128: 3V QSPI, QE=1, 128Mbit, high performance > gd25f256: 3V QSPI, QE=1, 256Mbit, high performance > gd55f512: 3V QSPI, QE=1, 512Mbit, high performance > gd25t512: 3V QSPI, 512Mbit, ultra high performance > gd55t01g: 3V QSPI, 1Gbit, ultra high performance > gd55t02g: 3V QSPI, 2Gbit, ultra high performance > gd25x512: 3V OSPI, 512Mbit, ultra high performance > gd55x01g: 3V OSPI, 1Gbit, ultra high performance > gd55x02g: 3V OSPI, 2Gbit, ultra high performance > gd25lb256: 1.8V QSPI, QE=1, 256Mbit > gd25lb512: 1.8V QSPI, QE=1, 512Mbit > gd55lb01g: 1.8V QSPI, QE=1, 1Gbit > gd55lb02g: 1.8V QSPI, QE=1, 2Gbit > gd25lf64: 1.8V QSPI, QE=1, 64Mbit, high performance > gd25lf128: 1.8V QSPI, QE=1, 128Mbit, high performance > gd25lf256: 1.8V QSPI, QE=1, 256Mbit, high performance > gd55lf512: 1.8V QSPI, QE=1, 512Mbit, high performance > gd25lt512: 1.8V QSPI, 512Mbit, ultra high performance > gd55lt01g: 1.8V QSPI, 1Gbit, ultra high performance > gd55lt02g: 1.8V QSPI, 2Gbit, ultra high performance > gd25lx512: 1.8V OSPI, 512Mbit, ultra high performance > gd55lx01g: 1.8V OSPI, 1Gbit, ultra high performance > gd55lx02g: 1.8V OSPI, 2Gbit, ultra high performance > > This is the link to the datasheet. > https://www.gigadevice.com/products/memory/flash/spi-nor/ > >> Victor Lim (4): > xilinx: zynq: Enable gigadevice > arm64: zynqmp: Enable gigadevice > xilinx: versal: Enable gigadevice parts > mtd: spi-nor-ids: add gigadevice part # > > configs/xilinx_versal_mini_qspi_defconfig | 1 + > configs/xilinx_zynq_virt_defconfig | 1 + > configs/xilinx_zynqmp_mini_qspi_defconfig | 1 + > configs/xilinx_zynqmp_virt_defconfig | 1 + > configs/zynq_cse_qspi_defconfig | 1 + > drivers/mtd/spi/spi-nor-ids.c | 68 +++++++++++++++++++++++ > 6 files changed, 73 insertions(+) > First of all this should be v3 series. Second. When I run this for i in `ls configs/xilinx_*`; do NAME=`basename $i`; echo $NAME; make $NAME; make savedefconfig; cp defconfig $i; done I see that locations your added entries are not correct. Third b4 am -g is showing that base is not upstream version. Please use next branch as base. Definitely this series is better then previous one. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP/Versal ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal/Versal NET SoCs