From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH] drm/fbdev: Make skip_vt_switch the default Date: Wed, 28 Nov 2018 08:17:04 +0100 Message-ID: <3d406677-9d7d-6d8d-85af-1cfb253d1838@linux.intel.com> References: <20181127170952.28507-1-daniel.vetter@ffwll.ch> <20181127173424.301-1-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181127173424.301-1-daniel.vetter@ffwll.ch> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Intel Graphics Development Cc: =?UTF-8?Q?Heiko_St=c3=bcbner?= , Maxime Ripard , nouveau@lists.freedesktop.org, DRI Development , Huang Rui , Daniel Vetter , linux-rockchip@lists.infradead.org, David Airlie , Ben Skeggs , Daniel Stone , =?UTF-8?Q?Michel_D=c3=a4nzer?= , Rodrigo Vivi , Junwei Zhang , linux-arm-kernel@lists.infradead.org, =?UTF-8?Q?Michel_D=c3=a4nzer?= , Sandy Huang , Samuel Li , Shirish S , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= List-Id: nouveau.vger.kernel.org T3AgMjctMTEtMTggb20gMTg6MzQgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+IEtNUyBkcml2ZXJz IHJlYWxseSBzaG91bGQgYWxsIGJlIGFibGUgdG8gcmVzdG9yZSB0aGVpciBkaXNwbGF5IHN0YXRl Cj4gb24gcmVzdW1lIHdpdGhvdXQgZmJjb24gaGVscGluZyBvdXQuIFNvIG1ha2UgdGhpcyB0aGUg ZGVmYXVsdC4KPgo+IFNpbmNlIEknbSBub3QgZW50aXJlbHkgZm9vbGlzaCwgbWFrZSBpdCBvbmx5 IGEgZGVmYXVsdCwgd2hpY2ggZHJpdmVycwo+IGNhbiBzdGlsbCBvdmVycmlkZS4gVGhhdCB3YXkg d2hlbiB0aGUgaW5ldml0YWJsZSByZWdyZXNzaW9uIHJlcG9ydAo+IGhhcHBlbnMgSSBjYW4gZml4 IHRoaW5ncyB1cCB3aXRoIGEgb25lLWxpbmVyIHBsdXMgRklYTUUgY29tbWVudCB0aGF0Cj4gc29t ZW9uZSBzaG91bGQgZml4IHVwIHRoZSBzdXNwZW5kL3Jlc3VtZSBjb2RlIGluIHRoYXQgZHJpdmVy Lgo+Cj4gQnV0IGF0IGxlYXN0IGFsbCBuZXcgZHJpdmVycyB3b24ndCBiZSBicm9rZW4gYnkgYWNj aWRlbnQgYXMgc29vbiBhcwo+IHlvdSB0dXJuIG9mZiBmYmNvbiBiZWNhdXNlICJzdXNwZW5kL3Jl c3VtZSB3b3JrZWQgd2hlbiBJIHRlc3RlZCBpdCIuCj4KPiB2MjogS2VlcCB0aGlzIGZvciByYWRl b24gYmVjYXVzZSBvZgo+Cj4gY29tbWl0IDE4YzQzN2NhYTViMThhMjM1ZGQ2NWNlYzIyNGVhYjU0 YmViY2VlNjUKPiBBdXRob3I6IEFsZXggRGV1Y2hlciA8YWxleGFuZGVyLmRldWNoZXJAYW1kLmNv bT4KPiBEYXRlOiAgIFR1ZSBOb3YgMTQgMTc6MTk6MjkgMjAxNyAtMDUwMAo+Cj4gICAgIFJldmVy dCAiZHJtL3JhZGVvbjogZG9udCBzd2l0Y2ggdnQgb24gc3VzcGVuZCIKPgo+IFRoYW5rcyB0byBN aWNoZWwgRMOkbnplciBmb3IgcG9pbnRpbmcgdGhpcyBvbmUgb3V0LgoKTWF5YmUganVzdCByZWxv YWQgdGhlIGdhbW1hIGx1dCBvbiByZXN1bWUgZm9yIHJhZGVvbiwgaW5zdGVhZCBvZiByZWx5aW5n IG9uIGZiY29uPwoKT3RoZXJ3aXNlIHBhdGNoIGxvb2tzIHNhbmUsIHdvdWxkIGJlIG5pY2UgaWYg cmFkZW9uIHdhcyBmaXhlZCBpbnN0ZWFkIG9mIHdvcmtlZCBhcm91bmQuCgpSZXZpZXdlZC1ieTog TWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: maarten.lankhorst@linux.intel.com (Maarten Lankhorst) Date: Wed, 28 Nov 2018 08:17:04 +0100 Subject: [PATCH] drm/fbdev: Make skip_vt_switch the default In-Reply-To: <20181127173424.301-1-daniel.vetter@ffwll.ch> References: <20181127170952.28507-1-daniel.vetter@ffwll.ch> <20181127173424.301-1-daniel.vetter@ffwll.ch> Message-ID: <3d406677-9d7d-6d8d-85af-1cfb253d1838@linux.intel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Op 27-11-18 om 18:34 schreef Daniel Vetter: > KMS drivers really should all be able to restore their display state > on resume without fbcon helping out. So make this the default. > > Since I'm not entirely foolish, make it only a default, which drivers > can still override. That way when the inevitable regression report > happens I can fix things up with a one-liner plus FIXME comment that > someone should fix up the suspend/resume code in that driver. > > But at least all new drivers won't be broken by accident as soon as > you turn off fbcon because "suspend/resume worked when I tested it". > > v2: Keep this for radeon because of > > commit 18c437caa5b18a235dd65cec224eab54bebcee65 > Author: Alex Deucher > Date: Tue Nov 14 17:19:29 2017 -0500 > > Revert "drm/radeon: dont switch vt on suspend" > > Thanks to Michel D?nzer for pointing this one out. Maybe just reload the gamma lut on resume for radeon, instead of relying on fbcon? Otherwise patch looks sane, would be nice if radeon was fixed instead of worked around. Reviewed-by: Maarten Lankhorst