From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anoob Joseph <anoob.joseph@caviumnetworks.com>
Subject: Re: [PATCH v3 1/2] examples/ipsec-secgw: fix missing
 ingress flow attribute
Date: Tue, 12 Dec 2017 12:44:23 +0530
Message-ID: <3d409aea-96b7-a963-7ae7-c8eea77dadb1@caviumnetworks.com>
References: <cd13bbdab7f86507e1928805a93c4e5c4491aa6d.1512396570.git.nelio.laranjeiro@6wind.com>
 <89964464de4bf623ba27b88d47af1f1b9e8a64d1.1513000931.git.nelio.laranjeiro@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: anoob.joseph@caviumnetworks.com, dev@dpdk.org, akhil.goyal@nxp.com
To: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
 Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>,
 Radu Nicolau <radu.nicolau@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam03on0075.outbound.protection.outlook.com [104.47.40.75])
 by dpdk.org (Postfix) with ESMTP id 4D09F7D04
 for <dev@dpdk.org>; Tue, 12 Dec 2017 08:14:34 +0100 (CET)
In-Reply-To: <89964464de4bf623ba27b88d47af1f1b9e8a64d1.1513000931.git.nelio.laranjeiro@6wind.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 12/11/2017 07:34 PM, Nelio Laranjeiro wrote:
> Generic flow API have both direction bits, ingress and egress for rules
> which may work on both sides.
>
> Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload")
> Cc: akhil.goyal@nxp.com
>
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> Acked-by: Radu Nicolau <radu.nicolau@intel.com>
Acked-by: Anoob Joseph <anoob.joseph@caviumnetworks.com>
> ---
>   examples/ipsec-secgw/ipsec.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c
> index ec8bf95e1..17bd7620d 100644
> --- a/examples/ipsec-secgw/ipsec.c
> +++ b/examples/ipsec-secgw/ipsec.c
> @@ -205,6 +205,8 @@ create_session(struct ipsec_ctx *ipsec_ctx, struct ipsec_sa *sa)
>   
>   			sa->attr.egress = (sa->direction ==
>   					RTE_SECURITY_IPSEC_SA_DIR_EGRESS);
> +			sa->attr.ingress = (sa->direction ==
> +					RTE_SECURITY_IPSEC_SA_DIR_INGRESS);
>   			sa->flow = rte_flow_create(sa->portid,
>   				&sa->attr, sa->pattern, sa->action, &err);
>   			if (sa->flow == NULL) {