All of
 help / color / mirror / Atom feed
From: Tom Zanussi <>
To: Steven Rostedt <>,
	LKML <>
Cc: Masami Hiramatsu <>,
	Namhyung Kim <>,
	Ingo Molnar <>,
	Andrew Morton <>
Subject: Re: [PATCH v3] tracing/histogram: Rename "cpu" to "common_cpu"
Date: Wed, 21 Jul 2021 15:19:00 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20210721110053.26b4f641@oasis.local.home>

Hi Steve,

On Wed, 2021-07-21 at 11:00 -0400, Steven Rostedt wrote:
> From: "Steven Rostedt (VMware)" <>
> Currently the histogram logic allows the user to write "cpu" in as an
> event field, and it will record the CPU that the event happened on.
> The problem with this is that there's a lot of events that have "cpu"
> as a real field, and using "cpu" as the CPU it ran on, makes it
> impossible to run histograms on the "cpu" field of events.

Yes, you're absolutely right, it should have been named "common_cpu"
from the start, not only for this reason but also just for the sake of

Reviewed-by: Tom Zanussi <>

      reply	other threads:[~2021-07-21 20:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21 15:00 [PATCH v3] tracing/histogram: Rename "cpu" to "common_cpu" Steven Rostedt
2021-07-21 20:19 ` Tom Zanussi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.