From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89DBAC6377A for ; Wed, 21 Jul 2021 20:19:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F02D61246 for ; Wed, 21 Jul 2021 20:19:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236625AbhGUTib (ORCPT ); Wed, 21 Jul 2021 15:38:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:48922 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235319AbhGUTiZ (ORCPT ); Wed, 21 Jul 2021 15:38:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8758861241; Wed, 21 Jul 2021 20:19:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626898742; bh=u96cfduoSRTVMuAHQugLqHPx5JeckJNOWKK7TyCZF+c=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=gQcfcIgEZmVehW5dsWRgeN23J3N+1slY39ZOj+Wgnj7YZulEfki+CCZJIptPfNTxy ofK6V41dAhp7yl78oSrvJizSgECg6u3ZDWaikrld4qs9elulDvuab+aRKJElWEoCEL MVc6/H4JZr3jfjGNoY/ptPl/xPUQwKQ4nx+1ZC24C8g2dEvYUW69l3tFGpWH5RF/6z GiUN0N+oIWPnuNA/tS67qk57vEXt4vemXcycUvGiz+QkScGqt5CiVpXTlr5o84BvG5 2qyPdbdZUjO89CVscXVHXRmMT2xleHhneYoDbcY42pcb7cix1YR3T9hOpeq2a2xZmB kwfViFdnCphUQ== Message-ID: <3d4168e0f7e62a31a00b3a16d155224842442dd8.camel@kernel.org> Subject: Re: [PATCH v3] tracing/histogram: Rename "cpu" to "common_cpu" From: Tom Zanussi To: Steven Rostedt , LKML Cc: Masami Hiramatsu , Namhyung Kim , Ingo Molnar , Andrew Morton Date: Wed, 21 Jul 2021 15:19:00 -0500 In-Reply-To: <20210721110053.26b4f641@oasis.local.home> References: <20210721110053.26b4f641@oasis.local.home> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Steve, On Wed, 2021-07-21 at 11:00 -0400, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Currently the histogram logic allows the user to write "cpu" in as an > event field, and it will record the CPU that the event happened on. > > The problem with this is that there's a lot of events that have "cpu" > as a real field, and using "cpu" as the CPU it ran on, makes it > impossible to run histograms on the "cpu" field of events. > Yes, you're absolutely right, it should have been named "common_cpu" from the start, not only for this reason but also just for the sake of consistency. Reviewed-by: Tom Zanussi