From: Bhaumik Bhatt <bbhatt@codeaurora.org>
To: Jeffrey Hugo <jhugo@codeaurora.org>
Cc: manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org,
hemantk@codeaurora.org, linux-kernel@vger.kernel.org,
loic.poulain@linaro.org, carl.yin@quectel.com,
naveen.kumar@quectel.com, jhugo=codeaurora.org@codeaurora.org
Subject: Re: [PATCH v3 1/3] bus: mhi: core: Introduce internal register poll helper function
Date: Wed, 10 Mar 2021 14:56:59 -0800 [thread overview]
Message-ID: <3d554e8bf92278d9f0ddb8f852880b68@codeaurora.org> (raw)
In-Reply-To: <b53a5cf8-aa25-0e89-b83f-57ec32fa7075@codeaurora.org>
On 2021-03-10 10:57 AM, Jeffrey Hugo wrote:
> On 2/23/2021 8:44 PM, Bhaumik Bhatt wrote:
>> Introduce helper function to allow MHI core driver to poll for
>> a value in a register field. This helps reach a common path to
>> read and poll register values along with a retry time interval.
>>
>> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
>> ---
>> drivers/bus/mhi/core/internal.h | 3 +++
>> drivers/bus/mhi/core/main.c | 23 +++++++++++++++++++++++
>> 2 files changed, 26 insertions(+)
>>
>> diff --git a/drivers/bus/mhi/core/internal.h
>> b/drivers/bus/mhi/core/internal.h
>> index 6f80ec3..005286b 100644
>> --- a/drivers/bus/mhi/core/internal.h
>> +++ b/drivers/bus/mhi/core/internal.h
>> @@ -643,6 +643,9 @@ int __must_check mhi_read_reg(struct
>> mhi_controller *mhi_cntrl,
>> int __must_check mhi_read_reg_field(struct mhi_controller
>> *mhi_cntrl,
>> void __iomem *base, u32 offset, u32 mask,
>> u32 shift, u32 *out);
>> +int __must_check mhi_poll_reg_field(struct mhi_controller *mhi_cntrl,
>> + void __iomem *base, u32 offset, u32 mask,
>> + u32 shift, u32 val, u32 delayus);
>> void mhi_write_reg(struct mhi_controller *mhi_cntrl, void __iomem
>> *base,
>> u32 offset, u32 val);
>> void mhi_write_reg_field(struct mhi_controller *mhi_cntrl, void
>> __iomem *base,
>> diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
>> index 4e0131b..249ae26 100644
>> --- a/drivers/bus/mhi/core/main.c
>> +++ b/drivers/bus/mhi/core/main.c
>> @@ -4,6 +4,7 @@
>> *
>> */
>> +#include <linux/delay.h>
>> #include <linux/device.h>
>> #include <linux/dma-direction.h>
>> #include <linux/dma-mapping.h>
>> @@ -37,6 +38,28 @@ int __must_check mhi_read_reg_field(struct
>> mhi_controller *mhi_cntrl,
>> return 0;
>> }
>> +int __must_check mhi_poll_reg_field(struct mhi_controller
>> *mhi_cntrl,
>> + void __iomem *base, u32 offset,
>> + u32 mask, u32 shift, u32 val, u32 delayus)
>> +{
>> + int ret = -ENOENT;
Make this int ret;
>> + u32 out, retry = (mhi_cntrl->timeout_ms * 1000) / delayus;
>> +
>> + while (retry--) {
>> + ret = mhi_read_reg_field(mhi_cntrl, base, offset, mask, shift,
>> + &out);
>> + if (ret)
>> + return -EIO;
>
> I generally dislike recoding return codes. Do you believe it adds
> value here? I'm concerned that if I'm debugging an error, I'll get
> EIO, which I trace to here, but then I don't know what the actual
> error from mhi_read_reg_field() was.
>
Thanks for pointing out. I don't think its necessary to recode and I can
go back
to returning whatever the reg_field API returns. I have added the
proposed changes
here which help fix a potential bug that we'd return 0 if read is
successful but
polling fails.
>> +
>> + if (out == val)
>> + return 0;
>> +
>> + udelay(delayus);
>> + }
>> +
>> + return ret;
return -ENOENT; to signify failure to find the entry after poll duration
completes
>> +}
>> +
>> void mhi_write_reg(struct mhi_controller *mhi_cntrl, void __iomem
>> *base,
>> u32 offset, u32 val)
>> {
>>
Thanks,
Bhaumik
---
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2021-03-10 22:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 3:44 [PATCH v3 0/3] Polling for MHI ready Bhaumik Bhatt
2021-02-24 3:44 ` [PATCH v3 1/3] bus: mhi: core: Introduce internal register poll helper function Bhaumik Bhatt
2021-03-05 13:37 ` Loic Poulain
2021-03-10 18:57 ` Jeffrey Hugo
2021-03-10 22:56 ` Bhaumik Bhatt [this message]
2021-02-24 3:44 ` [PATCH v3 2/3] bus: mhi: core: Move to polling method to wait for MHI ready Bhaumik Bhatt
2021-03-10 19:02 ` Jeffrey Hugo
2021-03-10 22:58 ` Bhaumik Bhatt
2021-02-24 3:44 ` [PATCH v3 3/3] bus: mhi: core: Use poll register read API for RDDM download Bhaumik Bhatt
2021-03-10 19:04 ` Jeffrey Hugo
2021-02-24 9:27 ` [PATCH v3 0/3] Polling for MHI ready Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d554e8bf92278d9f0ddb8f852880b68@codeaurora.org \
--to=bbhatt@codeaurora.org \
--cc=carl.yin@quectel.com \
--cc=hemantk@codeaurora.org \
--cc=jhugo=codeaurora.org@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=naveen.kumar@quectel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.