From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3C06ECE587 for ; Mon, 14 Oct 2019 09:41:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C1C74207FF for ; Mon, 14 Oct 2019 09:41:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731085AbfJNJlT (ORCPT ); Mon, 14 Oct 2019 05:41:19 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:9804 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730977AbfJNJlT (ORCPT ); Mon, 14 Oct 2019 05:41:19 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x9E9b0dF087457 for ; Mon, 14 Oct 2019 05:41:18 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0b-001b2d01.pphosted.com with ESMTP id 2vmp26hcme-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 14 Oct 2019 05:41:18 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 14 Oct 2019 10:41:16 +0100 Received: from b06avi18878370.portsmouth.uk.ibm.com (9.149.26.194) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 14 Oct 2019 10:41:14 +0100 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x9E9fCmR44957968 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Oct 2019 09:41:12 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 916164204D; Mon, 14 Oct 2019 09:41:12 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A9C8B42042; Mon, 14 Oct 2019 09:41:11 +0000 (GMT) Received: from [10.0.2.15] (unknown [9.152.224.114]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 14 Oct 2019 09:41:11 +0000 (GMT) Subject: Re: [RFT PATCH 0/3] crypto: s390 - convert to skcipher API To: Eric Biggers , linux-crypto@vger.kernel.org, Herbert Xu Cc: linux-s390@vger.kernel.org, Heiko Carstens , Vasily Gorbik , Christian Borntraeger References: <20191012201809.160500-1-ebiggers@kernel.org> From: Harald Freudenberger Date: Mon, 14 Oct 2019 11:41:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191012201809.160500-1-ebiggers@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 19101409-0008-0000-0000-00000321DAFF X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19101409-0009-0000-0000-00004A40EC75 Message-Id: <3d65a0b0-7590-9150-82dc-06cf3c84d353@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-10-14_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910140092 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 12.10.19 22:18, Eric Biggers wrote: > This series converts the glue code for the S390 CPACF implementations of > AES, DES, and 3DES modes from the deprecated "blkcipher" API to the > "skcipher" API. This is needed in order for the blkcipher API to be > removed. > > I've compiled this patchset, and the conversion is very similar to that > which has been done for many other crypto drivers. But I don't have the > hardware to test it, nor is S390 CPACF supported by QEMU. So I really > need someone with the hardware to test it. You can do so by setting: > > CONFIG_CRYPTO_HW=y > CONFIG_ZCRYPT=y > CONFIG_PKEY=y > CONFIG_CRYPTO_AES_S390=y > CONFIG_CRYPTO_PAES_S390=y > CONFIG_CRYPTO_DES_S390=y > # CONFIG_CRYPTO_MANAGER_DISABLE_TESTS is not set > CONFIG_DEBUG_KERNEL=y > CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y > CONFIG_CRYPTO_AES=y > CONFIG_CRYPTO_DES=y > CONFIG_CRYPTO_CBC=y > CONFIG_CRYPTO_CTR=y > CONFIG_CRYPTO_ECB=y > CONFIG_CRYPTO_XTS=y > > Then boot and check for crypto self-test failures by running > 'dmesg | grep alg'. > > If there are test failures, please also check whether they were already > failing prior to this patchset. > > This won't cover the "paes" ("protected key AES") algorithms, however, > since those don't have self-tests. If anyone has any way to test those, > please do so. > > Eric Biggers (3): > crypto: s390/aes - convert to skcipher API > crypto: s390/paes - convert to skcipher API > crypto: s390/des - convert to skcipher API > > arch/s390/crypto/aes_s390.c | 609 ++++++++++++++--------------------- > arch/s390/crypto/des_s390.c | 419 ++++++++++-------------- > arch/s390/crypto/paes_s390.c | 414 ++++++++++-------------- > 3 files changed, 580 insertions(+), 862 deletions(-) > Thanks Eric, I'll do these tests and give you feedback.