From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B595C4332F for ; Wed, 23 Nov 2022 08:30:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236502AbiKWIaR (ORCPT ); Wed, 23 Nov 2022 03:30:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236424AbiKWIaQ (ORCPT ); Wed, 23 Nov 2022 03:30:16 -0500 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF45A12ABA for ; Wed, 23 Nov 2022 00:30:14 -0800 (PST) Received: by mail-lf1-x12f.google.com with SMTP id g7so27133920lfv.5 for ; Wed, 23 Nov 2022 00:30:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=so2oxuQ4Y7a0f26n1k3pKbLKlCZdT3KjE4FqYS40eg8=; b=zIKOQLWS42fFmJhVRRmxrUjpau1bS4ATAyMBrR1xPqJZy+k6yCWZqTOOTzvDV4a9Yg Y++393P9WhJldpuJrNUmZjLm67LM/aen3AYMtBE4XybhQZ3PmkWpsh3CX+2QzmH/LhEc c48yVznBlXf3dx/pfoTgD95g7Jr/kfumTRPWAEeEz/HNsA8eVPwcjqq6ocu8h5rXAEdL 5JCigU1/grJHK2RMfTeAaxaVi03R7JfCop/K71tlNYNHXT3ATw8FsF/T+yN/UqDm0gar vS00COq+uTf/xAFzBt7o//Kmnn72FOQuXgEj45tZCMuSO/Pvd9OSRLd9PTowMuJIi/FT 3SVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=so2oxuQ4Y7a0f26n1k3pKbLKlCZdT3KjE4FqYS40eg8=; b=ntxPWYOzWb/qwKeA1kJ3JkINf+6HuvWvhD1w8OqlwsfuPllGUQ2XOoNPkOeQTEs6GG 3w/VCQsSdRm9CzK9hIvGYX5u7FuWsfX6qNBQi746c5bw7xEADsL3p/FxrP9032acjRDP tKKXODWT5Vp//CEiOyWMGWU58Ia/HNHBz9F1RiiMQL2pvpsR8UgGnHnwub1AqX5SB/RO l3l+u0YJ9myc0C/kUv77hfC4G356wQPMhzzgH1EnD6+KhFy0WuMuTQ/sIOUjauiJN8GV bl8nRy8Yjkk79XhS3vhLWJS/L03ysTzhmALEHfqLTfcX7XhjR9W0iO4XwYdj0fBOb6+m AoaQ== X-Gm-Message-State: ANoB5pkQpw2LCL0JmR7EE3rChymuqg66RhAHNi4IguBwMGOPNixaum44 KBotzPSLRYbEEFTMlRpCgevEkQ== X-Google-Smtp-Source: AA0mqf69iu9qQh6fCA6UDIq1hcLsriLuOE6oSPhjtXZDsQsFgavDS6cW7I/64DKInOEgrT2IoBd0kQ== X-Received: by 2002:ac2:434d:0:b0:4a2:51a2:9326 with SMTP id o13-20020ac2434d000000b004a251a29326mr8767700lfl.594.1669192213077; Wed, 23 Nov 2022 00:30:13 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id c12-20020a056512324c00b0048af3c090f8sm2809369lfr.13.2022.11.23.00.30.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Nov 2022 00:30:12 -0800 (PST) Message-ID: <3d689f8e-ae2d-2b3e-e783-94b8e6ba8aa0@linaro.org> Date: Wed, 23 Nov 2022 09:30:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [v4 2/5] dt-bindings: pwm: Add bindings for aspeed pwm controller Content-Language: en-US To: Billy Tsai , jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, joel@jms.id.au, andrew@aj.id.au, lee@kernel.org, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, corbet@lwn.net, p.zabel@pengutronix.de, linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, linux-doc@vger.kernel.org References: <20221123061635.32025-1-billy_tsai@aspeedtech.com> <20221123061635.32025-3-billy_tsai@aspeedtech.com> From: Krzysztof Kozlowski In-Reply-To: <20221123061635.32025-3-billy_tsai@aspeedtech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On 23/11/2022 07:16, Billy Tsai wrote: > Add the aspeed pwm device bindings which should be the child-node of > pwm-tach mfd. Subject: drop second, redundant "bindings". > > Signed-off-by: Billy Tsai > --- > .../bindings/pwm/aspeed,ast2600-pwm.yaml | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml > > diff --git a/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml b/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml > new file mode 100644 > index 000000000000..68a60fc73902 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2021 Aspeed, Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pwm/aspeed,ast2600-pwm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Aspeed Ast2600 PWM controller > + > +maintainers: > + - Billy Tsai > + > +description: | > + The Aspeed PWM controller supports up to 16 PWM outputs. > + This module is part of the ast2600-pwm-tach multi-function device. For more > + details see ../mfd/aspeed,ast2600-pwm-tach.yaml. > + > +allOf: > + - $ref: pwm.yaml# > + > +properties: > + compatible: > + enum: > + - aspeed,ast2600-pwm > + > + "#pwm-cells": > + const: 3 Blank line. > +patternProperties: > + "^pwm@[a-z0-9]+$": > + description: Set extend properties for each pwm channel. Description is not a correct sentence. Description explains the hardware property you have here. > + type: object > + properties: > + reg: > + description: > + The pwm channel index. > + maxItems: 1 > + > + aspeed,wdt-reload-enable: > + type: boolean > + description: > + Enable the function of wdt reset reload duty point. > + > + aspeed,wdt-reload-duty-point: > + description: > + Define the duty point after wdt reset, 0 = 100% > + minimum: 0 > + maximum: 255 Why maximum is 255? Why 0=100%? 0 should be equal to 0 and maximum to some maximum value (e.g. 100%). If these are percents, use appropriate units. If these are not - what are these? You need a $ref in such case. > + required: > + - reg > + > +required: > + - compatible > + > +additionalProperties: false Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA2FAC4332F for ; Wed, 23 Nov 2022 08:32:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q+aa6hhnKtZn0uUA8cywrshzgQvBzq2h1XQeuXyvgdA=; b=D3oJy1PRdpUp9S UhiKKI6zlB4DJWLZMLIwhbKK0ie9RHvZGsxaEETOLzdMeP/PezPs+u/v/wynYeRaUBv0npRib1PSa 9GzR4FlRKhGF2kueIUNam/tbf2EABhnrkETCcaUMw0Syh6xoZ1+w/yLbNRLw+i3TJSMEpxMJh3D5t p9A+fyNPwzWsu1qTmXEKVeeaRqpO05znqBy46zpawWKxcIwSvhJwjxUxpBVL/TnICTIMb8Tf+T/sh PSpbI5jlfsMdoAi75jAz/Oz6XYJMvnFzIInaHtBJmegmyP25xW24D5O75vZH1rEH12iBkojCl+e6k 5Fu8NG1MVF1Wp1lL7tgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxl9l-00FY7J-II; Wed, 23 Nov 2022 08:30:58 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxl96-00FXlV-SY for linux-arm-kernel@lists.infradead.org; Wed, 23 Nov 2022 08:30:18 +0000 Received: by mail-lf1-x129.google.com with SMTP id be13so27118594lfb.4 for ; Wed, 23 Nov 2022 00:30:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=so2oxuQ4Y7a0f26n1k3pKbLKlCZdT3KjE4FqYS40eg8=; b=zIKOQLWS42fFmJhVRRmxrUjpau1bS4ATAyMBrR1xPqJZy+k6yCWZqTOOTzvDV4a9Yg Y++393P9WhJldpuJrNUmZjLm67LM/aen3AYMtBE4XybhQZ3PmkWpsh3CX+2QzmH/LhEc c48yVznBlXf3dx/pfoTgD95g7Jr/kfumTRPWAEeEz/HNsA8eVPwcjqq6ocu8h5rXAEdL 5JCigU1/grJHK2RMfTeAaxaVi03R7JfCop/K71tlNYNHXT3ATw8FsF/T+yN/UqDm0gar vS00COq+uTf/xAFzBt7o//Kmnn72FOQuXgEj45tZCMuSO/Pvd9OSRLd9PTowMuJIi/FT 3SVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=so2oxuQ4Y7a0f26n1k3pKbLKlCZdT3KjE4FqYS40eg8=; b=vsiZNeb5sMa7pxkri+To9lvhdfWXsUyKkhfhcls1Vdd7qBBjsSwLxz0oTcT88D51Jy +TAuLZ0qYVLKpik67+iTnO8Bpv2MehhQmdpFBvg0zAAu2Q8O1TJbs8J0nisiaansLfOR PSMVJHXT2yScN0ZYEzE7YE8Lk9xmA/pWu83Nlcs8GDBMSrQorQF/OEwEYjwNlMIxcYyR q7ecYkCfup1CBPwZoO/yBBOJ9kE3WPDMeY5PF9Q7fDV9uj/s4qPGMCDU7vBl/VIn+rbe x1w7lh9mwQ4DtV9Vwcfzci72OHP3zCfUFDwe2+kanCBo+skjxEtb0bfNpQp2LW6fPBDX pmlQ== X-Gm-Message-State: ANoB5pkDk3Ugbrc5Zw9Ogbz20/OchBNKsDIHNnIg6s45W00y2zRMLkPj YXm+NxNc0vQ6XDYnCNBkuvmQUE5VgMECiVor X-Google-Smtp-Source: AA0mqf69iu9qQh6fCA6UDIq1hcLsriLuOE6oSPhjtXZDsQsFgavDS6cW7I/64DKInOEgrT2IoBd0kQ== X-Received: by 2002:ac2:434d:0:b0:4a2:51a2:9326 with SMTP id o13-20020ac2434d000000b004a251a29326mr8767700lfl.594.1669192213077; Wed, 23 Nov 2022 00:30:13 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id c12-20020a056512324c00b0048af3c090f8sm2809369lfr.13.2022.11.23.00.30.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Nov 2022 00:30:12 -0800 (PST) Message-ID: <3d689f8e-ae2d-2b3e-e783-94b8e6ba8aa0@linaro.org> Date: Wed, 23 Nov 2022 09:30:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [v4 2/5] dt-bindings: pwm: Add bindings for aspeed pwm controller Content-Language: en-US To: Billy Tsai , jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, joel@jms.id.au, andrew@aj.id.au, lee@kernel.org, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, corbet@lwn.net, p.zabel@pengutronix.de, linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, linux-doc@vger.kernel.org References: <20221123061635.32025-1-billy_tsai@aspeedtech.com> <20221123061635.32025-3-billy_tsai@aspeedtech.com> From: Krzysztof Kozlowski In-Reply-To: <20221123061635.32025-3-billy_tsai@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221123_003016_972775_C2FDDFE3 X-CRM114-Status: GOOD ( 16.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/11/2022 07:16, Billy Tsai wrote: > Add the aspeed pwm device bindings which should be the child-node of > pwm-tach mfd. Subject: drop second, redundant "bindings". > > Signed-off-by: Billy Tsai > --- > .../bindings/pwm/aspeed,ast2600-pwm.yaml | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml > > diff --git a/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml b/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml > new file mode 100644 > index 000000000000..68a60fc73902 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2021 Aspeed, Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pwm/aspeed,ast2600-pwm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Aspeed Ast2600 PWM controller > + > +maintainers: > + - Billy Tsai > + > +description: | > + The Aspeed PWM controller supports up to 16 PWM outputs. > + This module is part of the ast2600-pwm-tach multi-function device. For more > + details see ../mfd/aspeed,ast2600-pwm-tach.yaml. > + > +allOf: > + - $ref: pwm.yaml# > + > +properties: > + compatible: > + enum: > + - aspeed,ast2600-pwm > + > + "#pwm-cells": > + const: 3 Blank line. > +patternProperties: > + "^pwm@[a-z0-9]+$": > + description: Set extend properties for each pwm channel. Description is not a correct sentence. Description explains the hardware property you have here. > + type: object > + properties: > + reg: > + description: > + The pwm channel index. > + maxItems: 1 > + > + aspeed,wdt-reload-enable: > + type: boolean > + description: > + Enable the function of wdt reset reload duty point. > + > + aspeed,wdt-reload-duty-point: > + description: > + Define the duty point after wdt reset, 0 = 100% > + minimum: 0 > + maximum: 255 Why maximum is 255? Why 0=100%? 0 should be equal to 0 and maximum to some maximum value (e.g. 100%). If these are percents, use appropriate units. If these are not - what are these? You need a $ref in such case. > + required: > + - reg > + > +required: > + - compatible > + > +additionalProperties: false Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel