From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Laurent Vivier <laurent@vivier.eu>,
"Michael S. Tsirkin" <mst@redhat.com>,
Wei Yang <richardw.yang@linux.intel.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, imammedo@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi
Date: Wed, 13 Feb 2019 09:56:38 +0100 [thread overview]
Message-ID: <3d700eed-5637-b05a-63c2-9f73a465bcb5@redhat.com> (raw)
In-Reply-To: <4d6f639b-fe11-7048-3975-ee1c1875b8d3@vivier.eu>
Hi Laurent,
On 2/13/19 9:49 AM, Laurent Vivier wrote:
> On 12/02/2019 06:34, Michael S. Tsirkin wrote:
>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote:
>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote:
>>>> There are several functions/variable which are not used anymore.
>>>>
>>>> This serials just remove those without functional change.
>>>>
>>>> v3: add ack and repost in a new thread
>>>> v2: change commit log from "is now used in no place" to "in not used anymore"
>>>
>>> Michael,
>>>
>>> Looks this serials is not merged yet.
>>>
>>> Is there any problem I need to fix?
>>
>> Yes pls repost with fixed reviewed-by tags.
>
> Or I can take the series through the trivial branch and update manually
> Philippe's lastname?
I appreciate the help with manual update, however Wei is not the only
one having this problem (other developpers has non-ASCII in their name,
and use such tags).
I'd rather prefer we find a proper configuration setup to help the
community.
Another (fair) approach is to forbid non-ASCII chars in all part of patches.
Regards,
Phil.
next prev parent reply other threads:[~2019-02-13 8:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 0:06 [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi Wei Yang
2019-01-30 0:06 ` [Qemu-devel] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init() Wei Yang
2019-01-30 8:10 ` Igor Mammedov
2019-01-30 9:50 ` Thomas Huth
2019-01-30 11:07 ` Philippe Mathieu-Daudé
2019-01-30 12:58 ` Wei Yang
2019-01-30 0:06 ` [Qemu-devel] [PATCH v3 2/3] hw/acpi: remove unused function acpi_table_add_builtin() Wei Yang
2019-01-30 8:11 ` Igor Mammedov
2019-01-30 0:06 ` [Qemu-devel] [PATCH v3 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin Wei Yang
2019-01-30 8:11 ` Igor Mammedov
2019-02-12 5:22 ` [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi Wei Yang
2019-02-12 5:34 ` Michael S. Tsirkin
2019-02-13 6:26 ` Wei Yang
2019-02-13 6:32 ` Philippe Mathieu-Daudé
2019-02-13 7:01 ` Wei Yang
2019-02-13 8:49 ` Laurent Vivier
2019-02-13 8:54 ` Wei Yang
2019-02-13 8:56 ` Philippe Mathieu-Daudé [this message]
2019-02-13 13:31 ` Wei Yang
2019-02-13 13:45 ` Laurent Vivier
2019-02-14 0:03 ` Wei Yang
2019-02-14 7:57 ` Laurent Vivier
2019-02-14 8:10 ` Laurent Vivier
2019-02-14 8:18 ` Wei Yang
2019-02-14 8:23 ` Laurent Vivier
2019-02-14 8:39 ` Wei Yang
2019-02-14 8:51 ` Wei Yang
2019-02-14 9:11 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d700eed-5637-b05a-63c2-9f73a465bcb5@redhat.com \
--to=philmd@redhat.com \
--cc=imammedo@redhat.com \
--cc=laurent@vivier.eu \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.