All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: Joe Perches <joe@perches.com>,
	Zhenzhong Duan <zhenzhong.duan@oracle.com>,
	linux-kernel@vger.kernel.org
Cc: bp@alien8.de, sstabellini@kernel.org, x86@kernel.org,
	tglx@linutronix.de, xen-devel@lists.xenproject.org,
	boris.ostrovsky@oracle.com, mingo@redhat.com
Subject: Re: [PATCH v8 4/5] x86/paravirt: Remove const mark from x86_hyper_xen_hvm variable
Date: Thu, 18 Jul 2019 05:48:34 +0200	[thread overview]
Message-ID: <3d74b1f6-37ae-dcb0-fa8a-6f02e183bbd7@suse.com> (raw)
In-Reply-To: <18469f4c80f3dbf04eda5415f4bcf1c8fa655370.camel@perches.com>

On 17.07.19 19:22, Joe Perches wrote:
> On Wed, 2019-07-17 at 08:49 +0200, Juergen Gross wrote:
>> On 17.07.19 08:46, Joe Perches wrote:
>>> On Tue, 2019-07-16 at 12:26 +0800, Zhenzhong Duan wrote:
>>>> .. as "nopv" support needs it to be changeable at boot up stage.
>>>>
>>>> Checkpatch reports warning, so move variable declarations from
>>>> hypervisor.c to hypervisor.h
>>> []
>>>> diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c
>>> []
>>>> @@ -259,7 +259,7 @@ static __init void xen_hvm_guest_late_init(void)
>>>>    #endif
>>>>    }
>>>>    
>>>> -const __initconst struct hypervisor_x86 x86_hyper_xen_hvm = {
>>>> +struct hypervisor_x86 x86_hyper_xen_hvm __initdata = {
>>>
>>> static?
>>
>> It is being referenced from arch/x86/kernel/cpu/hypervisor.c
> 
> But wasn't it also removed from the list of externs?
> 
> Rereading the .h file, no it wasn't.  I missed that.
> 
> Perhaps the extern list could be reordered to move this
> x86_hyper_xen_hvm to be next to x86_hyper_type.
> 
> I also suggest that "extern bool nopv" might be a bit
> non-specific and could use a longer identifier.

You are a little bit late. It has been this way since V5 of the series
posted on July 3rd.

I have pushed the series to my tree already and I'm about to send the
pull request.

Followup patches welcome. :-)


Juergen

WARNING: multiple messages have this Message-ID (diff)
From: Juergen Gross <jgross@suse.com>
To: Joe Perches <joe@perches.com>,
	Zhenzhong Duan <zhenzhong.duan@oracle.com>,
	linux-kernel@vger.kernel.org
Cc: sstabellini@kernel.org, x86@kernel.org, mingo@redhat.com,
	bp@alien8.de, xen-devel@lists.xenproject.org,
	boris.ostrovsky@oracle.com, tglx@linutronix.de
Subject: Re: [Xen-devel] [PATCH v8 4/5] x86/paravirt: Remove const mark from x86_hyper_xen_hvm variable
Date: Thu, 18 Jul 2019 05:48:34 +0200	[thread overview]
Message-ID: <3d74b1f6-37ae-dcb0-fa8a-6f02e183bbd7@suse.com> (raw)
In-Reply-To: <18469f4c80f3dbf04eda5415f4bcf1c8fa655370.camel@perches.com>

On 17.07.19 19:22, Joe Perches wrote:
> On Wed, 2019-07-17 at 08:49 +0200, Juergen Gross wrote:
>> On 17.07.19 08:46, Joe Perches wrote:
>>> On Tue, 2019-07-16 at 12:26 +0800, Zhenzhong Duan wrote:
>>>> .. as "nopv" support needs it to be changeable at boot up stage.
>>>>
>>>> Checkpatch reports warning, so move variable declarations from
>>>> hypervisor.c to hypervisor.h
>>> []
>>>> diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c
>>> []
>>>> @@ -259,7 +259,7 @@ static __init void xen_hvm_guest_late_init(void)
>>>>    #endif
>>>>    }
>>>>    
>>>> -const __initconst struct hypervisor_x86 x86_hyper_xen_hvm = {
>>>> +struct hypervisor_x86 x86_hyper_xen_hvm __initdata = {
>>>
>>> static?
>>
>> It is being referenced from arch/x86/kernel/cpu/hypervisor.c
> 
> But wasn't it also removed from the list of externs?
> 
> Rereading the .h file, no it wasn't.  I missed that.
> 
> Perhaps the extern list could be reordered to move this
> x86_hyper_xen_hvm to be next to x86_hyper_type.
> 
> I also suggest that "extern bool nopv" might be a bit
> non-specific and could use a longer identifier.

You are a little bit late. It has been this way since V5 of the series
posted on July 3rd.

I have pushed the series to my tree already and I'm about to send the
pull request.

Followup patches welcome. :-)


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-07-18  3:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-16  4:26 [PATCH v8 4/5] x86/paravirt: Remove const mark from x86_hyper_xen_hvm variable Zhenzhong Duan
2019-07-16  4:26 ` [Xen-devel] " Zhenzhong Duan
2019-07-16  4:26 ` [PATCH v8 5/5] x86/xen: Add "nopv" support for HVM guest Zhenzhong Duan
2019-07-16  4:26   ` [Xen-devel] " Zhenzhong Duan
2019-07-17  4:58 ` [PATCH v8 4/5] x86/paravirt: Remove const mark from x86_hyper_xen_hvm variable Juergen Gross
2019-07-17  4:58   ` [Xen-devel] " Juergen Gross
2019-07-17  6:46 ` Joe Perches
2019-07-17  6:46   ` [Xen-devel] " Joe Perches
2019-07-17  6:49   ` Juergen Gross
2019-07-17  6:49     ` [Xen-devel] " Juergen Gross
2019-07-17 17:22     ` Joe Perches
2019-07-17 17:22       ` [Xen-devel] " Joe Perches
2019-07-18  3:48       ` Juergen Gross [this message]
2019-07-18  3:48         ` Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d74b1f6-37ae-dcb0-fa8a-6f02e183bbd7@suse.com \
    --to=jgross@suse.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=sstabellini@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    --cc=zhenzhong.duan@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.