Re: [PATCH qemu v22] spapr: Implement Open Firmware client interface

From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Greg Kurz <groug@kaod.org>
Subject: Re: [PATCH qemu v22] spapr: Implement Open Firmware client interface
Date: Thu, 8 Jul 2021 16:38:18 +1000	[thread overview]
Message-ID: <3d90be86-0a75-de06-0c54-9c246f5035e7@ozlabs.ru> (raw)
In-Reply-To: <YOZlnOiCeeF4mwJO@yekko>

On 08/07/2021 12:40, David Gibson wrote:

> [snip]
>> +static uint32_t vof_getprop(const void *fdt, uint32_t nodeph, uint32_t pname,
>> +                            uint32_t valaddr, uint32_t vallen)
>> +{
>> +    char propname[OF_PROPNAME_LEN_MAX + 1];
>> +    uint32_t ret = 0;
>> +    int proplen = 0;
>> +    const void *prop;
>> +    char trval[64] = "";
>> +    int nodeoff = fdt_node_offset_by_phandle(fdt, nodeph);
>> +    bool write0;
>> +
>> +    if (nodeoff < 0) {
>> +        return -1;
> 
> Shouldn't many of these explicit -1s be PROM_ERR, since you defined it?

It is defined in the firmware only and I forgot why :)

pc-bios/vof/ci.c|72 col 16| return PROM_ERROR;
pc-bios/vof/vof.h|13 col 9| #define PROM_ERROR (-1u)

I'll just ditch it, does not seem helping with anything.

-- 
Alexey