From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0422C43381 for ; Wed, 27 Feb 2019 16:36:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 696CA2186A for ; Wed, 27 Feb 2019 16:36:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r+pfbaDc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727636AbfB0Qgf (ORCPT ); Wed, 27 Feb 2019 11:36:35 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:42188 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726299AbfB0Qge (ORCPT ); Wed, 27 Feb 2019 11:36:34 -0500 Received: by mail-pg1-f194.google.com with SMTP id b2so8204130pgl.9 for ; Wed, 27 Feb 2019 08:36:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=J/XLlViTihVnFcCOH2y4ulNwbS5ju4suOZfLXAYjQNM=; b=r+pfbaDcgHOP7x2klLEDrkSLVq7JBGEmEu8HAsCproeSfMok0W6IhTn8n1rfcHMk3D mKFR4SR4bgD6mk9GU+mk0euDdWiWBafZC9ieCNXJGxG78Rn45DYGsh+HpmCGdpsdnJ4Z UShIx2VS/MsiVy3dI3LkbqcgJCX4kQUV/4cLD5WDkAjY1r/70quxr1N0ntzvGUbJmCW1 xA0pZqmFojGwoJ3A7kq1fYC2ku52ORbUXO6COGQXj2Aqn7XjllR9bO3hpzwJsj4xGHEa kItLIBWjSJwSjYRfslfMeildfKPdE9frY9W7OletrDhxVh9OEfJjplUSV6GprWSKxY90 hL+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=J/XLlViTihVnFcCOH2y4ulNwbS5ju4suOZfLXAYjQNM=; b=Wu3ZphU9O3rXOpdJ8bwh1c8ypK1bMx967utD3+llPrElFymqukLG5brTO5SYn+YjPo MsgXTOuI4E/DozwduqFs8EPfgpP0duX6+W6ueCkMTQ2odE9eVNEGMib7moJM4RWVKW4r i/wgIPbuVx+kzskYPRoj0Ysek/iLUMVAziQB93T6t2LcZfihd/5vN1jN0vN100S4Gilx zsgFjiM45pJRNhIAkfuyREIgnIouyB7H7qYJJXSvL5LR9FaRu0IZhwnWpPSsB7njwyVh wR5ynG+ubUMX7bQpkfzkMSrjEgoOjzTUkOMjDGvk4ZTpD1jna0/DTtVemsiUt9R6n06t 8FzQ== X-Gm-Message-State: AHQUAuY2MnrswXcqKS1Oo0mEu5IIGBqKeQNsLQR+G0CMEEVVixs0p0bJ QrmWZ63LKlNshKaeML/baR8= X-Google-Smtp-Source: AHgI3IZXyr+DgJdh2MfHUeDMEp7YaduiSoSJg1lkxy//aqUwO8Sup6WnY441dvTgAuYpZjra9HXUfw== X-Received: by 2002:a63:702:: with SMTP id 2mr3809306pgh.14.1551285394064; Wed, 27 Feb 2019 08:36:34 -0800 (PST) Received: from ?IPv6:2601:282:800:fd80:a962:f770:b5d3:740c? ([2601:282:800:fd80:a962:f770:b5d3:740c]) by smtp.googlemail.com with ESMTPSA id j24sm24245415pgl.58.2019.02.27.08.36.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Feb 2019 08:36:33 -0800 (PST) Subject: Re: [PATCH v3 iproute2-next 05/11] devlink: Add devlink health show command To: Aya Levin Cc: netdev@vger.kernel.org, Jiri Pirko , Moshe Shemesh , Eran Ben Elisha References: <1551012378-29167-1-git-send-email-ayal@mellanox.com> <1551012378-29167-6-git-send-email-ayal@mellanox.com> From: David Ahern Message-ID: <3d9aaa14-c9e5-595e-61db-514e869bcf39@gmail.com> Date: Wed, 27 Feb 2019 09:36:31 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1551012378-29167-6-git-send-email-ayal@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/24/19 5:46 AM, Aya Levin wrote: > Add devlink health show command which displays status and configuration > info on a specific reporter on a device or dump the info on all > reporters on all devices. Add helper functions to display status and > dump's time stamp. > Example: > $ devlink health show pci/0000:00:09.0 reporter tx > pci/0000:00:09.0: > name tx > state healthy error 0 recover 1 last_dump_date 2019-02-14 last_dump_time 10:10:10 grace_period 600 auto_recover true > $ devlink health show pci/0000:00:09.0 reporter tx -jp > { > "health":{ > "pci/0000:00:0a.0":[ > { > "name":"tx", > "state":"healthy", > "error":0, > "recover":1, > "last_dump_date":"2019-Feb-14", > "last_dump_time":"10:10:10", > "grace_period":600, > "auto_recover":true > } > ] > } > > Signed-off-by: Aya Levin > Reviewed-by: Moshe Shemesh > Acked-by: Jiri Pirko > --- > devlink/devlink.c | 185 +++++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 184 insertions(+), 1 deletion(-) > This one no longer applies. Please respin.