From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Ojha <mojha@codeaurora.org>
Subject: Re: [PATCH -next] ASoC: simple-card-utils: remove set
 but not used variable ''
Date: Mon, 25 Mar 2019 14:50:09 +0530
Message-ID: <3da28172-d1af-1b04-f15b-e9b90a8fd98d@codeaurora.org>
References: <20190323020838.107533-1-yuehaibing@huawei.com>
 <6a0c2306-088f-cdbc-0730-60b899611c6f@codeaurora.org>
 <ae41e273-1c0e-c178-cc94-7f0330b7559f@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by alsa1.perex.cz (Postfix) with ESMTPS id C1255F801D9
 for <alsa-devel@alsa-project.org>; Mon, 25 Mar 2019 10:20:34 +0100 (CET)
In-Reply-To: <ae41e273-1c0e-c178-cc94-7f0330b7559f@huawei.com>
Content-Language: en-US
List-Unsubscribe: <https://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <https://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: "Alsa-devel" <alsa-devel-bounces@alsa-project.org>
To: YueHaibing <yuehaibing@huawei.com>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
List-Id: alsa-devel@alsa-project.org


On 3/25/2019 1:28 PM, YueHaibing wrote:
> On 2019/3/25 15:42, Mukesh Ojha wrote:
>> On 3/23/2019 7:38 AM, YueHaibing wrote:
>>> Fixes gcc '-Wunused-but-set-variable' warning:
>>>
>>> sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk':
>>> sound/soc/generic/simple-card-utils.c:164:18: warning:
>>>    parameter 'dai_name' set but not used [-Wunused-but-set-parameter]
>>>
>>> It's not used since commit 0580dde59438 ("ASoC: simple-card-utils: add
>>
>> I am not able to find this commit
>>
>> 0580dde59438
> It's now in linux-next tree.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=0580dde59438686d60762b6da9229ebec693b94f


I see the print is removed, dai_name becomes ununsed variable.

Reviewed-by: Mukesh Ojha <mojha@codeaurora.org 
<mailto:mojha@codeaurora.org>>

Thanks.
Mukesh


>>
>>> asoc_simple_debug_info()"), so can be removed.
>>>
>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>> ---
>>>    sound/soc/generic/simple-card-utils.c | 4 +---
>>>    1 file changed, 1 insertion(+), 3 deletions(-)
>>>
>>> diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c
>>> index 4ed68348f939..db1458a19985 100644
>>> --- a/sound/soc/generic/simple-card-utils.c
>>> +++ b/sound/soc/generic/simple-card-utils.c
>>> @@ -173,10 +173,8 @@ int asoc_simple_parse_clk(struct device *dev,
>>>         * see
>>>         *    soc-core.c :: snd_soc_init_multicodec()
>>>         */
>>> -    if (dlc) {
>>> +    if (dlc)
>>>            dai_of_node    = dlc->of_node;
>>> -        dai_name    = dlc->dai_name;
>> I don't see any function like `asoc_simple_parse_clk`
>>
>> but instead this `asoc_simple_card_parse_clk` and there the variable is used.
>>
>> Can you double check latest code base ?
>>
>> Thanks,
>> Mukesh
>>
>>
>>> -    }
>>>          /*
>>>         * Parse dai->sysclk come from "clocks = <&xxx>"
>>>
>>>
>>>
>>>
>>>
>> .
>>