From: Guenter Roeck <linux@roeck-us.net>
To: Agathe Porte <agathe.porte@nokia.com>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>
Cc: Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Adamski,
Krzysztof (Nokia - PL/Wroclaw)" <krzysztof.adamski@nokia.com>
Subject: Re: [PATCH v7 2/2] hwmon: Add driver for Texas Instruments TMP464 and TMP468
Date: Mon, 14 Mar 2022 18:22:47 -0700 [thread overview]
Message-ID: <3dac349c-6470-1673-effb-354da2b52481@roeck-us.net> (raw)
In-Reply-To: <51ea03f0-627b-2e9d-5972-2053fa12b9b5@nokia.com>
Hi Agathe,
On 3/14/22 08:46, Agathe Porte wrote:
> Hi,
>
> Le 2/22/2022 à 11:36 PM, Guenter Roeck a écrit :
>> of_property_read_string(child,"label", &data->channel[channel].label);
>
> Upon trying to merge v7 in our codebase, our static analyzer tool detected that the return code of this function was not checked.
>
> As I guess putting a label is optional, maybe we should add a `(void)` on the same line just before the function call to clearly indicate that not checking the return value is intentional and that it is not a coding mistake?
>
> EDIT: As I was reading the implementation of of_property_read_string [1], it will not touch the destination string in case of error. Which means that labels may sit uninitialized and contain garbage data?
>
Thanks for the feedback.
If of_property_read_string() returns an error, it will not set the pointer
to &data->channel[channel].label, which by default is NULL because the
data structure was allocated with devm_kzalloc(). That means tmp464_is_visible()
will disable the label attribute. I don't see a problem with the current
code.
There are lots of examples in the kernel where the return value from
of_property_read_string() is silently ignored. Not a single one of
those uses a (void) typecast. I don't really want to start making
such changes just to make static analyzers happy.
Thanks,
Guenter
next prev parent reply other threads:[~2022-03-15 1:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 22:36 [PATCH v7 1/2] dt-bindings: hwmon: add tmp464.yaml Guenter Roeck
2022-02-22 22:36 ` [PATCH v7 2/2] hwmon: Add driver for Texas Instruments TMP464 and TMP468 Guenter Roeck
2022-03-02 17:59 ` Guenter Roeck
2022-03-03 8:57 ` Agathe Porte
2022-03-03 15:00 ` Guenter Roeck
2022-03-03 15:31 ` Agathe Porte
2022-03-03 15:41 ` Guenter Roeck
[not found] ` <51ea03f0-627b-2e9d-5972-2053fa12b9b5@nokia.com>
2022-03-15 1:22 ` Guenter Roeck [this message]
2022-03-15 13:03 ` Agathe Porte
2022-03-15 15:57 ` Guenter Roeck
2022-02-24 16:11 ` [PATCH v7 1/2] dt-bindings: hwmon: add tmp464.yaml Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dac349c-6470-1673-effb-354da2b52481@roeck-us.net \
--to=linux@roeck-us.net \
--cc=agathe.porte@nokia.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.adamski@nokia.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.