From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2EE3C433DB for ; Tue, 2 Feb 2021 14:53:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 71F8F64F4D for ; Tue, 2 Feb 2021 14:53:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234752AbhBBOxy (ORCPT ); Tue, 2 Feb 2021 09:53:54 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:25220 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234829AbhBBOvk (ORCPT ); Tue, 2 Feb 2021 09:51:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612277403; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9RQsTX71NL19IDLfCoq3ZLQUlhLj824QwkOpBMNAD80=; b=GZFWjvk0C/SY0FwSDgqh1ofN8wnf0K84mBnj7RhQGPD2BcH1P5ab0UdQF4fyBEzz6+WCJS AObgPzLxPXvJYhQaJF7+DDr5AtOlrRQ0yPVDi2Eyrm30BcqjFKdEGUFM2cyEVpZg3CO3yI FsL6PTFoiT0fwViZ9jUdkbhIogVXMh0= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-102-BuPNs7xuMaiJEaJSPVNcYA-1; Tue, 02 Feb 2021 09:50:01 -0500 X-MC-Unique: BuPNs7xuMaiJEaJSPVNcYA-1 Received: by mail-ed1-f69.google.com with SMTP id o8so9730812edh.12 for ; Tue, 02 Feb 2021 06:50:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9RQsTX71NL19IDLfCoq3ZLQUlhLj824QwkOpBMNAD80=; b=W9XH8FwXlo+O+jwRzgEfLwIHFN1W/LqKkqBG6PCvqgBYbG+J2wDDYeIx8Xzj9dKKMm AVWLzWrdInea3FugfRVFn7I52z3d4O4yTLJ7CwgoOyja3OgQJLR3qW66ZytB6Oh06lsM jyaNaK7Fu7doJXQG8VmcfhYIa3WX3WmR9QNFY+H/W8vx4dUFYGCtBOiTsYALWaPtZrNr 02lFeTaNlQE3rcDqg/JlcNY43M23U8Q+PZDMzeYqzLS7Kai8UtgkN0OfDg84qPdZ9IH2 ijUAdbHSmLZfHXoseEgn8+6kknMSJ+ao616xYccXHOfyqgwv+rFWBO5NPsKOT840JsCo rulQ== X-Gm-Message-State: AOAM533vCzMhNnhRahmHe4vvcfVzEKi9OIuS67sfO3igJ2/dvh4jr9Hu ms03QDsdzjVdgurJr/XWGB6Ind+zBn2XpbGmZfhoLzBcngPAjYW3b87wZ5F7/Y4dlb/T4kyhf1U EpBPyhSIf/3vEGLj1xlSxwjbpDFU3I/5JAMIBI3S6Z4IFA4GSSOY4YltEuB3akUKPY+UicQHyWe KF X-Received: by 2002:a05:6402:3494:: with SMTP id v20mr16071043edc.146.1612277399392; Tue, 02 Feb 2021 06:49:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJwXyL+UoR1XVxrp6tYLe4iwa2Xkd4MHKYs+ajSZvDy+STf2K3TUHQvditVmgXlOTLse3lOHuQ== X-Received: by 2002:a05:6402:3494:: with SMTP id v20mr16070993edc.146.1612277398764; Tue, 02 Feb 2021 06:49:58 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id j23sm10153810edv.45.2021.02.02.06.49.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Feb 2021 06:49:57 -0800 (PST) To: Chenyi Qiang , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Xiaoyao Li Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210202090433.13441-1-chenyi.qiang@intel.com> <20210202090433.13441-2-chenyi.qiang@intel.com> From: Paolo Bonzini Subject: Re: [PATCH v2 1/3] KVM: X86: Rename DR6_INIT to DR6_ACTIVE_LOW Message-ID: <3db069ba-b4e0-1288-ec79-66ac44938682@redhat.com> Date: Tue, 2 Feb 2021 15:49:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210202090433.13441-2-chenyi.qiang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/02/21 10:04, Chenyi Qiang wrote: > > #define DR6_FIXED_1 0xfffe0ff0 > -#define DR6_INIT 0xffff0ff0 > +/* > + * DR6_ACTIVE_LOW is actual the result of DR6_FIXED_1 | ACTIVE_LOW_BITS. > + * We can regard all the current FIXED_1 bits as active_low bits even > + * though in no case they will be turned into 0. But if they are defined > + * in the future, it will require no code change. > + * At the same time, it can be served as the init/reset value for DR6. > + */ > +#define DR6_ACTIVE_LOW 0xffff0ff0 > #define DR6_VOLATILE 0x0001e00f > Committed with some changes in the wording of the comment. Also, DR6_FIXED_1 is (DR6_ACTIVE_LOW & ~DR6_VOLATILE). Paolo