From: Eric Blake <eblake@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Stefano Garzarella <sgarzare@redhat.com>
Cc: qemu-devel@nongnu.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
George Kennedy <george.kennedy@oracle.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Marc-Andre Lureau <marcandre.lureau@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Stefan Hajnoczi <stefanha@redhat.com>,
Liam Merwick <liam.merwick@oracle.com>,
Maran Wilson <maran.wilson@oracle.com>
Subject: Re: [Qemu-devel] [PATCH v2 4/4] hw/i386/pc: use PVH option rom
Date: Tue, 15 Jan 2019 13:12:21 -0600 [thread overview]
Message-ID: <3db58f6f-44fc-da64-2cfb-41404a9b2319@redhat.com> (raw)
In-Reply-To: <20190115135548-mutt-send-email-mst@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]
On 1/15/19 12:57 PM, Michael S. Tsirkin wrote:
> On Tue, Jan 15, 2019 at 11:00:58AM +0100, Stefano Garzarella wrote:
>> Use pvh.bin option rom when we are booting an uncompressed
>> kernel using the x86/HVM direct boot ABI.
>>
>> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
>> Based-on: <1545422632-24444-5-git-send-email-liam.merwick@oracle.com>
>
> I don't think this is a great way to give attribution.
> Can you pls include the author name and the S.O.B from there as well?
>
>
>> ---
Patchew understands Based-on: tags as meaning a prerequisite patch on
the list that must be applied first before this patch can apply (and NOT
in the sense that this patch is an updated revision to replace an
earlier revision posted by someone else) - but when using the annotation
to keep Patchew happy, it should either be in a 0/N cover letter, or for
a single patch, after the --- separator, as the condition of a
prerequisite patch not being applied is a transient condition relevant
to the current build but not something that needs to be recorded in
long-term git history.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]
next prev parent reply other threads:[~2019-01-15 19:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 10:00 [Qemu-devel] [PATCH v2 0/4] pvh: add new PVH option rom Stefano Garzarella
2019-01-15 10:00 ` [Qemu-devel] [PATCH v2 1/4] linuxboot_dma: remove duplicate definitions of FW_CFG Stefano Garzarella
2019-01-15 10:00 ` [Qemu-devel] [PATCH v2 2/4] linuxboot_dma: move common functions in a new header Stefano Garzarella
2019-01-15 10:00 ` [Qemu-devel] [PATCH v2 3/4] optionrom: add new PVH option rom Stefano Garzarella
2019-01-16 10:16 ` Liam Merwick
2019-01-16 11:02 ` Stefano Garzarella
2019-01-15 10:00 ` [Qemu-devel] [PATCH v2 4/4] hw/i386/pc: use " Stefano Garzarella
2019-01-15 18:57 ` Michael S. Tsirkin
2019-01-15 19:12 ` Eric Blake [this message]
2019-01-15 20:05 ` Michael S. Tsirkin
2019-01-15 21:50 ` Paolo Bonzini
2019-01-16 8:19 ` Stefano Garzarella
2019-01-16 8:22 ` Stefano Garzarella
2019-01-18 17:33 ` Eduardo Habkost
2019-01-15 14:24 ` [Qemu-devel] [PATCH v2 0/4] pvh: add new " Stefan Hajnoczi
2019-01-16 10:18 ` Liam Merwick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3db58f6f-44fc-da64-2cfb-41404a9b2319@redhat.com \
--to=eblake@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ehabkost@redhat.com \
--cc=george.kennedy@oracle.com \
--cc=kraxel@redhat.com \
--cc=liam.merwick@oracle.com \
--cc=maran.wilson@oracle.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.