From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "open list:Network Block Dev..." <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] nbd/server: Nicer spelling of max BLOCK_STATUS reply length
Date: Mon, 13 May 2019 09:31:33 -0500 [thread overview]
Message-ID: <3dfc080f-9878-f40f-f8c0-40c134bf99b6@redhat.com> (raw)
In-Reply-To: <f72c864a-b695-cf35-f183-f1818fc5609a@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]
On 5/13/19 5:03 AM, Vladimir Sementsov-Ogievskiy wrote:
> 10.05.2019 18:17, Eric Blake wrote:
>> Commit 3d068aff (3.0) introduced NBD_MAX_BITMAP_EXTENTS as a limit on
>> how large we would allow a reply to NBD_CMD_BLOCK_STATUS to grow when
>> it is visiting a qemu:dirty-bitmap: context. Later, commit fb7afc79
>> (3.1) reused the constant to limit base:allocation context replies,
>> although the name is now less appropriate in that situation.
>>
>> Rename things, and improve the macro to use units.h for better
>> legibility. Then reformat the comment to comply with checkpatch rules
>> added in the meantime. No semantic change.
>>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>
>
> With or without Stefano's suggestion:
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
I'm assuming Reviewed-by instead of Signed-off-by?
I'll queue this through my NBD tree, with Stefano's suggestion added in.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-05-13 14:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 15:17 [Qemu-devel] [PATCH] nbd/server: Nicer spelling of max BLOCK_STATUS reply length Eric Blake
2019-05-13 7:54 ` [Qemu-devel] [Qemu-block] " Stefano Garzarella
2019-05-13 10:03 ` [Qemu-devel] " Vladimir Sementsov-Ogievskiy
2019-05-13 14:31 ` Eric Blake [this message]
2019-05-13 14:47 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dfc080f-9878-f40f-f8c0-40c134bf99b6@redhat.com \
--to=eblake@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.