From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD330C77B61 for ; Fri, 28 Apr 2023 12:21:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345614AbjD1MVz (ORCPT ); Fri, 28 Apr 2023 08:21:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230106AbjD1MVw (ORCPT ); Fri, 28 Apr 2023 08:21:52 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BEFC2724 for ; Fri, 28 Apr 2023 05:21:46 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-2f86ee42669so9449989f8f.2 for ; Fri, 28 Apr 2023 05:21:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682684505; x=1685276505; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zJRfumNsycQad/le1DWiZZ20NIuNmrLWpYlzEA2kVtU=; b=OMzA3/Am3mFmo80RiHxiTLWHsl1TP/rhS2K1Ss6708SrYrXoTjFMFnEwfKe8klIPPv fnMiuaGfcHUUdyCYqQPa+Qh9MD4/JLJ5rwkomzX2QexIS8lsL9eIr7/maOBUHdwVzm8j tjyrZh9Gjdq9DtNDgm4+xZl/nQ2grMD48OK/rUgrXRFhiR21OuaWHV1UNL3tu8Jt81kw 2a5TyxWGadxerL2ydtCjOdCnYvZUTPrbWrpXwdHIwDcd7QkIRDLtPFDIWaPDMrpK1WWS x8wEGTSrpND/U3csOnCjNYOoaRGc6L5RelBs1QEzKwVMwTn9Bb955AUwLOx8ynnpaEs2 s8eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682684505; x=1685276505; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zJRfumNsycQad/le1DWiZZ20NIuNmrLWpYlzEA2kVtU=; b=eSZE+oMb1/NRlOZFjU1bj20DY8sYdNcSqETw79qkTLIceaOAK1pd7STWbB89A3pO6V ATknd87HYT+/QcIIknMC8BWWD5iaCDTyx9Qdjd0DApl+3BCV9QtPCbyz4nIpQIRULIDn s45KeSL3TNFYQaQBGDhQ2UQJqBuGuyhv8W6kvIbiyValhmiKMgzjBwK8yffRv7eRBu6A Q6tV8cXYji1r/knc7a07o1ydOOsSrWR64pdlrrNXrxM5Af3UqjkCOl7XR8JtGwAyHTnD i5S0PcVD9TjDXMziOFgXZWB2jr4kthRkS69s9G+eKwz6OctRy/Oqq0lDD5AQSU2KCLzx Jj+g== X-Gm-Message-State: AC+VfDxFAshGk16AjcdskRlCmJY4Qd6LwOROulVcYbzqS7jffE8pSkKq G8Zj9VntldJYy+pdTDvIICm6iQ== X-Google-Smtp-Source: ACHHUZ5KOVTQTuUmVpmyccDePstLauzAQKH/YGLX3/ZD+6wFjN7hEDUhXqujsvo4UnNn7rqqiunbsA== X-Received: by 2002:a5d:400e:0:b0:2f6:a7a:1ded with SMTP id n14-20020a5d400e000000b002f60a7a1dedmr3725409wrp.30.1682684505000; Fri, 28 Apr 2023 05:21:45 -0700 (PDT) Received: from [172.23.2.142] ([195.167.132.10]) by smtp.gmail.com with ESMTPSA id o3-20020a05600c378300b003ef5f77901dsm24150251wmr.45.2023.04.28.05.21.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Apr 2023 05:21:44 -0700 (PDT) Message-ID: <3e1a8567-efef-ee4a-b16f-b3f81570f88b@linaro.org> Date: Fri, 28 Apr 2023 14:21:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 07/43] dt-bindings: rtc: add DT bindings for Cirrus EP93xx Content-Language: en-US To: Nikita Shubin Cc: Arnd Bergmann , Linus Walleij , Alexander Sverdlin , Alessandro Zummo , Alexandre Belloni , Rob Herring , Hartley Sweeten , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230424123522.18302-1-nikita.shubin@maquefel.me> <20230424123522.18302-8-nikita.shubin@maquefel.me> <9e7583be-ad4a-0ccc-08f6-cdf3fa4ed6bd@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/04/2023 16:35, Nikita Shubin wrote: > On Tue, 2023-04-25 at 11:28 +0200, Krzysztof Kozlowski wrote: >> On 24/04/2023 14:34, Nikita Shubin wrote: >>> This adds device tree bindings for the Cirrus Logic EP93xx >>> RTC block used in these SoCs. >> >> Thank you for your patch. There is something to discuss/improve. >> >>> >>> Signed-off-by: Nikita Shubin >>> --- >>>  .../bindings/rtc/cirrus,ep93xx-rtc.yaml       | 32 >>> +++++++++++++++++++ >>>  1 file changed, 32 insertions(+) >>>  create mode 100644 >>> Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/rtc/cirrus,ep93xx- >>> rtc.yaml b/Documentation/devicetree/bindings/rtc/cirrus,ep93xx- >>> rtc.yaml >>> new file mode 100644 >>> index 000000000000..d4774e984e7b >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml >>> @@ -0,0 +1,32 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/rtc/cirrus,ep93xx-rtc.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Cirrus EP93xx Real Time Clock controller >>> + >>> +maintainers: >>> +  - Hartley Sweeten >>> +  - Alexander Sverdlin >>> + >>> +properties: >>> +  compatible: >>> +    const: cirrus,ep9301-rtc >> >> Why only one compatible? What about ep9307 and ep9312? The same >> question >> for your previous patch - timer. >> >> Anyway, if you want to keep it like that, then filename should match >> compatible. Or merge it into trivial-rtc like Alexandre suggested. > > I think i should move it to trivial-rtc - there is no need for a > separate file. If you add missing compatibles, you won't be able to move it easily to trivial-rtc. Best regards, Krzysztof