From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38552ECAAD5 for ; Sat, 3 Sep 2022 10:44:29 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7A3C9848CA; Sat, 3 Sep 2022 12:44:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1662201867; bh=bCep1KKmKM/WUyi4PYDxVrW6K0X07YR7mEvCXIWbwUE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=TxOmg/BARBv6c/wfGuvXzTUxTNVwegS1znK7ePw4NzywAeWnXmdYQMG4ZK8BpZXQk Igmy66q0Dk8OjLQJhv6x3o9r8l8USM2r0APYlfMUVI5USrQL2snQemAA6/Jn+RhYuY L+EMe5WnRV1m0fY8qeFNDdBrrcNyjmWYVSFPvtAugoG8TRlB6hgFrP+11C3xrz/pB+ a1FxU+kcqXq1fwAWpVasmvZ/4zHZ9MPjUmDJ7qp8wFeM6vw1LWJP4fYYHQP33rwGfE FRtByqcPtpXjlHAFMixQEzbL4ncBnOyoHtM8XwoXV9fe64DMdRyGZIiVOH134Y7gZC vdfDAVxaxCsUg== Received: by phobos.denx.de (Postfix, from userid 109) id 5818E8490A; Sat, 3 Sep 2022 12:44:26 +0200 (CEST) Received: from mout-u-107.mailbox.org (mout-u-107.mailbox.org [80.241.59.207]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0F2E68452F for ; Sat, 3 Sep 2022 12:44:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-107.mailbox.org (Postfix) with ESMTPS id 4MKWcQ171yz9sQ9; Sat, 3 Sep 2022 12:44:22 +0200 (CEST) Content-Type: multipart/mixed; boundary="------------nRqpn3mQSkSUCDhlUyzsIwMj" Message-ID: <3e1fdcaf-2d9d-bcfb-3067-d8c723af52cb@denx.de> Date: Sat, 3 Sep 2022 12:44:20 +0200 MIME-Version: 1.0 Subject: Re: [PATCH v2 3/8] timer: orion-timer: Add timer_get_boot_us() for BOOTSTAGE support Content-Language: en-US To: Tony Dinh Cc: U-Boot Mailing List , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Michael Walle , Simon Glass References: <20220902062554.1197435-1-sr@denx.de> <20220902062554.1197435-4-sr@denx.de> From: Stefan Roese In-Reply-To: X-Rspamd-Queue-Id: 4MKWcQ171yz9sQ9 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean This is a multi-part message in MIME format. --------------nRqpn3mQSkSUCDhlUyzsIwMj Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Tony, On 03.09.22 11:44, Tony Dinh wrote: > Hi Stefan, > > On Thu, Sep 1, 2022 at 11:25 PM Stefan Roese wrote: >> >> Add timer_get_boot_us() to support boards, that have CONFIG_BOOTSTAGE >> enabled, like pogo_v4. >> >> Signed-off-by: Stefan Roese >> --- >> v2: >> - Change timer_get_boot_us() to use the timer_early functions >> - Remove #if CONFIG_IS_ENABLED(BOOTSTAGE) >> >> Simon, I'm currently looking into this timer_get_boot_us() to using >> timer_early_get_count() etc consolidation. > > Indeed, as you've mentioned above, I think timer_early_get_count() and > timer_early_get_rate() do need to take into consideration what the > input_clock_type is for Kirkwood boards with CONFIG_BOOTSTAGE such as > the Pogo V4. > > I'm seeing on the Pogo V4 test, the timer command reports time about 6 > times slower than it should. It does seem to jive with the fact that > the Pogo V4 CONFIG_SYS_TCLK is 166Mhz, versus MVEBU 25MHz clock rate. Ah, I've missing updating the early functions to also differentiate between fixed clocks and TCLK timer. Please give the attached patch a try - should be applied on top of this latest patchset. Thanks, Stefan --------------nRqpn3mQSkSUCDhlUyzsIwMj Content-Type: text/x-patch; charset=UTF-8; name="orion-timer-fix-early-init.patch" Content-Disposition: attachment; filename="orion-timer-fix-early-init.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2RyaXZlcnMvdGltZXIvb3Jpb24tdGltZXIuYyBiL2RyaXZlcnMvdGlt ZXIvb3Jpb24tdGltZXIuYwppbmRleCA2YzBiODU1MDQxMmQuLmNkNjNlYTkxNjIzNyAxMDA2 NDQKLS0tIGEvZHJpdmVycy90aW1lci9vcmlvbi10aW1lci5jCisrKyBiL2RyaXZlcnMvdGlt ZXIvb3Jpb24tdGltZXIuYwpAQCAtMjMsMTIgKzIzLDU2IEBAIHN0cnVjdCBvcmlvbl90aW1l cl9wcml2IHsKIAogI2RlZmluZSBNVkVCVV9USU1FUl9GSVhFRF9SQVRFXzI1TUhaCTI1MDAw MDAwCiAKK3N0YXRpYyBib29sIGVhcmx5X2luaXRfZG9uZSBfX3NlY3Rpb24oIi5kYXRhIikg PSBmYWxzZTsKKworLyogQ29tbW9uIGZ1bmN0aW9ucyBmb3IgZWFybHkgKGJvb3QpIGFuZCBE TSBiYXNlZCB0aW1lciAqLworc3RhdGljIHZvaWQgb3Jpb25fdGltZXJfaW5pdCh2b2lkICpi YXNlLCBlbnVtIGlucHV0X2Nsb2NrX3R5cGUgdHlwZSkKK3sKKwl3cml0ZWwofjAsIGJhc2Ug KyBUSU1FUjBfVkFMKTsKKwl3cml0ZWwofjAsIGJhc2UgKyBUSU1FUjBfUkVMT0FEKTsKKwor CWlmICh0eXBlID09IElOUFVUX0NMT0NLXzI1TUhaKSB7CisJCS8qCisJCSAqIE9uIEFybWFk YSBYUCAvIDM4eCAuLi4sIHRoZSAyNU1IeiBjbG9jayBzb3VyY2UgbmVlZHMgdG8KKwkJICog YmUgZW5hYmxlZAorCQkgKi8KKwkJc2V0Yml0c19sZTMyKGJhc2UgKyBUSU1FUl9DVFJMLCBC SVQoMTEpKTsKKwl9CisKKwkvKiBlbmFibGUgdGltZXIgKi8KKwlzZXRiaXRzX2xlMzIoYmFz ZSArIFRJTUVSX0NUUkwsIFRJTUVSMF9FTiB8IFRJTUVSMF9SRUxPQURfRU4pOworfQorCitz dGF0aWMgdWludDY0X3Qgb3Jpb25fdGltZXJfZ2V0X2NvdW50KHZvaWQgKmJhc2UpCit7CisJ cmV0dXJuIHRpbWVyX2NvbnZfNjQofnJlYWRsKGJhc2UgKyBUSU1FUjBfVkFMKSk7Cit9CisK Ky8qIEVhcmx5IChlLmcuIGJvb3RzdGFnZSBldGMpIHRpbWVyIGZ1bmN0aW9ucyAqLworc3Rh dGljIHZvaWQgbm90cmFjZSB0aW1lcl9lYXJseV9pbml0KHZvaWQpCit7CisJLyogT25seSBp bml0IHRoZSB0aW1lciBvbmNlICovCisJaWYgKGVhcmx5X2luaXRfZG9uZSkKKwkJcmV0dXJu OworCWVhcmx5X2luaXRfZG9uZSA9IHRydWU7CisKKwlpZiAoSVNfRU5BQkxFRChDT05GSUdf QVJDSF9NVkVCVSkpCisJCW9yaW9uX3RpbWVyX2luaXQoKHZvaWQgKilNVkVCVV9USU1FUl9C QVNFLCBJTlBVVF9DTE9DS18yNU1IWik7CisJZWxzZQorCQlvcmlvbl90aW1lcl9pbml0KCh2 b2lkICopTVZFQlVfVElNRVJfQkFTRSwgSU5QVVRfQ0xPQ0tfTk9OX0ZJWEVEKTsKK30KKwog LyoqCiAgKiB0aW1lcl9lYXJseV9nZXRfcmF0ZSgpIC0gR2V0IHRoZSB0aW1lciByYXRlIGJl Zm9yZSBkcml2ZXIgbW9kZWwKICAqLwogdW5zaWduZWQgbG9uZyBub3RyYWNlIHRpbWVyX2Vh cmx5X2dldF9yYXRlKHZvaWQpCiB7Ci0JcmV0dXJuIE1WRUJVX1RJTUVSX0ZJWEVEX1JBVEVf MjVNSFo7CisJdGltZXJfZWFybHlfaW5pdCgpOworCisJaWYgKElTX0VOQUJMRUQoQ09ORklH X0FSQ0hfTVZFQlUpKQorCQlyZXR1cm4gTVZFQlVfVElNRVJfRklYRURfUkFURV8yNU1IWjsK KwllbHNlCisJCXJldHVybiBDT05GSUdfU1lTX1RDTEs7CiB9CiAKIC8qKgpAQCAtMzcsNyAr ODEsOSBAQCB1bnNpZ25lZCBsb25nIG5vdHJhY2UgdGltZXJfZWFybHlfZ2V0X3JhdGUodm9p ZCkKICAqLwogdTY0IG5vdHJhY2UgdGltZXJfZWFybHlfZ2V0X2NvdW50KHZvaWQpCiB7Ci0J cmV0dXJuIHRpbWVyX2NvbnZfNjQofnJlYWRsKE1WRUJVX1RJTUVSX0JBU0UgKyBUSU1FUjBf VkFMKSk7CisJdGltZXJfZWFybHlfaW5pdCgpOworCisJcmV0dXJuIG9yaW9uX3RpbWVyX2dl dF9jb3VudCgodm9pZCAqKU1WRUJVX1RJTUVSX0JBU0UpOwogfQogCiB1bG9uZyB0aW1lcl9n ZXRfYm9vdF91cyh2b2lkKQpAQCAtNDgsMTEgKzk0LDEyIEBAIHVsb25nIHRpbWVyX2dldF9i b290X3VzKHZvaWQpCiAJcmV0dXJuIGxsZGl2KHRpY2tzICogMTAwMCwgdGltZXJfZWFybHlf Z2V0X3JhdGUoKSk7CiB9CiAKLXN0YXRpYyB1aW50NjRfdCBvcmlvbl90aW1lcl9nZXRfY291 bnQoc3RydWN0IHVkZXZpY2UgKmRldikKKy8qIERNIHRpbWVyIGZ1bmN0aW9ucyAqLworc3Rh dGljIHVpbnQ2NF90IGRtX29yaW9uX3RpbWVyX2dldF9jb3VudChzdHJ1Y3QgdWRldmljZSAq ZGV2KQogewogCXN0cnVjdCBvcmlvbl90aW1lcl9wcml2ICpwcml2ID0gZGV2X2dldF9wcml2 KGRldik7CiAKLQlyZXR1cm4gdGltZXJfY29udl82NCh+cmVhZGwocHJpdi0+YmFzZSArIFRJ TUVSMF9WQUwpKTsKKwlyZXR1cm4gb3Jpb25fdGltZXJfZ2V0X2NvdW50KHByaXYtPmJhc2Up OwogfQogCiBzdGF0aWMgaW50IG9yaW9uX3RpbWVyX3Byb2JlKHN0cnVjdCB1ZGV2aWNlICpk ZXYpCkBAIC02NywyOCArMTE0LDE3IEBAIHN0YXRpYyBpbnQgb3Jpb25fdGltZXJfcHJvYmUo c3RydWN0IHVkZXZpY2UgKmRldikKIAkJcmV0dXJuIC1FTk9NRU07CiAJfQogCi0Jd3JpdGVs KH4wLCBwcml2LT5iYXNlICsgVElNRVIwX1ZBTCk7Ci0Jd3JpdGVsKH4wLCBwcml2LT5iYXNl ICsgVElNRVIwX1JFTE9BRCk7Ci0KLQlpZiAodHlwZSA9PSBJTlBVVF9DTE9DS18yNU1IWikg ewotCQkvKgotCQkgKiBPbiBBcm1hZGEgWFAgLyAzOHggLi4uLCB0aGUgMjVNSHogY2xvY2sg c291cmNlIG5lZWRzIHRvCi0JCSAqIGJlIGVuYWJsZWQKLQkJICovCi0JCXNldGJpdHNfbGUz Mihwcml2LT5iYXNlICsgVElNRVJfQ1RSTCwgQklUKDExKSk7CisJaWYgKHR5cGUgPT0gSU5Q VVRfQ0xPQ0tfMjVNSFopCiAJCXVjX3ByaXYtPmNsb2NrX3JhdGUgPSBNVkVCVV9USU1FUl9G SVhFRF9SQVRFXzI1TUhaOwotCX0gZWxzZSB7CisJZWxzZQogCQl1Y19wcml2LT5jbG9ja19y YXRlID0gQ09ORklHX1NZU19UQ0xLOwotCX0KLQotCS8qIGVuYWJsZSB0aW1lciAqLwotCXNl dGJpdHNfbGUzMihwcml2LT5iYXNlICsgVElNRVJfQ1RSTCwgVElNRVIwX0VOIHwgVElNRVIw X1JFTE9BRF9FTik7CisJb3Jpb25fdGltZXJfaW5pdChwcml2LT5iYXNlLCB0eXBlKTsKIAog CXJldHVybiAwOwogfQogCiBzdGF0aWMgY29uc3Qgc3RydWN0IHRpbWVyX29wcyBvcmlvbl90 aW1lcl9vcHMgPSB7Ci0JLmdldF9jb3VudCA9IG9yaW9uX3RpbWVyX2dldF9jb3VudCwKKwku Z2V0X2NvdW50ID0gZG1fb3Jpb25fdGltZXJfZ2V0X2NvdW50LAogfTsKIAogc3RhdGljIGNv bnN0IHN0cnVjdCB1ZGV2aWNlX2lkIG9yaW9uX3RpbWVyX2lkc1tdID0gewo= --------------nRqpn3mQSkSUCDhlUyzsIwMj--